Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-11 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747/#review60843 --- Ship it! Ship It! - David McLaughlin On Nov. 8, 2014, 12:28

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Maxim Khutornenko
On Nov. 7, 2014, 10:20 p.m., Bill Farner wrote: src/main/python/apache/aurora/client/cli/cron.py, line 55 https://reviews.apache.org/r/27747/diff/1/?file=754819#file754819line55 This file has a mix of single- and double-quoted strings. Consider settling on single and avoid the

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747/ --- (Updated Nov. 7, 2014, 11:42 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747/#review60422 --- This patch does not apply cleanly on master (66bd6fe), do you need

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747/ --- (Updated Nov. 8, 2014, 12:28 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747/#review60449 --- Ship it! Master (66bd6fe) is green with this patch.