Re: Review Request 27892: Fixes for the make pycharm script:

2014-11-12 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/#review61032
---



build-support/python/make-pycharm-virtualenv
https://reviews.apache.org/r/27892/#comment102495

you can avoid the use of backslashes to escape the individual $s here if 
you use EOF


- Kevin Sweeney


On Nov. 11, 2014, 3:11 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27892/
 ---
 
 (Updated Nov. 11, 2014, 3:11 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fixes for the make pycharm script:
 
 1. Escape $'s
 2. Use root directory name as project name
 3. Exclude some noisy directories
 
 
 Diffs
 -
 
   build-support/python/make-pycharm-virtualenv 
 316ead7c92e0510cd53958f419686e902dc34204 
 
 Diff: https://reviews.apache.org/r/27892/diff/
 
 
 Testing
 ---
 
 $ cat .idea/incubator-aurora.iml 
 ?xml version=1.0 encoding=UTF-8?
 module type=PYTHON_MODULE version=4
   component name=NewModuleRootManager
 content url=file://$MODULE_DIR$
   sourceFolder url=file://$MODULE_DIR$/src/main/python 
 isTestSource=false /
   excludeFolder url=file://$MODULE_DIR$/.pants.d /
   excludeFolder url=file://$MODULE_DIR$/dist /
   excludeFolder url=file://$MODULE_DIR$/out /
 /content
 orderEntry type=inheritedJdk /
 orderEntry type=sourceFolder forTests=false /
   /component
   component name=TestRunnerService
 option name=projectConfiguration value=py.test /
 option name=PROJECT_TEST_RUNNER value=py.test /
   /component
 /module
 
 
 Thanks,
 
 Joshua Cohen

Re: Review Request 27892: Fixes for the make pycharm script:

2014-11-12 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/
---

(Updated Nov. 12, 2014, 7:29 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Quote heredoc limit string.


Repository: aurora


Description
---

Fixes for the make pycharm script:

1. Escape $'s
2. Use root directory name as project name
3. Exclude some noisy directories


Diffs (updated)
-

  build-support/python/make-pycharm-virtualenv 
316ead7c92e0510cd53958f419686e902dc34204 

Diff: https://reviews.apache.org/r/27892/diff/


Testing
---

$ cat .idea/incubator-aurora.iml 
?xml version=1.0 encoding=UTF-8?
module type=PYTHON_MODULE version=4
  component name=NewModuleRootManager
content url=file://$MODULE_DIR$
  sourceFolder url=file://$MODULE_DIR$/src/main/python 
isTestSource=false /
  excludeFolder url=file://$MODULE_DIR$/.pants.d /
  excludeFolder url=file://$MODULE_DIR$/dist /
  excludeFolder url=file://$MODULE_DIR$/out /
/content
orderEntry type=inheritedJdk /
orderEntry type=sourceFolder forTests=false /
  /component
  component name=TestRunnerService
option name=projectConfiguration value=py.test /
option name=PROJECT_TEST_RUNNER value=py.test /
  /component
/module


Thanks,

Joshua Cohen

Re: Review Request 27892: Fixes for the make pycharm script:

2014-11-12 Thread Joshua Cohen 


 On Nov. 12, 2014, 7:20 p.m., Kevin Sweeney wrote:
  build-support/python/make-pycharm-virtualenv, line 48
  https://reviews.apache.org/r/27892/diff/1/?file=758435#file758435line48
 
  you can avoid the use of backslashes to escape the individual $s here 
  if you use EOF

I always forget that. Fixed.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/#review61032
---


On Nov. 12, 2014, 7:29 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27892/
 ---
 
 (Updated Nov. 12, 2014, 7:29 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fixes for the make pycharm script:
 
 1. Escape $'s
 2. Use root directory name as project name
 3. Exclude some noisy directories
 
 
 Diffs
 -
 
   build-support/python/make-pycharm-virtualenv 
 316ead7c92e0510cd53958f419686e902dc34204 
 
 Diff: https://reviews.apache.org/r/27892/diff/
 
 
 Testing
 ---
 
 $ cat .idea/incubator-aurora.iml 
 ?xml version=1.0 encoding=UTF-8?
 module type=PYTHON_MODULE version=4
   component name=NewModuleRootManager
 content url=file://$MODULE_DIR$
   sourceFolder url=file://$MODULE_DIR$/src/main/python 
 isTestSource=false /
   excludeFolder url=file://$MODULE_DIR$/.pants.d /
   excludeFolder url=file://$MODULE_DIR$/dist /
   excludeFolder url=file://$MODULE_DIR$/out /
 /content
 orderEntry type=inheritedJdk /
 orderEntry type=sourceFolder forTests=false /
   /component
   component name=TestRunnerService
 option name=projectConfiguration value=py.test /
 option name=PROJECT_TEST_RUNNER value=py.test /
   /component
 /module
 
 
 Thanks,
 
 Joshua Cohen

Re: Review Request 27892: Fixes for the make pycharm script:

2014-11-12 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/#review61044
---

Ship it!


Ship It!

- Kevin Sweeney


On Nov. 12, 2014, 11:29 a.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27892/
 ---
 
 (Updated Nov. 12, 2014, 11:29 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fixes for the make pycharm script:
 
 1. Escape $'s
 2. Use root directory name as project name
 3. Exclude some noisy directories
 
 
 Diffs
 -
 
   build-support/python/make-pycharm-virtualenv 
 316ead7c92e0510cd53958f419686e902dc34204 
 
 Diff: https://reviews.apache.org/r/27892/diff/
 
 
 Testing
 ---
 
 $ cat .idea/incubator-aurora.iml 
 ?xml version=1.0 encoding=UTF-8?
 module type=PYTHON_MODULE version=4
   component name=NewModuleRootManager
 content url=file://$MODULE_DIR$
   sourceFolder url=file://$MODULE_DIR$/src/main/python 
 isTestSource=false /
   excludeFolder url=file://$MODULE_DIR$/.pants.d /
   excludeFolder url=file://$MODULE_DIR$/dist /
   excludeFolder url=file://$MODULE_DIR$/out /
 /content
 orderEntry type=inheritedJdk /
 orderEntry type=sourceFolder forTests=false /
   /component
   component name=TestRunnerService
 option name=projectConfiguration value=py.test /
 option name=PROJECT_TEST_RUNNER value=py.test /
   /component
 /module
 
 
 Thanks,
 
 Joshua Cohen

Re: Review Request 27892: Fixes for the make pycharm script:

2014-11-11 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/#review60893
---


Master (0774c4e) is red with this patch.
  ./build-support/jenkins/build.sh

  File /usr/lib/python2.7/sysconfig.py, line 355, in _init_posix
raise IOError(msg)
IOError: invalid Python installation: unable to open 
/x1/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/local/include/python2.7/pyconfig.h
 (No such file or directory)

Build operating on top level addresses: 
set([BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD,
 all)])
Problem executing PythonBuilder for targets 
OrderedSet([PythonTests(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD,
 host_maintenance)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 restarter)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 instance_watcher)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_client)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/au
 th/BUILD, auth)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 transport)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_mux)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 error_handling_thread)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 task_util)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 base)), PythonLibrary
 
(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 http_signaler)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater_util)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 sla)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 common)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 aurora_job_key)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster_option)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 clusters)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/
 workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, shellify)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-packaged)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-test)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-storage)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 job_monitor)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 quota_check)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace
 /AuroraBot/src/main/python/apache/aurora/admin/BUILD, host_maintenance)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/admin/BUILD,
 util)),

Re: Review Request 27892: Fixes for the make pycharm script:

2014-11-11 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/#review60894
---


@ReviewBot retry

- Joshua Cohen


On Nov. 11, 2014, 11:11 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27892/
 ---
 
 (Updated Nov. 11, 2014, 11:11 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fixes for the make pycharm script:
 
 1. Escape $'s
 2. Use root directory name as project name
 3. Exclude some noisy directories
 
 
 Diffs
 -
 
   build-support/python/make-pycharm-virtualenv 
 316ead7c92e0510cd53958f419686e902dc34204 
 
 Diff: https://reviews.apache.org/r/27892/diff/
 
 
 Testing
 ---
 
 $ cat .idea/incubator-aurora.iml 
 ?xml version=1.0 encoding=UTF-8?
 module type=PYTHON_MODULE version=4
   component name=NewModuleRootManager
 content url=file://$MODULE_DIR$
   sourceFolder url=file://$MODULE_DIR$/src/main/python 
 isTestSource=false /
   excludeFolder url=file://$MODULE_DIR$/.pants.d /
   excludeFolder url=file://$MODULE_DIR$/dist /
   excludeFolder url=file://$MODULE_DIR$/out /
 /content
 orderEntry type=inheritedJdk /
 orderEntry type=sourceFolder forTests=false /
   /component
   component name=TestRunnerService
 option name=projectConfiguration value=py.test /
 option name=PROJECT_TEST_RUNNER value=py.test /
   /component
 /module
 
 
 Thanks,
 
 Joshua Cohen

Re: Review Request 27892: Fixes for the make pycharm script:

2014-11-11 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/#review60898
---

Ship it!


Master (0774c4e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Nov. 11, 2014, 11:11 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27892/
 ---
 
 (Updated Nov. 11, 2014, 11:11 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fixes for the make pycharm script:
 
 1. Escape $'s
 2. Use root directory name as project name
 3. Exclude some noisy directories
 
 
 Diffs
 -
 
   build-support/python/make-pycharm-virtualenv 
 316ead7c92e0510cd53958f419686e902dc34204 
 
 Diff: https://reviews.apache.org/r/27892/diff/
 
 
 Testing
 ---
 
 $ cat .idea/incubator-aurora.iml 
 ?xml version=1.0 encoding=UTF-8?
 module type=PYTHON_MODULE version=4
   component name=NewModuleRootManager
 content url=file://$MODULE_DIR$
   sourceFolder url=file://$MODULE_DIR$/src/main/python 
 isTestSource=false /
   excludeFolder url=file://$MODULE_DIR$/.pants.d /
   excludeFolder url=file://$MODULE_DIR$/dist /
   excludeFolder url=file://$MODULE_DIR$/out /
 /content
 orderEntry type=inheritedJdk /
 orderEntry type=sourceFolder forTests=false /
   /component
   component name=TestRunnerService
 option name=projectConfiguration value=py.test /
 option name=PROJECT_TEST_RUNNER value=py.test /
   /component
 /module
 
 
 Thanks,
 
 Joshua Cohen

Re: Review Request 27892: Fixes for the make pycharm script:

2014-11-11 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27892/#review60918
---

Ship it!


Thanks!

- Bill Farner


On Nov. 11, 2014, 11:11 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/27892/
 ---
 
 (Updated Nov. 11, 2014, 11:11 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Fixes for the make pycharm script:
 
 1. Escape $'s
 2. Use root directory name as project name
 3. Exclude some noisy directories
 
 
 Diffs
 -
 
   build-support/python/make-pycharm-virtualenv 
 316ead7c92e0510cd53958f419686e902dc34204 
 
 Diff: https://reviews.apache.org/r/27892/diff/
 
 
 Testing
 ---
 
 $ cat .idea/incubator-aurora.iml 
 ?xml version=1.0 encoding=UTF-8?
 module type=PYTHON_MODULE version=4
   component name=NewModuleRootManager
 content url=file://$MODULE_DIR$
   sourceFolder url=file://$MODULE_DIR$/src/main/python 
 isTestSource=false /
   excludeFolder url=file://$MODULE_DIR$/.pants.d /
   excludeFolder url=file://$MODULE_DIR$/dist /
   excludeFolder url=file://$MODULE_DIR$/out /
 /content
 orderEntry type=inheritedJdk /
 orderEntry type=sourceFolder forTests=false /
   /component
   component name=TestRunnerService
 option name=projectConfiguration value=py.test /
 option name=PROJECT_TEST_RUNNER value=py.test /
   /component
 /module
 
 
 Thanks,
 
 Joshua Cohen