Re: Review Request 27935: Fix coverage epsilon.

2014-11-12 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27935/#review61113
---

Ship it!


This is now on master
```
$ git log -1 origin/master --abbrev-commit
commit 0ae2dec
Author: Joshua Cohen 
Date:   Wed Nov 12 15:07:40 2014 -0800

Fix coverage epsilon.

BUILD SUCCESSFUL

Reviewed at https://reviews.apache.org/r/27935/
```

- Bill Farner


On Nov. 12, 2014, 10:50 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27935/
> ---
> 
> (Updated Nov. 12, 2014, 10:50 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Math is hard.
> 
> 
> Diffs
> -
> 
>   build.gradle 135d1a92f8ac3e0c359c68b1c6f054ca78c3b0e9 
>   buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 
> 1d98442d5cc6ea065fc71e303c20ca196aaca703 
> 
> Diff: https://reviews.apache.org/r/27935/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> After changing epsilon:
> 
> FAILURE: Build failed with an exception.
> 
> * What went wrong:
> Execution failed for task ':analyzeReport'.
> > Instruction coverage of 0.88 exceeds min instruction coverage of 0.87, 
> by more than 0.005, please raise the threshold!
>   Branch coverage of 0.83 exceeds min instruction coverage of 0.82, by more 
> than 0.005, please raise the threshold!
>   
> After changing coverage thresholds everything passes:
> 
> :jacocoTestReport UP-TO-DATE
> :analyzeReport
> Instruction coverage of 0.8896474082590783 exceeds minimum coverage of 0.88.
> Branch coverage of 0.83991462113127 exceeds minimum coverage of 0.83.
> :check UP-TO-DATE
> :build UP-TO-DATE
> 
> BUILD SUCCESSFUL
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>



Re: Review Request 27935: Fix coverage epsilon.

2014-11-12 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27935/#review61112
---

Ship it!


Master (ea43999) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 12, 2014, 10:50 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27935/
> ---
> 
> (Updated Nov. 12, 2014, 10:50 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Math is hard.
> 
> 
> Diffs
> -
> 
>   build.gradle 135d1a92f8ac3e0c359c68b1c6f054ca78c3b0e9 
>   buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 
> 1d98442d5cc6ea065fc71e303c20ca196aaca703 
> 
> Diff: https://reviews.apache.org/r/27935/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> After changing epsilon:
> 
> FAILURE: Build failed with an exception.
> 
> * What went wrong:
> Execution failed for task ':analyzeReport'.
> > Instruction coverage of 0.88 exceeds min instruction coverage of 0.87, 
> by more than 0.005, please raise the threshold!
>   Branch coverage of 0.83 exceeds min instruction coverage of 0.82, by more 
> than 0.005, please raise the threshold!
>   
> After changing coverage thresholds everything passes:
> 
> :jacocoTestReport UP-TO-DATE
> :analyzeReport
> Instruction coverage of 0.8896474082590783 exceeds minimum coverage of 0.88.
> Branch coverage of 0.83991462113127 exceeds minimum coverage of 0.83.
> :check UP-TO-DATE
> :build UP-TO-DATE
> 
> BUILD SUCCESSFUL
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>



Re: Review Request 27935: Fix coverage epsilon.

2014-11-12 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27935/#review61108
---

Ship it!


Ship It!

- Bill Farner


On Nov. 12, 2014, 10:50 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27935/
> ---
> 
> (Updated Nov. 12, 2014, 10:50 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Math is hard.
> 
> 
> Diffs
> -
> 
>   build.gradle 135d1a92f8ac3e0c359c68b1c6f054ca78c3b0e9 
>   buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 
> 1d98442d5cc6ea065fc71e303c20ca196aaca703 
> 
> Diff: https://reviews.apache.org/r/27935/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> After changing epsilon:
> 
> FAILURE: Build failed with an exception.
> 
> * What went wrong:
> Execution failed for task ':analyzeReport'.
> > Instruction coverage of 0.88 exceeds min instruction coverage of 0.87, 
> by more than 0.005, please raise the threshold!
>   Branch coverage of 0.83 exceeds min instruction coverage of 0.82, by more 
> than 0.005, please raise the threshold!
>   
> After changing coverage thresholds everything passes:
> 
> :jacocoTestReport UP-TO-DATE
> :analyzeReport
> Instruction coverage of 0.8896474082590783 exceeds minimum coverage of 0.88.
> Branch coverage of 0.83991462113127 exceeds minimum coverage of 0.83.
> :check UP-TO-DATE
> :build UP-TO-DATE
> 
> BUILD SUCCESSFUL
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>



Re: Review Request 27935: Fix coverage epsilon.

2014-11-12 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27935/#review61107
---

Ship it!


Ship It!

- Maxim Khutornenko


On Nov. 12, 2014, 10:50 p.m., Joshua Cohen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27935/
> ---
> 
> (Updated Nov. 12, 2014, 10:50 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Math is hard.
> 
> 
> Diffs
> -
> 
>   build.gradle 135d1a92f8ac3e0c359c68b1c6f054ca78c3b0e9 
>   buildSrc/src/main/groovy/org/apache/aurora/CoverageReportCheck.groovy 
> 1d98442d5cc6ea065fc71e303c20ca196aaca703 
> 
> Diff: https://reviews.apache.org/r/27935/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> After changing epsilon:
> 
> FAILURE: Build failed with an exception.
> 
> * What went wrong:
> Execution failed for task ':analyzeReport'.
> > Instruction coverage of 0.88 exceeds min instruction coverage of 0.87, 
> by more than 0.005, please raise the threshold!
>   Branch coverage of 0.83 exceeds min instruction coverage of 0.82, by more 
> than 0.005, please raise the threshold!
>   
> After changing coverage thresholds everything passes:
> 
> :jacocoTestReport UP-TO-DATE
> :analyzeReport
> Instruction coverage of 0.8896474082590783 exceeds minimum coverage of 0.88.
> Branch coverage of 0.83991462113127 exceeds minimum coverage of 0.83.
> :check UP-TO-DATE
> :build UP-TO-DATE
> 
> BUILD SUCCESSFUL
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>