Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

2014-11-21 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28097/#review62591
---

Ship it!


Ship It!

- Kevin Sweeney


On Nov. 20, 2014, 11:43 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28097/
> ---
> 
> (Updated Nov. 20, 2014, 11:43 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-929
> https://issues.apache.org/jira/browse/AURORA-929
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> See updated class javadoc in `Storage` for new behavior description.  
> Ultimately we're accepting the risk of reading uncommitted writes 
> (specifically in `TaskStore` and `JobStore`).  In practice this should 
> generally be exceedingly rare, as most writes are atomic to one store anyway, 
> and for those that are not (such as rescheduling a task), the window should 
> be O(µs) long.
> 
> Once `DbStorage` owns all of the stores, we have a global knob for 
> transaction isolation: 
> http://mybatis.github.io/mybatis-3/java-api.html#sqlSessions (search that 
> page for `TransactionIsolationLevel`).
> 
> Without the ReadWriteLock in play, there is no longer a need for 
> `weaklyConsistentRead`, so i've removed that.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> e02921df3a217aa2678e91a8bebe6a3708dbc9c3 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java 
> d6b7fabe6642944e9fda87c5588029c5bb32c025 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 97d5d13fcb686c7199ccf92ddab04931d6d5ab57 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> ca54c9aa321c831abdbdb8bc1f8c06a0bff95ee2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 
> 58d074b491dab2e2e0ce8a8a57e4ebdaf0984e73 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> 84e37e49fabc7ac6bfa2967787cb6abb6ce4af5d 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
> 8e2d3d92c3404f9b24b802687c2d7faeeb27d318 
>   src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
> be8a1fff2db77414dd04637af4a8183810b66845 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> 883f954e5dc99311fb701d52dd5d737a50f23276 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> 5f3cce330a9ec7eb3bdfb3512791d918d4c9 
>   src/main/java/org/apache/aurora/scheduler/http/Slaves.java 
> 0ea462f5d1abbb9eec457205e1b9acca9976027a 
>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
> 8147d545dce3082d63f693c9620e3c769258d9e4 
>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java 
> 88150e564e70bf02b62c1c7477d126e98dd91437 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e38407ec487d511fb05142cbeda955ec5a6ba4ec 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 149bb33568d67fffdee944bf676199e7108b0c0d 
>   src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
> f167290bf99b76ccc049eb51fe95ccfce940d078 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> a835eaabb047ede5833ca80f43a0cb1bee01d142 
>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
> c30a8c94ca7328e07455a3ed17f11128beb3ce9b 
>   
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
>  0d02207d7bda46bcc84d2e7328a8c500ad9a5384 
>   src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 
> 4e6d68b039bb140509b1261f25e7b49457bfd2be 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 682bca881969d24ece40ab83356f1bebb77feabd 
>   
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
>  503bdfeb2cefccfdeb151190b04ce9ce445f47b1 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> 40487e5461da8062555e4e40ccb1c146ab665c5f 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 45ea50fff10c5ff10db3f225cdbbb0204f056d31 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> 73348f3ef0d7452497e14a3889f5c20da04e5455 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 66ff56714bfd1fc429a67d9da862172df5072639 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> 2cc76dc1583c43cb528e78275b8a4ad23b8529d2 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b66b916f690d1e407febd47df647ec6567a249

Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

2014-11-20 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28097/#review62508
---


Kevin - ping?

- Bill Farner


On Nov. 20, 2014, 7:43 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28097/
> ---
> 
> (Updated Nov. 20, 2014, 7:43 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-929
> https://issues.apache.org/jira/browse/AURORA-929
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> See updated class javadoc in `Storage` for new behavior description.  
> Ultimately we're accepting the risk of reading uncommitted writes 
> (specifically in `TaskStore` and `JobStore`).  In practice this should 
> generally be exceedingly rare, as most writes are atomic to one store anyway, 
> and for those that are not (such as rescheduling a task), the window should 
> be O(µs) long.
> 
> Once `DbStorage` owns all of the stores, we have a global knob for 
> transaction isolation: 
> http://mybatis.github.io/mybatis-3/java-api.html#sqlSessions (search that 
> page for `TransactionIsolationLevel`).
> 
> Without the ReadWriteLock in play, there is no longer a need for 
> `weaklyConsistentRead`, so i've removed that.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> e02921df3a217aa2678e91a8bebe6a3708dbc9c3 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java 
> d6b7fabe6642944e9fda87c5588029c5bb32c025 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> 97d5d13fcb686c7199ccf92ddab04931d6d5ab57 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> ca54c9aa321c831abdbdb8bc1f8c06a0bff95ee2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 
> 58d074b491dab2e2e0ce8a8a57e4ebdaf0984e73 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> 84e37e49fabc7ac6bfa2967787cb6abb6ce4af5d 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
> 8e2d3d92c3404f9b24b802687c2d7faeeb27d318 
>   src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
> be8a1fff2db77414dd04637af4a8183810b66845 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> 883f954e5dc99311fb701d52dd5d737a50f23276 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> 5f3cce330a9ec7eb3bdfb3512791d918d4c9 
>   src/main/java/org/apache/aurora/scheduler/http/Slaves.java 
> 0ea462f5d1abbb9eec457205e1b9acca9976027a 
>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
> 8147d545dce3082d63f693c9620e3c769258d9e4 
>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java 
> 88150e564e70bf02b62c1c7477d126e98dd91437 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e38407ec487d511fb05142cbeda955ec5a6ba4ec 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 149bb33568d67fffdee944bf676199e7108b0c0d 
>   src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
> f167290bf99b76ccc049eb51fe95ccfce940d078 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> a835eaabb047ede5833ca80f43a0cb1bee01d142 
>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
> c30a8c94ca7328e07455a3ed17f11128beb3ce9b 
>   
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
>  0d02207d7bda46bcc84d2e7328a8c500ad9a5384 
>   src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 
> 4e6d68b039bb140509b1261f25e7b49457bfd2be 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 682bca881969d24ece40ab83356f1bebb77feabd 
>   
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
>  503bdfeb2cefccfdeb151190b04ce9ce445f47b1 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> 40487e5461da8062555e4e40ccb1c146ab665c5f 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 45ea50fff10c5ff10db3f225cdbbb0204f056d31 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> 73348f3ef0d7452497e14a3889f5c20da04e5455 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 66ff56714bfd1fc429a67d9da862172df5072639 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> 2cc76dc1583c43cb528e78275b8a4ad23b8529d2 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b66b916f690d1e407febd47df647ec6567a249d9 
>

Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

2014-11-20 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28097/#review62406
---


Master (6d06d86) is red with this patch.
  ./build-support/jenkins/build.sh

Uninstalling setuptools:
  Successfully uninstalled setuptools
Successfully installed Markdown Pygments ansicolors cov-core coverage lockfile 
pantsbuild.pants pex psutil py pystache pytest pytest-cov python-daemon 
requests twitter.common.collections twitter.common.config 
twitter.common.confluence twitter.common.contextutil twitter.common.decorators 
twitter.common.dirutil twitter.common.lang twitter.common.log 
twitter.common.options twitter.common.process twitter.common.string 
twitter.common.threading twitter.common.util setuptools
Cleaning up...
Build operating on top level addresses: 
set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD,
 all)])
Problem executing PythonBuilder for targets 
OrderedSet([PythonTests(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD,
 host_maintenance)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 restarter)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 instance_watcher)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_client)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/au
 rora/common/auth/BUILD, auth)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 transport)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_mux)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 error_handling_thread)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 task_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/
 BUILD, base)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 http_signaler)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater_util)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 sla)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 common)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 aurora_job_key)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster_option)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 clusters)), PythonLibrary(B
 
uildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 shellify)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-packaged)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-test)), 
PythonThriftLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-storage)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 job_monitor)), 
PythonLibrary(BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main

Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

2014-11-20 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28097/
---

(Updated Nov. 20, 2014, 7:43 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
---

Realized the previous diff was parented against the wrong branch, new diff is 
sane.


Bugs: AURORA-929
https://issues.apache.org/jira/browse/AURORA-929


Repository: aurora


Description
---

See updated class javadoc in `Storage` for new behavior description.  
Ultimately we're accepting the risk of reading uncommitted writes (specifically 
in `TaskStore` and `JobStore`).  In practice this should generally be 
exceedingly rare, as most writes are atomic to one store anyway, and for those 
that are not (such as rescheduling a task), the window should be O(µs) long.

Once `DbStorage` owns all of the stores, we have a global knob for transaction 
isolation: http://mybatis.github.io/mybatis-3/java-api.html#sqlSessions (search 
that page for `TransactionIsolationLevel`).

Without the ReadWriteLock in play, there is no longer a need for 
`weaklyConsistentRead`, so i've removed that.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
cf8f7584afee758c527798914181049051aef0d8 
  src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
e02921df3a217aa2678e91a8bebe6a3708dbc9c3 
  src/main/java/org/apache/aurora/scheduler/async/KillRetry.java 
d6b7fabe6642944e9fda87c5588029c5bb32c025 
  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
97d5d13fcb686c7199ccf92ddab04931d6d5ab57 
  src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
ca54c9aa321c831abdbdb8bc1f8c06a0bff95ee2 
  src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 
58d074b491dab2e2e0ce8a8a57e4ebdaf0984e73 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
84e37e49fabc7ac6bfa2967787cb6abb6ce4af5d 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
8e2d3d92c3404f9b24b802687c2d7faeeb27d318 
  src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
be8a1fff2db77414dd04637af4a8183810b66845 
  src/main/java/org/apache/aurora/scheduler/http/Mname.java 
883f954e5dc99311fb701d52dd5d737a50f23276 
  src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
5f3cce330a9ec7eb3bdfb3512791d918d4c9 
  src/main/java/org/apache/aurora/scheduler/http/Slaves.java 
0ea462f5d1abbb9eec457205e1b9acca9976027a 
  src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
8147d545dce3082d63f693c9620e3c769258d9e4 
  src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java 
88150e564e70bf02b62c1c7477d126e98dd91437 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
e38407ec487d511fb05142cbeda955ec5a6ba4ec 
  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
149bb33568d67fffdee944bf676199e7108b0c0d 
  src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
f167290bf99b76ccc049eb51fe95ccfce940d078 
  src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
a835eaabb047ede5833ca80f43a0cb1bee01d142 
  src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
c30a8c94ca7328e07455a3ed17f11128beb3ce9b 
  
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
 0d02207d7bda46bcc84d2e7328a8c500ad9a5384 
  src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 
4e6d68b039bb140509b1261f25e7b49457bfd2be 
  src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
682bca881969d24ece40ab83356f1bebb77feabd 
  
src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 
503bdfeb2cefccfdeb151190b04ce9ce445f47b1 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
40487e5461da8062555e4e40ccb1c146ab665c5f 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
45ea50fff10c5ff10db3f225cdbbb0204f056d31 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
73348f3ef0d7452497e14a3889f5c20da04e5455 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
66ff56714bfd1fc429a67d9da862172df5072639 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
2cc76dc1583c43cb528e78275b8a4ad23b8529d2 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
b66b916f690d1e407febd47df647ec6567a249d9 
  
src/test/java/org/apache/aurora/scheduler/app/local/FakeNonVolatileStorage.java 
5cc3b4178f4d2bc63ce47adb0e33bde140618fac 
  
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java
 d56c36c66d85b274528f6321af46fbf9054c4cc8 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
d1a70661122802ecfdd8efa2ced567685c08995f 
  src/test/java/org/apache/aurora/

Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

2014-11-19 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28097/#review62320
---

Ship it!


Ship It!

- Maxim Khutornenko


On Nov. 19, 2014, 11:41 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28097/
> ---
> 
> (Updated Nov. 19, 2014, 11:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-929
> https://issues.apache.org/jira/browse/AURORA-929
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> See updated class javadoc in `Storage` for new behavior description.  
> Ultimately we're accepting the risk of reading uncommitted writes 
> (specifically in `TaskStore` and `JobStore`).  In practice this should 
> generally be exceedingly rare, as most writes are atomic to one store anyway, 
> and for those that are not (such as rescheduling a task), the window should 
> be O(µs) long.
> 
> Once `DbStorage` owns all of the stores, we have a global knob for 
> transaction isolation: 
> http://mybatis.github.io/mybatis-3/java-api.html#sqlSessions (search that 
> page for `TransactionIsolationLevel`).
> 
> Without the ReadWriteLock in play, there is no longer a need for 
> `weaklyConsistentRead`, so i've removed that.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 63ae77f4632db158109e8d562488ce4e84da0438 
>   build.gradle f4b4e0d28962b6a1d5802ab9fcd6b4d49afbf360 
>   src/main/java/org/apache/aurora/auth/SessionValidator.java 
> eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> e02921df3a217aa2678e91a8bebe6a3708dbc9c3 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java 
> d6b7fabe6642944e9fda87c5588029c5bb32c025 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> ff26c49729646ffe052cb0a993b9984ae96a89ac 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> ca54c9aa321c831abdbdb8bc1f8c06a0bff95ee2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 
> 58d074b491dab2e2e0ce8a8a57e4ebdaf0984e73 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  8cf845f3622392a65216e0c29084965c7c64075d 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java
>  4eb4437b91906ae191dd105474e84ba5f40cf52e 
>   src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 
> babbf4203af6f405d4193d6feaa749232e553ae9 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> 84e37e49fabc7ac6bfa2967787cb6abb6ce4af5d 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
> 8e2d3d92c3404f9b24b802687c2d7faeeb27d318 
>   src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
> be8a1fff2db77414dd04637af4a8183810b66845 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> 883f954e5dc99311fb701d52dd5d737a50f23276 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> 5f3cce330a9ec7eb3bdfb3512791d918d4c9 
>   src/main/java/org/apache/aurora/scheduler/http/Slaves.java 
> 0ea462f5d1abbb9eec457205e1b9acca9976027a 
>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
> 8147d545dce3082d63f693c9620e3c769258d9e4 
>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java 
> 88150e564e70bf02b62c1c7477d126e98dd91437 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e38407ec487d511fb05142cbeda955ec5a6ba4ec 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 149bb33568d67fffdee944bf676199e7108b0c0d 
>   src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
> f167290bf99b76ccc049eb51fe95ccfce940d078 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> a835eaabb047ede5833ca80f43a0cb1bee01d142 
>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
> 79d12b0dd7959b5443ffce43d9ebdb79135718bb 
>   
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
>  0d02207d7bda46bcc84d2e7328a8c500ad9a5384 
>   src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 
> 4e6d68b039bb140509b1261f25e7b49457bfd2be 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 682bca881969d24ece40ab83356f1bebb77feabd 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
> 4744dc9f202969906113ccb610bf17c94d188c43 
>   
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
>  503bdfeb2cefccfdeb151190b04ce9c

Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

2014-11-19 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28097/#review62283
---


This patch does not apply cleanly on master (4e52d00), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 19, 2014, 11:41 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28097/
> ---
> 
> (Updated Nov. 19, 2014, 11:41 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-929
> https://issues.apache.org/jira/browse/AURORA-929
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> See updated class javadoc in `Storage` for new behavior description.  
> Ultimately we're accepting the risk of reading uncommitted writes 
> (specifically in `TaskStore` and `JobStore`).  In practice this should 
> generally be exceedingly rare, as most writes are atomic to one store anyway, 
> and for those that are not (such as rescheduling a task), the window should 
> be O(µs) long.
> 
> Once `DbStorage` owns all of the stores, we have a global knob for 
> transaction isolation: 
> http://mybatis.github.io/mybatis-3/java-api.html#sqlSessions (search that 
> page for `TransactionIsolationLevel`).
> 
> Without the ReadWriteLock in play, there is no longer a need for 
> `weaklyConsistentRead`, so i've removed that.
> 
> 
> Diffs
> -
> 
>   3rdparty/python/BUILD 63ae77f4632db158109e8d562488ce4e84da0438 
>   build.gradle f4b4e0d28962b6a1d5802ab9fcd6b4d49afbf360 
>   src/main/java/org/apache/aurora/auth/SessionValidator.java 
> eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> e02921df3a217aa2678e91a8bebe6a3708dbc9c3 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java 
> d6b7fabe6642944e9fda87c5588029c5bb32c025 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> ff26c49729646ffe052cb0a993b9984ae96a89ac 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> ca54c9aa321c831abdbdb8bc1f8c06a0bff95ee2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 
> 58d074b491dab2e2e0ce8a8a57e4ebdaf0984e73 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  8cf845f3622392a65216e0c29084965c7c64075d 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java
>  4eb4437b91906ae191dd105474e84ba5f40cf52e 
>   src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 
> babbf4203af6f405d4193d6feaa749232e553ae9 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> 84e37e49fabc7ac6bfa2967787cb6abb6ce4af5d 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
> 8e2d3d92c3404f9b24b802687c2d7faeeb27d318 
>   src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
> be8a1fff2db77414dd04637af4a8183810b66845 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> 883f954e5dc99311fb701d52dd5d737a50f23276 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> 5f3cce330a9ec7eb3bdfb3512791d918d4c9 
>   src/main/java/org/apache/aurora/scheduler/http/Slaves.java 
> 0ea462f5d1abbb9eec457205e1b9acca9976027a 
>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
> 8147d545dce3082d63f693c9620e3c769258d9e4 
>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java 
> 88150e564e70bf02b62c1c7477d126e98dd91437 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e38407ec487d511fb05142cbeda955ec5a6ba4ec 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 149bb33568d67fffdee944bf676199e7108b0c0d 
>   src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
> f167290bf99b76ccc049eb51fe95ccfce940d078 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> a835eaabb047ede5833ca80f43a0cb1bee01d142 
>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
> 79d12b0dd7959b5443ffce43d9ebdb79135718bb 
>   
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
>  0d02207d7bda46bcc84d2e7328a8c500ad9a5384 
>   src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 
> 4e6d68b039bb140509b1261f25e7b49457bfd2be 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 682bca881969d24ece40ab83356f1bebb77feabd 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
> 4744dc9f2029699061

Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

2014-11-19 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28097/
---

(Updated Nov. 19, 2014, 11:41 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Changes
---

Address feedback + rebase, unfortunately this breaks inter-diff :-/


Bugs: AURORA-929
https://issues.apache.org/jira/browse/AURORA-929


Repository: aurora


Description
---

See updated class javadoc in `Storage` for new behavior description.  
Ultimately we're accepting the risk of reading uncommitted writes (specifically 
in `TaskStore` and `JobStore`).  In practice this should generally be 
exceedingly rare, as most writes are atomic to one store anyway, and for those 
that are not (such as rescheduling a task), the window should be O(µs) long.

Once `DbStorage` owns all of the stores, we have a global knob for transaction 
isolation: http://mybatis.github.io/mybatis-3/java-api.html#sqlSessions (search 
that page for `TransactionIsolationLevel`).

Without the ReadWriteLock in play, there is no longer a need for 
`weaklyConsistentRead`, so i've removed that.


Diffs (updated)
-

  3rdparty/python/BUILD 63ae77f4632db158109e8d562488ce4e84da0438 
  build.gradle f4b4e0d28962b6a1d5802ab9fcd6b4d49afbf360 
  src/main/java/org/apache/aurora/auth/SessionValidator.java 
eeebb78901a6c33e08ceb8e675c91f0b5f44bcbc 
  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
cf8f7584afee758c527798914181049051aef0d8 
  src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
e02921df3a217aa2678e91a8bebe6a3708dbc9c3 
  src/main/java/org/apache/aurora/scheduler/async/KillRetry.java 
d6b7fabe6642944e9fda87c5588029c5bb32c025 
  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
ff26c49729646ffe052cb0a993b9984ae96a89ac 
  src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
ca54c9aa321c831abdbdb8bc1f8c06a0bff95ee2 
  src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 
58d074b491dab2e2e0ce8a8a57e4ebdaf0984e73 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 8cf845f3622392a65216e0c29084965c7c64075d 
  
src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java
 4eb4437b91906ae191dd105474e84ba5f40cf52e 
  src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 
babbf4203af6f405d4193d6feaa749232e553ae9 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
84e37e49fabc7ac6bfa2967787cb6abb6ce4af5d 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
8e2d3d92c3404f9b24b802687c2d7faeeb27d318 
  src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
be8a1fff2db77414dd04637af4a8183810b66845 
  src/main/java/org/apache/aurora/scheduler/http/Mname.java 
883f954e5dc99311fb701d52dd5d737a50f23276 
  src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
5f3cce330a9ec7eb3bdfb3512791d918d4c9 
  src/main/java/org/apache/aurora/scheduler/http/Slaves.java 
0ea462f5d1abbb9eec457205e1b9acca9976027a 
  src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
8147d545dce3082d63f693c9620e3c769258d9e4 
  src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java 
88150e564e70bf02b62c1c7477d126e98dd91437 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
e38407ec487d511fb05142cbeda955ec5a6ba4ec 
  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
149bb33568d67fffdee944bf676199e7108b0c0d 
  src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
f167290bf99b76ccc049eb51fe95ccfce940d078 
  src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
a835eaabb047ede5833ca80f43a0cb1bee01d142 
  src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
79d12b0dd7959b5443ffce43d9ebdb79135718bb 
  
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
 0d02207d7bda46bcc84d2e7328a8c500ad9a5384 
  src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java 
4e6d68b039bb140509b1261f25e7b49457bfd2be 
  src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
682bca881969d24ece40ab83356f1bebb77feabd 
  src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 
4744dc9f202969906113ccb610bf17c94d188c43 
  
src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 
503bdfeb2cefccfdeb151190b04ce9ce445f47b1 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
40487e5461da8062555e4e40ccb1c146ab665c5f 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
45ea50fff10c5ff10db3f225cdbbb0204f056d31 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
73348f3ef0d7452497e14a3889f5c20da04e5455 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.ja

Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

2014-11-19 Thread Bill Farner 


> On Nov. 17, 2014, 7:20 p.m., Maxim Khutornenko wrote:
> > I don't see ReadWriteLockManager removal in this diff. It was only used in 
> > mem storage AFAICT.

Thanks, removed.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28097/#review61769
---


On Nov. 16, 2014, 10:43 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28097/
> ---
> 
> (Updated Nov. 16, 2014, 10:43 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-929
> https://issues.apache.org/jira/browse/AURORA-929
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> See updated class javadoc in `Storage` for new behavior description.  
> Ultimately we're accepting the risk of reading uncommitted writes 
> (specifically in `TaskStore` and `JobStore`).  In practice this should 
> generally be exceedingly rare, as most writes are atomic to one store anyway, 
> and for those that are not (such as rescheduling a task), the window should 
> be O(µs) long.
> 
> Once `DbStorage` owns all of the stores, we have a global knob for 
> transaction isolation: 
> http://mybatis.github.io/mybatis-3/java-api.html#sqlSessions (search that 
> page for `TransactionIsolationLevel`).
> 
> Without the ReadWriteLock in play, there is no longer a need for 
> `weaklyConsistentRead`, so i've removed that.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> e02921df3a217aa2678e91a8bebe6a3708dbc9c3 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java 
> d6b7fabe6642944e9fda87c5588029c5bb32c025 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> ff26c49729646ffe052cb0a993b9984ae96a89ac 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> ca54c9aa321c831abdbdb8bc1f8c06a0bff95ee2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 
> 58d074b491dab2e2e0ce8a8a57e4ebdaf0984e73 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> 84e37e49fabc7ac6bfa2967787cb6abb6ce4af5d 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
> 8e2d3d92c3404f9b24b802687c2d7faeeb27d318 
>   src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
> be8a1fff2db77414dd04637af4a8183810b66845 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> 883f954e5dc99311fb701d52dd5d737a50f23276 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> 5f3cce330a9ec7eb3bdfb3512791d918d4c9 
>   src/main/java/org/apache/aurora/scheduler/http/Slaves.java 
> 0ea462f5d1abbb9eec457205e1b9acca9976027a 
>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
> 8147d545dce3082d63f693c9620e3c769258d9e4 
>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java 
> 88150e564e70bf02b62c1c7477d126e98dd91437 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e38407ec487d511fb05142cbeda955ec5a6ba4ec 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 149bb33568d67fffdee944bf676199e7108b0c0d 
>   src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
> f167290bf99b76ccc049eb51fe95ccfce940d078 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> a835eaabb047ede5833ca80f43a0cb1bee01d142 
>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
> 79d12b0dd7959b5443ffce43d9ebdb79135718bb 
>   
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
>  0d02207d7bda46bcc84d2e7328a8c500ad9a5384 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 682bca881969d24ece40ab83356f1bebb77feabd 
>   
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
>  503bdfeb2cefccfdeb151190b04ce9ce445f47b1 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> 40487e5461da8062555e4e40ccb1c146ab665c5f 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 45ea50fff10c5ff10db3f225cdbbb0204f056d31 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> 73348f3ef0d7452497e14a3889f5c20da04e5455 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 66ff56714bfd1fc429a67d9da862172df5072639 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> 2cc76dc1583c43cb528e78275b8a4ad23b8529d2 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  f0b49758236

Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

2014-11-17 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28097/#review61769
---


I don't see ReadWriteLockManager removal in this diff. It was only used in mem 
storage AFAICT.


src/main/java/org/apache/aurora/scheduler/storage/Storage.java


typo


- Maxim Khutornenko


On Nov. 16, 2014, 10:43 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28097/
> ---
> 
> (Updated Nov. 16, 2014, 10:43 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-929
> https://issues.apache.org/jira/browse/AURORA-929
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> See updated class javadoc in `Storage` for new behavior description.  
> Ultimately we're accepting the risk of reading uncommitted writes 
> (specifically in `TaskStore` and `JobStore`).  In practice this should 
> generally be exceedingly rare, as most writes are atomic to one store anyway, 
> and for those that are not (such as rescheduling a task), the window should 
> be O(µs) long.
> 
> Once `DbStorage` owns all of the stores, we have a global knob for 
> transaction isolation: 
> http://mybatis.github.io/mybatis-3/java-api.html#sqlSessions (search that 
> page for `TransactionIsolationLevel`).
> 
> Without the ReadWriteLock in play, there is no longer a need for 
> `weaklyConsistentRead`, so i've removed that.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> e02921df3a217aa2678e91a8bebe6a3708dbc9c3 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java 
> d6b7fabe6642944e9fda87c5588029c5bb32c025 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> ff26c49729646ffe052cb0a993b9984ae96a89ac 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> ca54c9aa321c831abdbdb8bc1f8c06a0bff95ee2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 
> 58d074b491dab2e2e0ce8a8a57e4ebdaf0984e73 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> 84e37e49fabc7ac6bfa2967787cb6abb6ce4af5d 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
> 8e2d3d92c3404f9b24b802687c2d7faeeb27d318 
>   src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
> be8a1fff2db77414dd04637af4a8183810b66845 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> 883f954e5dc99311fb701d52dd5d737a50f23276 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> 5f3cce330a9ec7eb3bdfb3512791d918d4c9 
>   src/main/java/org/apache/aurora/scheduler/http/Slaves.java 
> 0ea462f5d1abbb9eec457205e1b9acca9976027a 
>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
> 8147d545dce3082d63f693c9620e3c769258d9e4 
>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java 
> 88150e564e70bf02b62c1c7477d126e98dd91437 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> e38407ec487d511fb05142cbeda955ec5a6ba4ec 
>   src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
> 149bb33568d67fffdee944bf676199e7108b0c0d 
>   src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
> f167290bf99b76ccc049eb51fe95ccfce940d078 
>   src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
> a835eaabb047ede5833ca80f43a0cb1bee01d142 
>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
> 79d12b0dd7959b5443ffce43d9ebdb79135718bb 
>   
> src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
>  0d02207d7bda46bcc84d2e7328a8c500ad9a5384 
>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
> 682bca881969d24ece40ab83356f1bebb77feabd 
>   
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
>  503bdfeb2cefccfdeb151190b04ce9ce445f47b1 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> 40487e5461da8062555e4e40ccb1c146ab665c5f 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 45ea50fff10c5ff10db3f225cdbbb0204f056d31 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> 73348f3ef0d7452497e14a3889f5c20da04e5455 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 66ff56714bfd1fc429a67d9da862172df5072639 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> 2cc76dc1583c43cb528e78275b8a4ad23b8529d2 
>   
> src/main/java/org/apache/aurora/sche

Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

2014-11-16 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28097/#review61692
---


Master (8741cdb) is red with this patch.
  ./build-support/jenkins/build.sh

  File "/usr/lib/python2.7/sysconfig.py", line 355, in _init_posix
raise IOError(msg)
IOError: invalid Python installation: unable to open 
/x1/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/local/include/python2.7/pyconfig.h
 (No such file or directory)

Build operating on top level addresses: 
set([BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD,
 all)])
Problem executing PythonBuilder for targets 
OrderedSet([PythonTests(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD,
 host_maintenance)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 restarter)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 instance_watcher)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_client)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/au
 th/BUILD, auth)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 transport)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_mux)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 error_handling_thread)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 task_util)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 base)), PythonLibrary
 
(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 http_signaler)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater_util)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 sla)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 common)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 aurora_job_key)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster_option)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 clusters)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/
 workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, shellify)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-packaged)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-test)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-storage)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 job_monitor)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 quota_check)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace
 /AuroraBot/src/main/python/apache/aurora/admin/BUILD, host_maintenance)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/admin/BUILD,
 util)), 
PythonTests(Bui

Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

2014-11-16 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28097/
---

(Updated Nov. 16, 2014, 10:43 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-929
https://issues.apache.org/jira/browse/AURORA-929


Repository: aurora


Description
---

See updated class javadoc in `Storage` for new behavior description.  
Ultimately we're accepting the risk of reading uncommitted writes (specifically 
in `TaskStore` and `JobStore`).  In practice this should generally be 
exceedingly rare, as most writes are atomic to one store anyway, and for those 
that are not (such as rescheduling a task), the window should be O(µs) long.

Once `DbStorage` owns all of the stores, we have a global knob for transaction 
isolation: http://mybatis.github.io/mybatis-3/java-api.html#sqlSessions (search 
that page for `TransactionIsolationLevel`).

Without the ReadWriteLock in play, there is no longer a need for 
`weaklyConsistentRead`, so i've removed that.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
cf8f7584afee758c527798914181049051aef0d8 
  src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
e02921df3a217aa2678e91a8bebe6a3708dbc9c3 
  src/main/java/org/apache/aurora/scheduler/async/KillRetry.java 
d6b7fabe6642944e9fda87c5588029c5bb32c025 
  src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
ff26c49729646ffe052cb0a993b9984ae96a89ac 
  src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
ca54c9aa321c831abdbdb8bc1f8c06a0bff95ee2 
  src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 
58d074b491dab2e2e0ce8a8a57e4ebdaf0984e73 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
84e37e49fabc7ac6bfa2967787cb6abb6ce4af5d 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
8e2d3d92c3404f9b24b802687c2d7faeeb27d318 
  src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
be8a1fff2db77414dd04637af4a8183810b66845 
  src/main/java/org/apache/aurora/scheduler/http/Mname.java 
883f954e5dc99311fb701d52dd5d737a50f23276 
  src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
5f3cce330a9ec7eb3bdfb3512791d918d4c9 
  src/main/java/org/apache/aurora/scheduler/http/Slaves.java 
0ea462f5d1abbb9eec457205e1b9acca9976027a 
  src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
8147d545dce3082d63f693c9620e3c769258d9e4 
  src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java 
88150e564e70bf02b62c1c7477d126e98dd91437 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
e38407ec487d511fb05142cbeda955ec5a6ba4ec 
  src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java 
149bb33568d67fffdee944bf676199e7108b0c0d 
  src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
f167290bf99b76ccc049eb51fe95ccfce940d078 
  src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 
a835eaabb047ede5833ca80f43a0cb1bee01d142 
  src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
79d12b0dd7959b5443ffce43d9ebdb79135718bb 
  
src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java
 0d02207d7bda46bcc84d2e7328a8c500ad9a5384 
  src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
682bca881969d24ece40ab83356f1bebb77feabd 
  
src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 
503bdfeb2cefccfdeb151190b04ce9ce445f47b1 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
40487e5461da8062555e4e40ccb1c146ab665c5f 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
45ea50fff10c5ff10db3f225cdbbb0204f056d31 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
73348f3ef0d7452497e14a3889f5c20da04e5455 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
66ff56714bfd1fc429a67d9da862172df5072639 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
2cc76dc1583c43cb528e78275b8a4ad23b8529d2 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
f0b49758236a40670931864e600cbc8375581919 
  
src/test/java/org/apache/aurora/scheduler/app/local/FakeNonVolatileStorage.java 
5cc3b4178f4d2bc63ce47adb0e33bde140618fac 
  
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java
 d56c36c66d85b274528f6321af46fbf9054c4cc8 
  
src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 
e113eba1f304279b5ee3d70db1d1ea558efd63ac 
  src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
6e499d1d82d5748ffc0d578283139f39e93316a7 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
157921cf48c56da09ad4d56e7997f444e84d34cf 
  src/test/java/org/a

Re: Review Request 28097: Remove ReadWriteLock from MemStorage, remove Storage#weaklyConsistentRead.

2014-11-15 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28097/#review61652
---


Master (8741cdb) is red with this patch.
  ./build-support/jenkins/build.sh

+ date
Sat Nov 15 18:59:54 UTC 2014
+ ./gradlew -Pq clean build
:buildSrc:clean UP-TO-DATE
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
:clean
:bootstrapThrift
:checkPython
:generateSources
:compileGeneratedJavaNote: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:processGeneratedResources UP-TO-DATE
:generatedClasses
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:jsHint
:checkstyleMain[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/Storage.java:25:8:
 Unused import - org.apache.aurora.scheduler.base.Query.
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java:618:13:
 Nested try depth is 2 (max allowed is 1).
[ant:checkstyle] 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java:30:8:
 Unused import - com.twitter.common.stats.Stats.
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: 
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 34.719 secs


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 15, 2014, 6:57 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28097/
> ---
> 
> (Updated Nov. 15, 2014, 6:57 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-929
> https://issues.apache.org/jira/browse/AURORA-929
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> See updated class javadoc in `Storage` for new behavior description.  
> Ultimately we're accepting the risk of reading uncommitted writes 
> (specifically in `TaskStore` and `JobStore`).  In practice this should 
> generally be exceedingly rare, as most writes are atomic to one store anyway, 
> and for those that are not (such as rescheduling a task), the window should 
> be O(µs) long.
> 
> Once `DbStorage` owns all of the stores, we have a global knob for 
> transaction isolation: 
> http://mybatis.github.io/mybatis-3/java-api.html#sqlSessions (search that 
> page for `TransactionIsolationLevel`).
> 
> Without the ReadWriteLock in play, there is no longer a need for 
> `weaklyConsistentRead`, so i've removed that.
> 
> 
> Diffs
> -
> 
>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
> cf8f7584afee758c527798914181049051aef0d8 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 
> e02921df3a217aa2678e91a8bebe6a3708dbc9c3 
>   src/main/java/org/apache/aurora/scheduler/async/KillRetry.java 
> d6b7fabe6642944e9fda87c5588029c5bb32c025 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> ff26c49729646ffe052cb0a993b9984ae96a89ac 
>   src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java 
> ca54c9aa321c831abdbdb8bc1f8c06a0bff95ee2 
>   src/main/java/org/apache/aurora/scheduler/async/TaskHistoryPruner.java 
> 58d074b491dab2e2e0ce8a8a57e4ebdaf0984e73 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
> 84e37e49fabc7ac6bfa2967787cb6abb6ce4af5d 
>   
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
> 8e2d3d92c3404f9b24b802687c2d7faeeb27d318 
>   src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 
> be8a1fff2db77414dd04637af4a8183810b66845 
>   src/main/java/org/apache/aurora/scheduler/http/Mname.java 
> 883f954e5dc99311fb701d52dd5d737a50f23276 
>   src/main/java/org/apache/aurora/scheduler/http/Quotas.java 
> 5f3cce330a9ec7eb3bdfb3512791d918d4c9 
>   src/main/java/org/apache/aurora/scheduler/http/Slaves.java 
> 0ea462f5d1abbb9eec457205e1b9acca9976027a 
>