Re: Review Request 28140: Drop argparse dependency; it's part of python 2.7

2014-11-18 Thread David McLaughlin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28140/#review62091
---

Ship it!


Ship It!

- David McLaughlin


On Nov. 18, 2014, 12:29 a.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28140/
 ---
 
 (Updated Nov. 18, 2014, 12:29 a.m.)
 
 
 Review request for Aurora, David McLaughlin and Kevin Sweeney.
 
 
 Bugs: AURORA-891
 https://issues.apache.org/jira/browse/AURORA-891
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Drop argparse dependency; it's part of python 2.7
 
 
 Diffs
 -
 
   3rdparty/python/BUILD 63ae77f4632db158109e8d562488ce4e84da0438 
   src/main/python/apache/aurora/client/cli/BUILD 
 995570325bbb09ecbcc2ace5d223760c5d49367f 
 
 Diff: https://reviews.apache.org/r/28140/diff/
 
 
 Testing
 ---
 
 ./pants build src/test/python:all
 bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 28140: Drop argparse dependency; it's part of python 2.7

2014-11-17 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28140/#review61840
---

Ship it!


Ship It!

- Kevin Sweeney


On Nov. 17, 2014, 4:29 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28140/
 ---
 
 (Updated Nov. 17, 2014, 4:29 p.m.)
 
 
 Review request for Aurora, David McLaughlin and Kevin Sweeney.
 
 
 Bugs: AURORA-891
 https://issues.apache.org/jira/browse/AURORA-891
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Drop argparse dependency; it's part of python 2.7
 
 
 Diffs
 -
 
   3rdparty/python/BUILD 63ae77f4632db158109e8d562488ce4e84da0438 
   src/main/python/apache/aurora/client/cli/BUILD 
 995570325bbb09ecbcc2ace5d223760c5d49367f 
 
 Diff: https://reviews.apache.org/r/28140/diff/
 
 
 Testing
 ---
 
 ./pants build src/test/python:all
 bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 28140: Drop argparse dependency; it's part of python 2.7

2014-11-17 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28140/#review61843
---


Master (c44aa5c) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Nov. 18, 2014, 12:29 a.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28140/
 ---
 
 (Updated Nov. 18, 2014, 12:29 a.m.)
 
 
 Review request for Aurora, David McLaughlin and Kevin Sweeney.
 
 
 Bugs: AURORA-891
 https://issues.apache.org/jira/browse/AURORA-891
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Drop argparse dependency; it's part of python 2.7
 
 
 Diffs
 -
 
   3rdparty/python/BUILD 63ae77f4632db158109e8d562488ce4e84da0438 
   src/main/python/apache/aurora/client/cli/BUILD 
 995570325bbb09ecbcc2ace5d223760c5d49367f 
 
 Diff: https://reviews.apache.org/r/28140/diff/
 
 
 Testing
 ---
 
 ./pants build src/test/python:all
 bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
 
 
 Thanks,
 
 Joshua Cohen