Re: Review Request 28198: Add an example on how to build with Docker.

2014-12-12 Thread Jay Buffington

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review64919
---


This is *awesome*.  Using docker to do aurora builds in and to ship an aurora 
runtime is fantastic.

My major issue with this commit is that you're unnecessarily putting build 
dependencies (aurora source, python-dev, git, etc) into a runtime container.

I suggest a slightly different approach than you've taken here: there should be 
two Dockerfiles: one for build and one for runtime.  Also, I don't think they 
should be examples, let's hook docker up to the CI process and ship a runnable 
docker image for every commit of aurora!

The build Dockerfile should produce a docker image which we can run the build 
in.  It will contain all build time dependencies (gradle, python-dev, etc).  
When a developer wants to do the build they will simply run docker run 
aurora/build This will use volume mounts to import the code into the container 
and will write out a number of jar and pex files back to the developer's 
workspace.  This is really useful because now we have a programatic way (in the 
Dockerfile) to express *all* build time dependencies.

To build a runtime container, we ship another Dockerfile which installs all the 
runtime deps (java 1.7, etc) and uses Dockerfile's ADD to copy the jar and pex 
files from the developer's workspace into the container.  We run build this 
docker container on every commit through a CI process and ship it to a docker 
registry.  Then to run, users just have to do docker run aurora/aurora

- Jay Buffington


On Dec. 11, 2014, 6:32 p.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Dec. 11, 2014, 6:32 p.m.)
 
 
 Review request for Aurora, Benjamin Staffin, Kevin Sweeney, Bill Farner, and 
 Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-12-12 Thread Tony Dong


 On Dec. 12, 2014, 4:52 p.m., Jay Buffington wrote:
  This is *awesome*.  Using docker to do aurora builds in and to ship an 
  aurora runtime is fantastic.
  
  My major issue with this commit is that you're unnecessarily putting build 
  dependencies (aurora source, python-dev, git, etc) into a runtime container.
  
  I suggest a slightly different approach than you've taken here: there 
  should be two Dockerfiles: one for build and one for runtime.  Also, I 
  don't think they should be examples, let's hook docker up to the CI process 
  and ship a runnable docker image for every commit of aurora!
  
  The build Dockerfile should produce a docker image which we can run the 
  build in.  It will contain all build time dependencies (gradle, python-dev, 
  etc).  When a developer wants to do the build they will simply run docker 
  run aurora/build This will use volume mounts to import the code into the 
  container and will write out a number of jar and pex files back to the 
  developer's workspace.  This is really useful because now we have a 
  programatic way (in the Dockerfile) to express *all* build time 
  dependencies.
  
  To build a runtime container, we ship another Dockerfile which installs all 
  the runtime deps (java 1.7, etc) and uses Dockerfile's ADD to copy the jar 
  and pex files from the developer's workspace into the container.  We run 
  build this docker container on every commit through a CI process and ship 
  it to a docker registry.  Then to run, users just have to do docker run 
  aurora/aurora

Thanks for the feedback, I agree with your concerns and I'll try to rework the 
docker builds when I get some time to do so. As we improve some of our deploy 
processes, i.e. deploying new builds of Aurora, I'll get a chance to work on 
this again.


- Tony


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review64919
---


On Dec. 11, 2014, 6:32 p.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Dec. 11, 2014, 6:32 p.m.)
 
 
 Review request for Aurora, Benjamin Staffin, Kevin Sweeney, Bill Farner, and 
 Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-12-11 Thread Tony Dong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/
---

(Updated Dec. 11, 2014, 6:32 p.m.)


Review request for Aurora, Benjamin Staffin, Kevin Sweeney, Bill Farner, and 
Zameer Manji.


Changes
---

reviewers += wfarner


Repository: aurora


Description
---

Add an example on how to build with Docker.


Diffs
-

  README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
  examples/docker/Dockerfile PRE-CREATION 

Diff: https://reviews.apache.org/r/28198/diff/


Testing
---


Thanks,

Tony Dong



Re: Review Request 28198: Add an example on how to build with Docker.

2014-12-11 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review64768
---


Sorry for the delay in responding here, thanks for opening this conversation!

One thing that stands out here is the lack of an ENTRYPOINT, which makes me 
wonder how this is intended to be used.  I think it would be great if we 
pivoted our vagrant setup to leverage this (to avoid repetition and 
continuously exercise the docker configs).  However, AFAICT that suggests we 
would need multiple Dockerfiles - aurora-scheduler, aurora-observer, 
mesos-slave, mesos-master.  Does that sound right to you?


examples/docker/Dockerfile
https://reviews.apache.org/r/28198/#comment107532

Would it make sense for us to start with an ubuntu base image?  Our vagrant 
image is currently based off ubuntu, so alignment would help prevent 
bifurcation.  The Dockerfile for marathon might provide good inspiration for 
how to arrange this, as it has several of the same requirements:

https://registry.hub.docker.com/u/mesosphere/marathon/dockerfile/

Of course, i believe we still need to jump through some extra hoops for 
python, most of which you've cracked already.



examples/docker/Dockerfile
https://reviews.apache.org/r/28198/#comment107529

d...@aurora.incubator.apache.org



examples/docker/Dockerfile
https://reviews.apache.org/r/28198/#comment107534

I think Kevin means to build with the current state of the repository the 
Dockerfile resides in.  In other words, avoid the git clone entirely, and use 
the build commands directly.


- Bill Farner


On Dec. 11, 2014, 6:32 p.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Dec. 11, 2014, 6:32 p.m.)
 
 
 Review request for Aurora, Benjamin Staffin, Kevin Sweeney, Bill Farner, and 
 Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong


 On Nov. 21, 2014, 9:12 p.m., Kevin Sweeney wrote:
  examples/docker/Dockerfile, line 30
  https://reviews.apache.org/r/28198/diff/2/?file=770028#file770028line30
 
  We should expose the mesos-master (5050), mesos-slave (5051), and 
  thermos-observer (1338) UIs too. And possibly ZooKeeper (2181)?

Done


 On Nov. 21, 2014, 9:12 p.m., Kevin Sweeney wrote:
  examples/docker/Dockerfile, line 16
  https://reviews.apache.org/r/28198/diff/2/?file=770028#file770028line16
 
  I'm ignorant here - is there a way we can reuse the existing 
  aurorabuild script here?

It wasn't really working for me. I can investigate more into it, but I mostly 
just moved straight to Docker.


- Tony


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review62640
---


On Nov. 19, 2014, 6:02 p.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Nov. 19, 2014, 6:02 p.m.)
 
 
 Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/
---

(Updated Nov. 25, 2014, 7:37 p.m.)


Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.


Repository: aurora


Description
---

Add an example on how to build with Docker.


Diffs (updated)
-

  README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
  examples/docker/Dockerfile PRE-CREATION 

Diff: https://reviews.apache.org/r/28198/diff/


Testing
---


Thanks,

Tony Dong



Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review63027
---



examples/docker/Dockerfile
https://reviews.apache.org/r/28198/#comment105212

Presumably we're not all going to use your zookeeper ensemble?


- Kevin Sweeney


On Nov. 25, 2014, 11:37 a.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Nov. 25, 2014, 11:37 a.m.)
 
 
 Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong


 On Nov. 25, 2014, 7:43 p.m., Kevin Sweeney wrote:
  examples/docker/Dockerfile, line 35
  https://reviews.apache.org/r/28198/diff/3/?file=775982#file775982line35
 
  Presumably we're not all going to use your zookeeper ensemble?

oh oops... sorry I had it in my local version and forgot to delete it from the 
version I wanted to contribute.


- Tony


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review63027
---


On Nov. 25, 2014, 7:37 p.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Nov. 25, 2014, 7:37 p.m.)
 
 
 Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/
---

(Updated Nov. 25, 2014, 7:47 p.m.)


Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.


Repository: aurora


Description
---

Add an example on how to build with Docker.


Diffs (updated)
-

  README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
  examples/docker/Dockerfile PRE-CREATION 

Diff: https://reviews.apache.org/r/28198/diff/


Testing
---


Thanks,

Tony Dong



Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review63040
---



examples/docker/Dockerfile
https://reviews.apache.org/r/28198/#comment105218

Can we avoid the extra clone here and build from the currently checked out 
repo? That way this script is likely to stay maintained in the future and might 
even make it into our development workflow.

If that's not possible then as far as I know this sha has no special 
significance, maybe replace it with a download of the 0.6.0 release?



examples/docker/Dockerfile
https://reviews.apache.org/r/28198/#comment105219

Should we also add the upstart configs from the vagrant example to the 
container? How about documentation for running - can I do something similar to 
vagrant up and get a full cluster-in-a-box?


- Kevin Sweeney


On Nov. 25, 2014, 11:47 a.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Nov. 25, 2014, 11:47 a.m.)
 
 
 Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong


 On Nov. 25, 2014, 8:49 p.m., Kevin Sweeney wrote:
  examples/docker/Dockerfile, lines 14-16
  https://reviews.apache.org/r/28198/diff/4/?file=776032#file776032line14
 
  Can we avoid the extra clone here and build from the currently checked 
  out repo? That way this script is likely to stay maintained in the future 
  and might even make it into our development workflow.
  
  If that's not possible then as far as I know this sha has no special 
  significance, maybe replace it with a download of the 0.6.0 release?

What do you mean by the currently checked out repo? do you mean head?

I just picked that sha because it's the one before my change. I was thinking of 
using 0.6.0 but there was no tag, I can use 0.6.0-rc0 branch if that works.


 On Nov. 25, 2014, 8:49 p.m., Kevin Sweeney wrote:
  examples/docker/Dockerfile, line 34
  https://reviews.apache.org/r/28198/diff/4/?file=776032#file776032line34
 
  Should we also add the upstart configs from the vagrant example to the 
  container? How about documentation for running - can I do something similar 
  to vagrant up and get a full cluster-in-a-box?

I'm still in the process of getting a cluster-in-a-box running, so far I've 
just been copying the pex and libs out into my existing machine. I haven't 
really prioritized figuring out how to run everything from the docker 
container, it's something I'll work on in the future.


- Tony


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review63040
---


On Nov. 25, 2014, 7:47 p.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Nov. 25, 2014, 7:47 p.m.)
 
 
 Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review63047
---

Ship it!


Master (e95aa8e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Nov. 25, 2014, 7:47 p.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Nov. 25, 2014, 7:47 p.m.)
 
 
 Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-24 Thread Tony Dong


 On Nov. 19, 2014, 6:32 p.m., Zameer Manji wrote:
  examples/docker/Dockerfile, line 13
  https://reviews.apache.org/r/28198/diff/2/?file=770028#file770028line13
 
  Since we are not checking out a specific version this will break once 
  aurora updates to a new version of mesos and the given mesos egg is not new 
  enough.
 
 Kevin Sweeney wrote:
 Can we copy the current worktree here instead of taking an arbitrary 
 future master?

I'll use 6d06d8639a92b8be034a0ee0b1815ea318508e35 because it's the commit my 
head was on, unless someone has another suggest commit.


- Tony


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review62185
---


On Nov. 19, 2014, 6:02 p.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Nov. 19, 2014, 6:02 p.m.)
 
 
 Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-21 Thread Jake Farrell

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review62623
---



examples/docker/Dockerfile
https://reviews.apache.org/r/28198/#comment104695

Maintainer should be dev@aurora



examples/docker/Dockerfile
https://reviews.apache.org/r/28198/#comment104696

Should reduce these RUN calls into one liners where possible to reduce 
number of layers being introduced on the image


Great idea, glad to see this being introduced

- Jake Farrell


On Nov. 19, 2014, 6:02 p.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Nov. 19, 2014, 6:02 p.m.)
 
 
 Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-21 Thread Kevin Sweeney


 On Nov. 19, 2014, 10:32 a.m., Zameer Manji wrote:
  examples/docker/Dockerfile, line 13
  https://reviews.apache.org/r/28198/diff/2/?file=770028#file770028line13
 
  Since we are not checking out a specific version this will break once 
  aurora updates to a new version of mesos and the given mesos egg is not new 
  enough.

Can we copy the current worktree here instead of taking an arbitrary future 
master?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review62185
---


On Nov. 19, 2014, 10:02 a.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Nov. 19, 2014, 10:02 a.m.)
 
 
 Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-19 Thread Tony Dong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/
---

(Updated Nov. 19, 2014, 4 p.m.)


Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.


Repository: aurora


Description
---

Add an example on how to build with Docker.


Diffs
-

  README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
  examples/docker/Dockerfile PRE-CREATION 

Diff: https://reviews.apache.org/r/28198/diff/


Testing
---


Thanks,

Tony Dong



Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-19 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review62185
---



examples/docker/Dockerfile
https://reviews.apache.org/r/28198/#comment104196

Since we are not checking out a specific version this will break once 
aurora updates to a new version of mesos and the given mesos egg is not new 
enough.


- Zameer Manji


On Nov. 19, 2014, 10:02 a.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Nov. 19, 2014, 10:02 a.m.)
 
 
 Review request for Aurora, Benjamin Staffin, Kevin Sweeney, and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Tony Dong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/
---

(Updated Nov. 19, 2014, 12:35 a.m.)


Review request for Aurora and Benjamin Staffin.


Repository: aurora


Description
---

Add an example on how to build with Docker.


Diffs
-

  README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
  examples/docker/Dockerfile PRE-CREATION 

Diff: https://reviews.apache.org/r/28198/diff/


Testing
---


Thanks,

Tony Dong



Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review62078
---


Master (c44aa5c) is red with this patch.
  ./build-support/jenkins/build.sh


Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.decorators-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.dirutil
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.dirutil-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.lang
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.lang-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.log
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.log-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.options
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.options-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.process
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.process-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.string
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.string-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.threading
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter.common.threading-0.3.1-py2.7-nspkg.pth
  Running setup.py install for twitter.common.util
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Tony Dong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review62079
---


@ReviewBot retry

- Tony Dong


On Nov. 19, 2014, 12:35 a.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Nov. 19, 2014, 12:35 a.m.)
 
 
 Review request for Aurora and Benjamin Staffin.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong
 




Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Tony Dong

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/
---

(Updated Nov. 19, 2014, 12:54 a.m.)


Review request for Aurora, Benjamin Staffin and Zameer Manji.


Repository: aurora


Description
---

Add an example on how to build with Docker.


Diffs
-

  README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
  examples/docker/Dockerfile PRE-CREATION 

Diff: https://reviews.apache.org/r/28198/diff/


Testing
---


Thanks,

Tony Dong



Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review62083
---


Master (c44aa5c) is red with this patch.
  ./build-support/jenkins/build.sh

  File /usr/lib/python2.7/sysconfig.py, line 355, in _init_posix
raise IOError(msg)
IOError: invalid Python installation: unable to open 
/x1/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/local/include/python2.7/pyconfig.h
 (No such file or directory)

Build operating on top level addresses: 
set([BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD,
 all)])
Problem executing PythonBuilder for targets 
OrderedSet([PythonTests(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/BUILD,
 host_maintenance)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 api)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 restarter)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 instance_watcher)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_client)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/au
 th/BUILD, auth)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 transport)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 scheduler_mux)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 error_handling_thread)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 task_util)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/BUILD,
 base)), PythonLibrary
 
(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 http_signaler)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater_util)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 sla)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 common)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 aurora_job_key)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 cluster_option)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD,
 clusters)), PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/
 workspace/AuroraBot/src/main/python/apache/aurora/common/BUILD, shellify)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-packaged)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-test)), 
PythonThriftLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/thrift/org/apache/aurora/gen/BUILD,
 py-thrift-storage)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 updater)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 job_monitor)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/api/BUILD,
 quota_check)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace
 /AuroraBot/src/main/python/apache/aurora/admin/BUILD, host_maintenance)), 
PythonLibrary(BuildFileAddress(/x1/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/admin/BUILD,
 util)), 

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-18 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28198/#review62098
---


Please add a committer to this so it can be committed. I suggest Kevin.

- Zameer Manji


On Nov. 18, 2014, 4:54 p.m., Tony Dong wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28198/
 ---
 
 (Updated Nov. 18, 2014, 4:54 p.m.)
 
 
 Review request for Aurora, Benjamin Staffin and Zameer Manji.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add an example on how to build with Docker.
 
 
 Diffs
 -
 
   README.md fe46b4f071e1cc8923ac52ea461b66456709eb5d 
   examples/docker/Dockerfile PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/28198/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Tony Dong