Re: Review Request 28272: Avoid creating garbage copies of Snapshot#tasks and AssignedTask#task.

2014-11-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28272/#review62607 --- Ship it! Ship It! - David McLaughlin On Nov. 21, 2014, 1:29

Re: Review Request 28272: Avoid creating garbage copies of Snapshot#tasks and AssignedTask#task.

2014-11-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28272/#review62391 --- Ship it! LGTM once more history is included in comments.

Re: Review Request 28272: Avoid creating garbage copies of Snapshot#tasks and AssignedTask#task.

2014-11-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28272/ --- (Updated Nov. 20, 2014, 5:29 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 28272: Avoid creating garbage copies of Snapshot#tasks and AssignedTask#task.

2014-11-20 Thread Kevin Sweeney
On Nov. 19, 2014, 6:01 p.m., David McLaughlin wrote: src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotDeduplicator.java, line 93 https://reviews.apache.org/r/28272/diff/1/?file=770796#file770796line93 Can you add a comment explaining why we're doing this? Done. -

Re: Review Request 28272: Avoid creating garbage copies of Snapshot#tasks and AssignedTask#task.

2014-11-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28272/#review62500 --- Master (ada97bd) is green with this patch.

Re: Review Request 28272: Avoid creating garbage copies of Snapshot#tasks and AssignedTask#task.

2014-11-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28272/#review62312 --- Master (065a3c5) is red with this patch.

Re: Review Request 28272: Avoid creating garbage copies of Snapshot#tasks and AssignedTask#task.

2014-11-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28272/#review62316 --- Master (065a3c5) is green with this patch.

Re: Review Request 28272: Avoid creating garbage copies of Snapshot#tasks and AssignedTask#task.

2014-11-19 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28272/#review62317 --- In addition to having a comment in code, can you add some info to