Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2

2014-11-21 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28302/#review62573 --- Ship it! Ship It! - Joshua Cohen On Nov. 21, 2014, 5:20 a.m.,

Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2

2014-11-21 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28302/#review62589 --- Bill, since you were the last commiter to give a shipit can you

Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2

2014-11-20 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28302/#review62453 --- Why do we have to do this in buildSrc/build.gradle and not the root

Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2

2014-11-20 Thread Zameer Manji
On Nov. 20, 2014, 3:09 p.m., Joshua Cohen wrote: Why do we have to do this in buildSrc/build.gradle and not the root build.gradle? buildSrc is special and run before the build.gradle: http://www.gradle.org/docs/current/userguide/organizing_build_logic.html#sec:build_sources - Zameer

Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2

2014-11-20 Thread Joshua Cohen
On Nov. 20, 2014, 11:09 p.m., Joshua Cohen wrote: Why do we have to do this in buildSrc/build.gradle and not the root build.gradle? Zameer Manji wrote: buildSrc is special and run before the build.gradle:

Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2

2014-11-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28302/#review62464 --- Ship it! Master (ada97bd) is green with this patch.

Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2

2014-11-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28302/#review62482 --- Ship it! Ship It! - Kevin Sweeney On Nov. 20, 2014, 3:05 p.m.,

Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2

2014-11-20 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28302/ --- (Updated Nov. 20, 2014, 9:20 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2

2014-11-20 Thread Zameer Manji
On Nov. 20, 2014, 3:09 p.m., Joshua Cohen wrote: Why do we have to do this in buildSrc/build.gradle and not the root build.gradle? Zameer Manji wrote: buildSrc is special and run before the build.gradle:

Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2

2014-11-20 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28302/#review62529 --- Ship it! Master (ada97bd) is green with this patch.