Re: Review Request 28605: Don't intercept methods on thrift that don't return Response.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28605/#review63569 --- Ship it! Ship It! - David McLaughlin On Dec. 2, 2014, 7:20 p.m., Kevin Sweeney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28605/ > --- > > (Updated Dec. 2, 2014, 7:20 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-952 > https://issues.apache.org/jira/browse/AURORA-952 > > > Repository: aurora > > > Description > --- > > Don't intercept methods on thrift that don't return Response. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java > 83b8f392b395e0c7e9472243f3e77d529b98ff34 > src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java > 801f3e0cd1f8bdbdb406b10b26359377f07bb5f1 > > Diff: https://reviews.apache.org/r/28605/diff/ > > > Testing > --- > > ./gradlew -Pq build > > > Thanks, > > Kevin Sweeney > >
Re: Review Request 28605: Don't intercept methods on thrift that don't return Response.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28605/#review63564 --- Ship it! Master (d476e2a) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 2, 2014, 7:20 p.m., Kevin Sweeney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28605/ > --- > > (Updated Dec. 2, 2014, 7:20 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-952 > https://issues.apache.org/jira/browse/AURORA-952 > > > Repository: aurora > > > Description > --- > > Don't intercept methods on thrift that don't return Response. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java > 83b8f392b395e0c7e9472243f3e77d529b98ff34 > src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java > 801f3e0cd1f8bdbdb406b10b26359377f07bb5f1 > > Diff: https://reviews.apache.org/r/28605/diff/ > > > Testing > --- > > ./gradlew -Pq build > > > Thanks, > > Kevin Sweeney > >
Re: Review Request 28605: Don't intercept methods on thrift that don't return Response.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28605/#review63563 --- Ship it! Thanks!! - Bill Farner On Dec. 2, 2014, 7:20 p.m., Kevin Sweeney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28605/ > --- > > (Updated Dec. 2, 2014, 7:20 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-952 > https://issues.apache.org/jira/browse/AURORA-952 > > > Repository: aurora > > > Description > --- > > Don't intercept methods on thrift that don't return Response. > > > Diffs > - > > src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java > 83b8f392b395e0c7e9472243f3e77d529b98ff34 > src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java > 801f3e0cd1f8bdbdb406b10b26359377f07bb5f1 > > Diff: https://reviews.apache.org/r/28605/diff/ > > > Testing > --- > > ./gradlew -Pq build > > > Thanks, > > Kevin Sweeney > >
