---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/#review64578
---
Ship it!
Ship It!
- Bill Farner
On Dec. 10, 2014, 1:22 a.m.,
On Dec. 5, 2014, 8:06 p.m., Bill Farner wrote:
Not to bikeshed, but do either of you have a sense for what it would take
to put the benchmarking code into a gradle subproject? My sense is that
would avoid further complicating the root build.gradle, but i'm not
familiar enough with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/#review64487
---
src/jmh/java/org/apache/aurora/benchmark/SchedulerBenchmark.java
On Dec. 10, 2014, 1:09 a.m., Kevin Sweeney wrote:
src/jmh/java/org/apache/aurora/benchmark/SchedulerBenchmark.java, lines
29-32
https://reviews.apache.org/r/28710/diff/4/?file=784251#file784251line29
What does the main get us here? Isn't the gradle plugin wiring this up?
Good
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/
---
(Updated Dec. 10, 2014, 1:22 a.m.)
Review request for Aurora, Kevin Sweeney
On Dec. 5, 2014, 12:06 p.m., Bill Farner wrote:
Not to bikeshed, but do either of you have a sense for what it would take
to put the benchmarking code into a gradle subproject? My sense is that
would avoid further complicating the root build.gradle, but i'm not
familiar enough with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/#review64492
---
Ship it!
Master (2aac148) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/
---
(Updated Dec. 5, 2014, 6:32 p.m.)
Review request for Aurora, Kevin Sweeney and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/#review64056
---
Ship it!
Master (40d2718) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/#review63897
---
build.gradle
https://reviews.apache.org/r/28710/#comment106210
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/#review64066
---
Not to bikeshed, but do either of you have a sense for what it
On Dec. 5, 2014, 8:06 p.m., Bill Farner wrote:
Not to bikeshed, but do either of you have a sense for what it would take
to put the benchmarking code into a gradle subproject? My sense is that
would avoid further complicating the root build.gradle, but i'm not
familiar enough with
On Dec. 5, 2014, 8:06 p.m., Bill Farner wrote:
Not to bikeshed, but do either of you have a sense for what it would take
to put the benchmarking code into a gradle subproject? My sense is that
would avoid further complicating the root build.gradle, but i'm not
familiar enough with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/
---
(Updated Dec. 6, 2014, 12:33 a.m.)
Review request for Aurora, Kevin Sweeney
On Dec. 5, 2014, 7:42 p.m., Kevin Sweeney wrote:
build.gradle, line 53
https://reviews.apache.org/r/28710/diff/1/?file=782698#file782698line53
This should be unneeded.
Dropped.
On Dec. 5, 2014, 7:42 p.m., Kevin Sweeney wrote:
build.gradle, line 103
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/#review63889
---
Ship it!
Master (11da34c) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/#review63896
---
build.gradle
https://reviews.apache.org/r/28710/#comment106209
On Dec. 4, 2014, 8:12 p.m., Kevin Sweeney wrote:
build.gradle, line 23
https://reviews.apache.org/r/28710/diff/1/?file=782698#file782698line23
Looks like you want the new-style block here instead:
https://plugins.gradle.org/plugin/me.champeau.gradle.jmh
Great
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28710/#review63900
---
Ship it!
Master (11da34c) is green with this patch.
19 matches
Mail list logo
