Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/#review64617 --- config/pmd/design.xml

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/ --- (Updated Dec. 10, 2014, 8:02 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

On Dec. 10, 2014, 8 p.m., Kevin Sweeney wrote: config/pmd/design.xml, lines 1914-1915 https://reviews.apache.org/r/28914/diff/1/?file=788485#file788485line1914 Fix description? Yup, just noticed and updated. - Maxim ---

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

On Dec. 10, 2014, 8:01 p.m., Kevin Sweeney wrote: config/pmd/design.xml, line 1909 https://reviews.apache.org/r/28914/diff/1/?file=788485#file788485line1909 Also, consider adding this to a custom.xml file. Good idea. Done. - Maxim

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/ --- (Updated Dec. 10, 2014, 8:06 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/#review64623 --- Ship it! Master (2aac148) is green with this patch.

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/#review64624 --- config/pmd/custom.xml

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/#review64631 --- Ship it! config/pmd/design.xml

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

On Dec. 10, 2014, 9:07 p.m., Bill Farner wrote: config/pmd/design.xml, line 1923 https://reviews.apache.org/r/28914/diff/2/?file=788486#file788486line1923 Should this be =1? JDK8 supports multiple annotations of the same type, so while silly it might be good to keep in mind.

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

On Dec. 10, 2014, 8:31 p.m., Kevin Sweeney wrote: config/pmd/custom.xml, line 21 https://reviews.apache.org/r/28914/diff/3/?file=788487#file788487line21 Name = Aurora? Sure. On Dec. 10, 2014, 8:31 p.m., Kevin Sweeney wrote: config/pmd/custom.xml, line 15

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/ --- (Updated Dec. 10, 2014, 10:37 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28914: Adding PMD rule to check @Timed annotation placement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28914/#review64654 --- Ship it! Master (2aac148) is green with this patch.