Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69513 --- Thanks for the patch, this is now on master. - Kevin Sweeney On J

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69512 --- Ship it! Ship It! - Kevin Sweeney On Jan. 23, 2015, 4 p.m., Stev

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69505 --- Ship it! sweet! ship it modulo minor nit below src/main/python/a

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 24, 2015, midnight) Review request for Aurora, Jay Buffington, Ke

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 23, 2015, 10:18 p.m., Brian Wickman wrote: > > src/main/python/apache/thermos/config/schema_base.py, lines 69-77 > > > > > > sort of higher-level question -- since this information is not used by > > ther

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 23, 2015, 10:18 p.m., Brian Wickman wrote: > > src/main/python/apache/thermos/config/schema_base.py, lines 69-77 > > > > > > sort of higher-level question -- since this information is not used by > > ther

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69480 --- this is looking great. just a few small nits and one higher level q

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69447 --- Ship it! Master (3fa004b) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69439 --- @ReviewBot retry - Steve Niemitz On Jan. 23, 2015, 5:23 p.m., Ste

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69420 --- Master (3fa004b) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 23, 2015, 5:23 p.m.) Review request for Aurora, Jay Buffington, K

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69404 --- Master (3fa004b) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 23, 2015, 4:25 p.m.) Review request for Aurora, Jay Buffington, K

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 22, 2015, 2:35 a.m., Kevin Sweeney wrote: > > docs/deploying-aurora-scheduler.md, line 163 > > > > > > Philosophical question: if there's already a hard requirement that the > > container have Python 2.7 wh

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 22, 2015, 10:42 p.m., Brian Wickman wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, > > lines 153-158 > > > > > > can't the stuff in DOCKER_COMMAND_PREFIX be accomplished w

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 23, 2015, 2:43 a.m., Jay Buffington wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line > > 294 > > > > > > Can you set force_pull_image to true here. I can't imagine why

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69333 --- src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.ja

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 22, 2015, 10:42 p.m., Brian Wickman wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, > > lines 153-158 > > > > > > can't the stuff in DOCKER_COMMAND_PREFIX be accomplished w

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 21, 2015, 6:35 p.m., Kevin Sweeney wrote: > > examples/vagrant/provision-dev-cluster.sh, line 17 > > > > > > nit: sh -c indirection is unnecessary here. > > Steve Niemitz wrote: > Eh, this is just copied

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 22, 2015, 10:42 p.m., Brian Wickman wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, > > lines 153-158 > > > > > > can't the stuff in DOCKER_COMMAND_PREFIX be accomplished w

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 22, 2015, 10:42 p.m., Brian Wickman wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, > > lines 153-158 > > > > > > can't the stuff in DOCKER_COMMAND_PREFIX be accomplished w

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 22, 2015, 10:42 p.m., Brian Wickman wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, > > lines 153-158 > > > > > > can't the stuff in DOCKER_COMMAND_PREFIX be accomplished w

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69288 --- src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.ja

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 22, 2015, 10:22 p.m., Brian Wickman wrote: > > src/main/python/apache/thermos/core/runner.py, lines 627-632 > > > > > > this is an abstraction leak. grep the thermos codebase for 'aurora' > > and 'mesos'.

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 22, 2015, 10:22 p.m., Brian Wickman wrote: > > src/main/python/apache/thermos/core/runner.py, lines 627-632 > > > > > > this is an abstraction leak. grep the thermos codebase for 'aurora' > > and 'mesos'.

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69282 --- src/main/python/apache/thermos/core/runner.py

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 22, 2015, 2:35 a.m., Kevin Sweeney wrote: > > docs/deploying-aurora-scheduler.md, line 163 > > > > > > Philosophical question: if there's already a hard requirement that the > > container have Python 2.7 wh

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 22, 2015, 2:35 a.m., Kevin Sweeney wrote: > > docs/deploying-aurora-scheduler.md, line 163 > > > > > > Philosophical question: if there's already a hard requirement that the > > container have Python 2.7 wh

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68845 --- Sorry for the delay in reply. I've been thinking a lot about this pa

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68377 --- Ship it! Master (b75ed0f) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 15, 2015, 9:20 p.m., Bill Farner wrote: > > docs/configuration-reference.md, line 285 > > > > > > Doc deserves update after thrift refactor. While the thrift schema has changed, the configuration schema has

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68371 --- Ship it! src/main/java/org/apache/aurora/scheduler/configuration/C

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 16, 2015, 12:08 a.m.) Review request for Aurora, Jay Buffington,

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68350 --- Master (1acb428) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68315 --- Mostly doc updates after thrift changes, plus one nice opportunity t

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 15, 2015, 8:24 p.m.) Review request for Aurora, Jay Buffington, K

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68301 --- Ship it! Master (a350982) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68274 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68267 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68260 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68247 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68245 --- Ship it! Master (a350982) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68241 --- Ship it! Master (a350982) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68239 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68237 --- Ship it! Master (a350982) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68232 --- Ship it! Master (a350982) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68223 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68219 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68213 --- Ship it! Master (a350982) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68210 --- Ship it! Master (a350982) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68203 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68200 --- Ship it! Master (a350982) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68196 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68185 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68178 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68173 --- Ship it! Master (a350982) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68155 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68132 --- Ship it! Master (a350982) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68125 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 14, 2015, 7:55 p.m., Bill Farner wrote: > > All nits this round. Last issue for me, as you point out, is > > validation/restriction of `ContainerType` in `ConfigurationManager. > > > > Doing a pass on test coverage in the meantime. > > Bill Farner wrote: > Test coverage LGTM whe

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 14, 2015, 7:55 p.m., Bill Farner wrote: > > All nits this round. Last issue for me, as you point out, is > > validation/restriction of `ContainerType` in `ConfigurationManager. > > > > Doing a pass on test coverage in the meantime. > > Bill Farner wrote: > Test coverage LGTM whe

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 14, 2015, 7:55 p.m., Bill Farner wrote: > > All nits this round. Last issue for me, as you point out, is > > validation/restriction of `ContainerType` in `ConfigurationManager. > > > > Doing a pass on test coverage in the meantime. > > Bill Farner wrote: > Test coverage LGTM whe

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 14, 2015, 8:20 p.m.) Review request for Aurora, Jay Buffington, K

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 14, 2015, 7:55 p.m., Bill Farner wrote: > > All nits this round. Last issue for me, as you point out, is > > validation/restriction of `ContainerType` in `ConfigurationManager. > > > > Doing a pass on test coverage in the meantime. > > Bill Farner wrote: > Test coverage LGTM whe

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68112 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 14, 2015, 7:55 p.m., Bill Farner wrote: > > All nits this round. Last issue for me, as you point out, is > > validation/restriction of `ContainerType` in `ConfigurationManager. > > > > Doing a pass on test coverage in the meantime. Test coverage LGTM when supplemented with https://r

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68098 --- All nits this round. Last issue for me, as you point out, is valid

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 14, 2015, 1:03 a.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java, > > line 348 > > > > > > I would love to see another check for whether the sche

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 14, 2015, 7:15 p.m., Aurora ReviewBot wrote: > > Master (a350982) is red with this patch. > > ./build-support/jenkins/build.sh > > > > File > > "/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_builder

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68076 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 14, 2015, 7:14 p.m.) Review request for Aurora, Jay Buffington, K

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68062 --- Third time's the charm? I feel like I'm trying to shift without usi

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68060 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68056 --- @ReviewBot retry - Steve Niemitz On Jan. 14, 2015, 4:50 p.m., Ste

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68055 --- Master (a350982) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 14, 2015, 4:50 p.m.) Review request for Aurora, Jay Buffington, K

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 14, 2015, 2:28 a.m., Kevin Sweeney wrote: > > Partial review, looks good but some questions on the scheduler side of the > > code. You didn't comment on it here, but looping back to the IRC conversation, yes the Volumes option essentially gives users root (since they could map any ho

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 14, 2015, 1:03 a.m., Bill Farner wrote: > > Mostly style and configuration ergonomics remaining. Once these are > > addressed my final pass before giving a ship will be assessing for complete > > test coverage. Remaining issues after my patch: - New name for "allow_docker_mounts" sw

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 14, 2015, 2:28 a.m., Kevin Sweeney wrote: > > examples/jobs/docker/hello_docker.aurora, line 5 > > > > > > since we're supposedly running in the python2.7 container could we show > > our version? Bonus points

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 14, 2015, 1:03 a.m., Bill Farner wrote: > > examples/vagrant/upstart/mesos-slave.conf, line 32 > > > > > > Is this afflicted by MESOS-2215? I'm worried (read: certain) people > > will copy/paste the example

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68013 --- Partial review, looks good but some questions on the scheduler side

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review67985 --- Mostly style and configuration ergonomics remaining. Once these are

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review67781 --- Ship it! Master (c8154b2) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 13, 2015, 1:11 a.m.) Review request for Aurora, Jay Buffington, K

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review67766 --- Ship it! Master (5ce076b) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review67761 --- @ReviewBot retry - Steve Niemitz On Jan. 12, 2015, 9:40 p.m., Ste

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote: > > docs/deploying-aurora-scheduler.md, line 155 > > > > > > From reading the code, it appears this additional path is needed for > > them both to be available in the c

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote: > > docs/deploying-aurora-scheduler.md, line 155 > > > > > > From reading the code, it appears this additional path is needed for > > them both to be available in the c

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review67722 --- Master (5ce076b) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 12, 2015, 9:40 p.m.) Review request for Aurora, Jay Buffington, K

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review67702 --- Master (5ce076b) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 12, 2015, 8:32 p.m.) Review request for Aurora, Jay Buffington, K

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review67682 --- Master (a9e0d34) is red with this patch. ./build-support/jenkins/b

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 12, 2015, 7:01 p.m.) Review request for Aurora, Jay Buffington, K

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote: > > docs/deploying-aurora-scheduler.md, line 155 > > > > > > From reading the code, it appears this additional path is needed for > > them both to be available in the c

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote: > > docs/deploying-aurora-scheduler.md, line 155 > > > > > > From reading the code, it appears this additional path is needed for > > them both to be available in the c

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review67498 --- Ship it! Master (74e5471) is green with this patch. ./build-suppo

Re: Review Request 28920: Add support for docker containers to aurora

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 9, 2015, 7:34 p.m.) Review request for Aurora, Jay Buffington, Ke

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote: > > docs/deploying-aurora-scheduler.md, line 155 > > > > > > From reading the code, it appears this additional path is needed for > > them both to be available in the c

Re: Review Request 28920: Add support for docker containers to aurora

> On Jan. 8, 2015, 10:48 a.m., Bill Farner wrote: > > docs/deploying-aurora-scheduler.md, line 155 > > > > > > From reading the code, it appears this additional path is needed for > > them both to be available in the

  1   2   >