Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2015-01-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29137/#review67069 --- Ship it! Ship It! - Bill Farner On Jan. 6, 2015, 11:30 p.m.,

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2015-01-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29137/#review66952 --- Ship it! Master (8c49029) is green with this patch.

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29137/#review65325 --- Is this needed given that the scheduler has been dual writing since

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Maxim Khutornenko
On Dec. 17, 2014, 3:34 p.m., Bill Farner wrote: Is this needed given that the scheduler has been dual writing since 0.5.0? I have explained in the ticket. We do need this change in order to avoid breaking pre-0.7.0 clients working against the 0.7.0 scheduler. - Maxim

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29137/ --- (Updated Dec. 17, 2014, 6:24 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29137/#review65341 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Maxim Khutornenko
On Dec. 17, 2014, 6:57 p.m., Zameer Manji wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 174 https://reviews.apache.org/r/29137/diff/2/?file=794247#file794247line174 Why do we need a deep copy here? The [task] * config.instances() creates a shallow array. Without a

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Zameer Manji
On Dec. 17, 2014, 10:57 a.m., Zameer Manji wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 174 https://reviews.apache.org/r/29137/diff/2/?file=794247#file794247line174 Why do we need a deep copy here? Maxim Khutornenko wrote: The [task] * config.instances()

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Maxim Khutornenko
On Dec. 17, 2014, 6:57 p.m., Zameer Manji wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 174 https://reviews.apache.org/r/29137/diff/2/?file=794247#file794247line174 Why do we need a deep copy here? Maxim Khutornenko wrote: The [task] * config.instances()

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29137/ --- (Updated Dec. 17, 2014, 7:26 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29137/#review65353 --- Ship it! Ship It! - Zameer Manji On Dec. 17, 2014, 11:26 a.m.,

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29137/#review65355 --- Ship it! Master (ab18bd0) is green with this patch.

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29137/#review65283 --- This patch does not apply cleanly on master (ab18bd0), do you need