Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2015-01-07 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review67069
---

Ship it!


Ship It!

- Bill Farner


On Jan. 6, 2015, 11:30 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29137/
 ---
 
 (Updated Jan. 6, 2015, 11:30 p.m.)
 
 
 Review request for Aurora, Bill Farner and Zameer Manji.
 
 
 Bugs: AURORA-691
 https://issues.apache.org/jira/browse/AURORA-691
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Dual reading populated configs to make sure we are backwards compatible by 
 0.8.0.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/api/updater.py 
 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
   src/main/python/apache/aurora/client/base.py 
 258c1fa87645ec48854198529392c84ae08c93be 
   src/main/python/apache/aurora/client/cli/jobs.py 
 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
   src/main/python/apache/aurora/client/commands/core.py 
 cbaa67a78533fedf679eb993c9deb0f09b705616 
   src/test/python/apache/aurora/client/api/test_updater.py 
 dad69e20598c1daf62706989dafcb4be50fed82b 
   src/test/python/apache/aurora/client/cli/test_diff.py 
 d8da68fef7603e0da5f53c059367541d971bda50 
   src/test/python/apache/aurora/client/cli/test_restart.py 
 c19b21dd99dded0fdc631cef90997e2f2bd1156e 
   src/test/python/apache/aurora/client/cli/test_update.py 
 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
   src/test/python/apache/aurora/client/commands/test_diff.py 
 8e346ed3e6b8c91a7882029cd0734bd55165c479 
   src/test/python/apache/aurora/client/commands/test_restart.py 
 3789f3bd9ea2753070c966e0b755ab2168f7dd05 
   src/test/python/apache/aurora/client/commands/test_update.py 
 3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
   src/test/python/apache/aurora/client/test_base.py 
 fba08aeb8103aaa62fb86c389a1976f89289a086 
 
 Diff: https://reviews.apache.org/r/29137/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client:all
 Verified in vagrant. 
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2015-01-06 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review66952
---

Ship it!


Master (8c49029) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Jan. 6, 2015, 11:30 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29137/
 ---
 
 (Updated Jan. 6, 2015, 11:30 p.m.)
 
 
 Review request for Aurora, Bill Farner and Zameer Manji.
 
 
 Bugs: AURORA-691
 https://issues.apache.org/jira/browse/AURORA-691
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Dual reading populated configs to make sure we are backwards compatible by 
 0.8.0.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/api/updater.py 
 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
   src/main/python/apache/aurora/client/base.py 
 258c1fa87645ec48854198529392c84ae08c93be 
   src/main/python/apache/aurora/client/cli/jobs.py 
 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
   src/main/python/apache/aurora/client/commands/core.py 
 cbaa67a78533fedf679eb993c9deb0f09b705616 
   src/test/python/apache/aurora/client/api/test_updater.py 
 dad69e20598c1daf62706989dafcb4be50fed82b 
   src/test/python/apache/aurora/client/cli/test_diff.py 
 d8da68fef7603e0da5f53c059367541d971bda50 
   src/test/python/apache/aurora/client/cli/test_restart.py 
 c19b21dd99dded0fdc631cef90997e2f2bd1156e 
   src/test/python/apache/aurora/client/cli/test_update.py 
 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
   src/test/python/apache/aurora/client/commands/test_diff.py 
 8e346ed3e6b8c91a7882029cd0734bd55165c479 
   src/test/python/apache/aurora/client/commands/test_restart.py 
 3789f3bd9ea2753070c966e0b755ab2168f7dd05 
   src/test/python/apache/aurora/client/commands/test_update.py 
 3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
   src/test/python/apache/aurora/client/test_base.py 
 fba08aeb8103aaa62fb86c389a1976f89289a086 
 
 Diff: https://reviews.apache.org/r/29137/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client:all
 Verified in vagrant. 
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review65325
---


Is this needed given that the scheduler has been dual writing since 0.5.0?

- Bill Farner


On Dec. 17, 2014, 3:19 a.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29137/
 ---
 
 (Updated Dec. 17, 2014, 3:19 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Zameer Manji.
 
 
 Bugs: AURORA-691
 https://issues.apache.org/jira/browse/AURORA-691
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Dual reading populated configs to make sure we are backwards compatible by 
 0.8.0.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/api/updater.py 
 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
   src/main/python/apache/aurora/client/base.py 
 a897e879dfda7340d7561247d3fa7cda2dbb5bc6 
   src/main/python/apache/aurora/client/cli/jobs.py 
 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
   src/main/python/apache/aurora/client/commands/core.py 
 8d9286249f176c2974d9d097597b93ce9d9a8660 
   src/test/python/apache/aurora/client/api/test_updater.py 
 dad69e20598c1daf62706989dafcb4be50fed82b 
   src/test/python/apache/aurora/client/cli/test_diff.py 
 95c7c92942c7cbde344a093789b3e04b63200cc5 
   src/test/python/apache/aurora/client/cli/test_restart.py 
 c19b21dd99dded0fdc631cef90997e2f2bd1156e 
   src/test/python/apache/aurora/client/cli/test_update.py 
 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
   src/test/python/apache/aurora/client/commands/test_diff.py 
 b48b53d3282d25c74a8424efe15ad19493acb3a5 
   src/test/python/apache/aurora/client/commands/test_restart.py 
 3789f3bd9ea2753070c966e0b755ab2168f7dd05 
   src/test/python/apache/aurora/client/commands/test_update.py 
 3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
   src/test/python/apache/aurora/client/test_base.py 
 fba08aeb8103aaa62fb86c389a1976f89289a086 
 
 Diff: https://reviews.apache.org/r/29137/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client:all
 Verified in vagrant. 
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Maxim Khutornenko


 On Dec. 17, 2014, 3:34 p.m., Bill Farner wrote:
  Is this needed given that the scheduler has been dual writing since 0.5.0?

I have explained in the ticket. We do need this change in order to avoid 
breaking pre-0.7.0 clients working against the 0.7.0 scheduler.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review65325
---


On Dec. 17, 2014, 3:19 a.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29137/
 ---
 
 (Updated Dec. 17, 2014, 3:19 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Zameer Manji.
 
 
 Bugs: AURORA-691
 https://issues.apache.org/jira/browse/AURORA-691
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Dual reading populated configs to make sure we are backwards compatible by 
 0.8.0.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/api/updater.py 
 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
   src/main/python/apache/aurora/client/base.py 
 a897e879dfda7340d7561247d3fa7cda2dbb5bc6 
   src/main/python/apache/aurora/client/cli/jobs.py 
 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
   src/main/python/apache/aurora/client/commands/core.py 
 8d9286249f176c2974d9d097597b93ce9d9a8660 
   src/test/python/apache/aurora/client/api/test_updater.py 
 dad69e20598c1daf62706989dafcb4be50fed82b 
   src/test/python/apache/aurora/client/cli/test_diff.py 
 95c7c92942c7cbde344a093789b3e04b63200cc5 
   src/test/python/apache/aurora/client/cli/test_restart.py 
 c19b21dd99dded0fdc631cef90997e2f2bd1156e 
   src/test/python/apache/aurora/client/cli/test_update.py 
 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
   src/test/python/apache/aurora/client/commands/test_diff.py 
 b48b53d3282d25c74a8424efe15ad19493acb3a5 
   src/test/python/apache/aurora/client/commands/test_restart.py 
 3789f3bd9ea2753070c966e0b755ab2168f7dd05 
   src/test/python/apache/aurora/client/commands/test_update.py 
 3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
   src/test/python/apache/aurora/client/test_base.py 
 fba08aeb8103aaa62fb86c389a1976f89289a086 
 
 Diff: https://reviews.apache.org/r/29137/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client:all
 Verified in vagrant. 
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/
---

(Updated Dec. 17, 2014, 6:24 p.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Changes
---

rebased


Bugs: AURORA-691
https://issues.apache.org/jira/browse/AURORA-691


Repository: aurora


Description
---

Dual reading populated configs to make sure we are backwards compatible by 
0.8.0.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/updater.py 
1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
  src/main/python/apache/aurora/client/base.py 
a897e879dfda7340d7561247d3fa7cda2dbb5bc6 
  src/main/python/apache/aurora/client/cli/jobs.py 
8bdb7f488f68b10b767ced627e55e57698e4f5f2 
  src/main/python/apache/aurora/client/commands/core.py 
7b970e8872c73a30947ce8f407c37da3d06f20df 
  src/test/python/apache/aurora/client/api/test_updater.py 
dad69e20598c1daf62706989dafcb4be50fed82b 
  src/test/python/apache/aurora/client/cli/test_diff.py 
95c7c92942c7cbde344a093789b3e04b63200cc5 
  src/test/python/apache/aurora/client/cli/test_restart.py 
c19b21dd99dded0fdc631cef90997e2f2bd1156e 
  src/test/python/apache/aurora/client/cli/test_update.py 
044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
  src/test/python/apache/aurora/client/commands/test_diff.py 
b48b53d3282d25c74a8424efe15ad19493acb3a5 
  src/test/python/apache/aurora/client/commands/test_restart.py 
3789f3bd9ea2753070c966e0b755ab2168f7dd05 
  src/test/python/apache/aurora/client/commands/test_update.py 
3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
  src/test/python/apache/aurora/client/test_base.py 
fba08aeb8103aaa62fb86c389a1976f89289a086 

Diff: https://reviews.apache.org/r/29137/diff/


Testing
---

./pants src/test/python/apache/aurora/client:all
Verified in vagrant. 


Thanks,

Maxim Khutornenko



Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review65341
---



src/main/python/apache/aurora/client/cli/jobs.py
https://reviews.apache.org/r/29137/#comment108458

Why do we need a deep copy here?


- Zameer Manji


On Dec. 17, 2014, 10:24 a.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29137/
 ---
 
 (Updated Dec. 17, 2014, 10:24 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Zameer Manji.
 
 
 Bugs: AURORA-691
 https://issues.apache.org/jira/browse/AURORA-691
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Dual reading populated configs to make sure we are backwards compatible by 
 0.8.0.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/api/updater.py 
 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
   src/main/python/apache/aurora/client/base.py 
 a897e879dfda7340d7561247d3fa7cda2dbb5bc6 
   src/main/python/apache/aurora/client/cli/jobs.py 
 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
   src/main/python/apache/aurora/client/commands/core.py 
 7b970e8872c73a30947ce8f407c37da3d06f20df 
   src/test/python/apache/aurora/client/api/test_updater.py 
 dad69e20598c1daf62706989dafcb4be50fed82b 
   src/test/python/apache/aurora/client/cli/test_diff.py 
 95c7c92942c7cbde344a093789b3e04b63200cc5 
   src/test/python/apache/aurora/client/cli/test_restart.py 
 c19b21dd99dded0fdc631cef90997e2f2bd1156e 
   src/test/python/apache/aurora/client/cli/test_update.py 
 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
   src/test/python/apache/aurora/client/commands/test_diff.py 
 b48b53d3282d25c74a8424efe15ad19493acb3a5 
   src/test/python/apache/aurora/client/commands/test_restart.py 
 3789f3bd9ea2753070c966e0b755ab2168f7dd05 
   src/test/python/apache/aurora/client/commands/test_update.py 
 3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
   src/test/python/apache/aurora/client/test_base.py 
 fba08aeb8103aaa62fb86c389a1976f89289a086 
 
 Diff: https://reviews.apache.org/r/29137/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client:all
 Verified in vagrant. 
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Maxim Khutornenko


 On Dec. 17, 2014, 6:57 p.m., Zameer Manji wrote:
  src/main/python/apache/aurora/client/cli/jobs.py, line 174
  https://reviews.apache.org/r/29137/diff/2/?file=794247#file794247line174
 
  Why do we need a deep copy here?

The [task] * config.instances() creates a shallow array. Without a deep copy, 
any subsequent elements will attempt to modify an already modified element 
failing the json.loads() call.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review65341
---


On Dec. 17, 2014, 6:24 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29137/
 ---
 
 (Updated Dec. 17, 2014, 6:24 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Zameer Manji.
 
 
 Bugs: AURORA-691
 https://issues.apache.org/jira/browse/AURORA-691
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Dual reading populated configs to make sure we are backwards compatible by 
 0.8.0.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/api/updater.py 
 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
   src/main/python/apache/aurora/client/base.py 
 a897e879dfda7340d7561247d3fa7cda2dbb5bc6 
   src/main/python/apache/aurora/client/cli/jobs.py 
 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
   src/main/python/apache/aurora/client/commands/core.py 
 7b970e8872c73a30947ce8f407c37da3d06f20df 
   src/test/python/apache/aurora/client/api/test_updater.py 
 dad69e20598c1daf62706989dafcb4be50fed82b 
   src/test/python/apache/aurora/client/cli/test_diff.py 
 95c7c92942c7cbde344a093789b3e04b63200cc5 
   src/test/python/apache/aurora/client/cli/test_restart.py 
 c19b21dd99dded0fdc631cef90997e2f2bd1156e 
   src/test/python/apache/aurora/client/cli/test_update.py 
 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
   src/test/python/apache/aurora/client/commands/test_diff.py 
 b48b53d3282d25c74a8424efe15ad19493acb3a5 
   src/test/python/apache/aurora/client/commands/test_restart.py 
 3789f3bd9ea2753070c966e0b755ab2168f7dd05 
   src/test/python/apache/aurora/client/commands/test_update.py 
 3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
   src/test/python/apache/aurora/client/test_base.py 
 fba08aeb8103aaa62fb86c389a1976f89289a086 
 
 Diff: https://reviews.apache.org/r/29137/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client:all
 Verified in vagrant. 
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Zameer Manji


 On Dec. 17, 2014, 10:57 a.m., Zameer Manji wrote:
  src/main/python/apache/aurora/client/cli/jobs.py, line 174
  https://reviews.apache.org/r/29137/diff/2/?file=794247#file794247line174
 
  Why do we need a deep copy here?
 
 Maxim Khutornenko wrote:
 The [task] * config.instances() creates a shallow array. Without a deep 
 copy, any subsequent elements will attempt to modify an already modified 
 element failing the json.loads() call.

Would you mind putting comments describing this? I feel the use of deepcopy is 
abnormal and failing to understand why it is there will lead to subtle and 
difficult to diagnose bugs.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review65341
---


On Dec. 17, 2014, 10:24 a.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29137/
 ---
 
 (Updated Dec. 17, 2014, 10:24 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Zameer Manji.
 
 
 Bugs: AURORA-691
 https://issues.apache.org/jira/browse/AURORA-691
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Dual reading populated configs to make sure we are backwards compatible by 
 0.8.0.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/api/updater.py 
 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
   src/main/python/apache/aurora/client/base.py 
 a897e879dfda7340d7561247d3fa7cda2dbb5bc6 
   src/main/python/apache/aurora/client/cli/jobs.py 
 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
   src/main/python/apache/aurora/client/commands/core.py 
 7b970e8872c73a30947ce8f407c37da3d06f20df 
   src/test/python/apache/aurora/client/api/test_updater.py 
 dad69e20598c1daf62706989dafcb4be50fed82b 
   src/test/python/apache/aurora/client/cli/test_diff.py 
 95c7c92942c7cbde344a093789b3e04b63200cc5 
   src/test/python/apache/aurora/client/cli/test_restart.py 
 c19b21dd99dded0fdc631cef90997e2f2bd1156e 
   src/test/python/apache/aurora/client/cli/test_update.py 
 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
   src/test/python/apache/aurora/client/commands/test_diff.py 
 b48b53d3282d25c74a8424efe15ad19493acb3a5 
   src/test/python/apache/aurora/client/commands/test_restart.py 
 3789f3bd9ea2753070c966e0b755ab2168f7dd05 
   src/test/python/apache/aurora/client/commands/test_update.py 
 3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
   src/test/python/apache/aurora/client/test_base.py 
 fba08aeb8103aaa62fb86c389a1976f89289a086 
 
 Diff: https://reviews.apache.org/r/29137/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client:all
 Verified in vagrant. 
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Maxim Khutornenko


 On Dec. 17, 2014, 6:57 p.m., Zameer Manji wrote:
  src/main/python/apache/aurora/client/cli/jobs.py, line 174
  https://reviews.apache.org/r/29137/diff/2/?file=794247#file794247line174
 
  Why do we need a deep copy here?
 
 Maxim Khutornenko wrote:
 The [task] * config.instances() creates a shallow array. Without a deep 
 copy, any subsequent elements will attempt to modify an already modified 
 element failing the json.loads() call.
 
 Zameer Manji wrote:
 Would you mind putting comments describing this? I feel the use of 
 deepcopy is abnormal and failing to understand why it is there will lead to 
 subtle and difficult to diagnose bugs.

Moved it down to avoid confusion.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review65341
---


On Dec. 17, 2014, 6:24 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29137/
 ---
 
 (Updated Dec. 17, 2014, 6:24 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Zameer Manji.
 
 
 Bugs: AURORA-691
 https://issues.apache.org/jira/browse/AURORA-691
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Dual reading populated configs to make sure we are backwards compatible by 
 0.8.0.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/api/updater.py 
 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
   src/main/python/apache/aurora/client/base.py 
 a897e879dfda7340d7561247d3fa7cda2dbb5bc6 
   src/main/python/apache/aurora/client/cli/jobs.py 
 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
   src/main/python/apache/aurora/client/commands/core.py 
 7b970e8872c73a30947ce8f407c37da3d06f20df 
   src/test/python/apache/aurora/client/api/test_updater.py 
 dad69e20598c1daf62706989dafcb4be50fed82b 
   src/test/python/apache/aurora/client/cli/test_diff.py 
 95c7c92942c7cbde344a093789b3e04b63200cc5 
   src/test/python/apache/aurora/client/cli/test_restart.py 
 c19b21dd99dded0fdc631cef90997e2f2bd1156e 
   src/test/python/apache/aurora/client/cli/test_update.py 
 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
   src/test/python/apache/aurora/client/commands/test_diff.py 
 b48b53d3282d25c74a8424efe15ad19493acb3a5 
   src/test/python/apache/aurora/client/commands/test_restart.py 
 3789f3bd9ea2753070c966e0b755ab2168f7dd05 
   src/test/python/apache/aurora/client/commands/test_update.py 
 3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
   src/test/python/apache/aurora/client/test_base.py 
 fba08aeb8103aaa62fb86c389a1976f89289a086 
 
 Diff: https://reviews.apache.org/r/29137/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client:all
 Verified in vagrant. 
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/
---

(Updated Dec. 17, 2014, 7:26 p.m.)


Review request for Aurora, Kevin Sweeney and Zameer Manji.


Changes
---

CR comments.


Bugs: AURORA-691
https://issues.apache.org/jira/browse/AURORA-691


Repository: aurora


Description
---

Dual reading populated configs to make sure we are backwards compatible by 
0.8.0.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/updater.py 
1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
  src/main/python/apache/aurora/client/base.py 
a897e879dfda7340d7561247d3fa7cda2dbb5bc6 
  src/main/python/apache/aurora/client/cli/jobs.py 
8bdb7f488f68b10b767ced627e55e57698e4f5f2 
  src/main/python/apache/aurora/client/commands/core.py 
7b970e8872c73a30947ce8f407c37da3d06f20df 
  src/test/python/apache/aurora/client/api/test_updater.py 
dad69e20598c1daf62706989dafcb4be50fed82b 
  src/test/python/apache/aurora/client/cli/test_diff.py 
95c7c92942c7cbde344a093789b3e04b63200cc5 
  src/test/python/apache/aurora/client/cli/test_restart.py 
c19b21dd99dded0fdc631cef90997e2f2bd1156e 
  src/test/python/apache/aurora/client/cli/test_update.py 
044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
  src/test/python/apache/aurora/client/commands/test_diff.py 
b48b53d3282d25c74a8424efe15ad19493acb3a5 
  src/test/python/apache/aurora/client/commands/test_restart.py 
3789f3bd9ea2753070c966e0b755ab2168f7dd05 
  src/test/python/apache/aurora/client/commands/test_update.py 
3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
  src/test/python/apache/aurora/client/test_base.py 
fba08aeb8103aaa62fb86c389a1976f89289a086 

Diff: https://reviews.apache.org/r/29137/diff/


Testing
---

./pants src/test/python/apache/aurora/client:all
Verified in vagrant. 


Thanks,

Maxim Khutornenko



Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review65353
---

Ship it!


Ship It!

- Zameer Manji


On Dec. 17, 2014, 11:26 a.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29137/
 ---
 
 (Updated Dec. 17, 2014, 11:26 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Zameer Manji.
 
 
 Bugs: AURORA-691
 https://issues.apache.org/jira/browse/AURORA-691
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Dual reading populated configs to make sure we are backwards compatible by 
 0.8.0.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/api/updater.py 
 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
   src/main/python/apache/aurora/client/base.py 
 a897e879dfda7340d7561247d3fa7cda2dbb5bc6 
   src/main/python/apache/aurora/client/cli/jobs.py 
 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
   src/main/python/apache/aurora/client/commands/core.py 
 7b970e8872c73a30947ce8f407c37da3d06f20df 
   src/test/python/apache/aurora/client/api/test_updater.py 
 dad69e20598c1daf62706989dafcb4be50fed82b 
   src/test/python/apache/aurora/client/cli/test_diff.py 
 95c7c92942c7cbde344a093789b3e04b63200cc5 
   src/test/python/apache/aurora/client/cli/test_restart.py 
 c19b21dd99dded0fdc631cef90997e2f2bd1156e 
   src/test/python/apache/aurora/client/cli/test_update.py 
 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
   src/test/python/apache/aurora/client/commands/test_diff.py 
 b48b53d3282d25c74a8424efe15ad19493acb3a5 
   src/test/python/apache/aurora/client/commands/test_restart.py 
 3789f3bd9ea2753070c966e0b755ab2168f7dd05 
   src/test/python/apache/aurora/client/commands/test_update.py 
 3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
   src/test/python/apache/aurora/client/test_base.py 
 fba08aeb8103aaa62fb86c389a1976f89289a086 
 
 Diff: https://reviews.apache.org/r/29137/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client:all
 Verified in vagrant. 
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-17 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review65355
---

Ship it!


Master (ab18bd0) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 17, 2014, 7:26 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29137/
 ---
 
 (Updated Dec. 17, 2014, 7:26 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Zameer Manji.
 
 
 Bugs: AURORA-691
 https://issues.apache.org/jira/browse/AURORA-691
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Dual reading populated configs to make sure we are backwards compatible by 
 0.8.0.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/api/updater.py 
 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
   src/main/python/apache/aurora/client/base.py 
 a897e879dfda7340d7561247d3fa7cda2dbb5bc6 
   src/main/python/apache/aurora/client/cli/jobs.py 
 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
   src/main/python/apache/aurora/client/commands/core.py 
 7b970e8872c73a30947ce8f407c37da3d06f20df 
   src/test/python/apache/aurora/client/api/test_updater.py 
 dad69e20598c1daf62706989dafcb4be50fed82b 
   src/test/python/apache/aurora/client/cli/test_diff.py 
 95c7c92942c7cbde344a093789b3e04b63200cc5 
   src/test/python/apache/aurora/client/cli/test_restart.py 
 c19b21dd99dded0fdc631cef90997e2f2bd1156e 
   src/test/python/apache/aurora/client/cli/test_update.py 
 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
   src/test/python/apache/aurora/client/commands/test_diff.py 
 b48b53d3282d25c74a8424efe15ad19493acb3a5 
   src/test/python/apache/aurora/client/commands/test_restart.py 
 3789f3bd9ea2753070c966e0b755ab2168f7dd05 
   src/test/python/apache/aurora/client/commands/test_update.py 
 3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
   src/test/python/apache/aurora/client/test_base.py 
 fba08aeb8103aaa62fb86c389a1976f89289a086 
 
 Diff: https://reviews.apache.org/r/29137/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client:all
 Verified in vagrant. 
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-16 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29137/#review65283
---


This patch does not apply cleanly on master (ab18bd0), do you need to rebase?

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 17, 2014, 3:19 a.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29137/
 ---
 
 (Updated Dec. 17, 2014, 3:19 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Zameer Manji.
 
 
 Bugs: AURORA-691
 https://issues.apache.org/jira/browse/AURORA-691
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Dual reading populated configs to make sure we are backwards compatible by 
 0.8.0.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/api/updater.py 
 1c5708c300ba9e4ff3183978ab3c9aa84754fb7e 
   src/main/python/apache/aurora/client/base.py 
 a897e879dfda7340d7561247d3fa7cda2dbb5bc6 
   src/main/python/apache/aurora/client/cli/jobs.py 
 8bdb7f488f68b10b767ced627e55e57698e4f5f2 
   src/main/python/apache/aurora/client/commands/core.py 
 8d9286249f176c2974d9d097597b93ce9d9a8660 
   src/test/python/apache/aurora/client/api/test_updater.py 
 dad69e20598c1daf62706989dafcb4be50fed82b 
   src/test/python/apache/aurora/client/cli/test_diff.py 
 95c7c92942c7cbde344a093789b3e04b63200cc5 
   src/test/python/apache/aurora/client/cli/test_restart.py 
 c19b21dd99dded0fdc631cef90997e2f2bd1156e 
   src/test/python/apache/aurora/client/cli/test_update.py 
 044e6099a81bfa241a317b6a6b0f6f46da49bdc2 
   src/test/python/apache/aurora/client/commands/test_diff.py 
 b48b53d3282d25c74a8424efe15ad19493acb3a5 
   src/test/python/apache/aurora/client/commands/test_restart.py 
 3789f3bd9ea2753070c966e0b755ab2168f7dd05 
   src/test/python/apache/aurora/client/commands/test_update.py 
 3f5f83e75d287984a926ccf1c4fe2ad0d362b036 
   src/test/python/apache/aurora/client/test_base.py 
 fba08aeb8103aaa62fb86c389a1976f89289a086 
 
 Diff: https://reviews.apache.org/r/29137/diff/
 
 
 Testing
 ---
 
 ./pants src/test/python/apache/aurora/client:all
 Verified in vagrant. 
 
 
 Thanks,
 
 Maxim Khutornenko