Re: Review Request 29772: Add build-support/rbtools to .gitignore

2015-01-09 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29772/#review67480
---

Ship it!


Master (c7afcf0) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Jan. 9, 2015, 6:47 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29772/
 ---
 
 (Updated Jan. 9, 2015, 6:47 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add build-support/rbtools to .gitignore
 
 
 Diffs
 -
 
   .gitignore 86840972c53ea52a793968d3d00df6763a7d6ffb 
 
 Diff: https://reviews.apache.org/r/29772/diff/
 
 
 Testing
 ---
 
 $ git status
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 29772: Add build-support/rbtools to .gitignore

2015-01-09 Thread Joshua Cohen


 On Jan. 9, 2015, 7:06 p.m., Kevin Sweeney wrote:
  .gitignore, line 18
  https://reviews.apache.org/r/29772/diff/1/?file=814816#file814816line18
 
  I don't see this in my repo - is there some more context for this 
  change?
 
 Bill Farner wrote:
 Ditto.

I had assumed everyone was just living with this! I just `git clean -fdx`'d and 
I can't seem to get it to come back. I'l discard this review for now. If/when 
it shows back up I'll see what caused it and fix the source.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29772/#review67483
---


On Jan. 9, 2015, 6:47 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29772/
 ---
 
 (Updated Jan. 9, 2015, 6:47 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add build-support/rbtools to .gitignore
 
 
 Diffs
 -
 
   .gitignore 86840972c53ea52a793968d3d00df6763a7d6ffb 
 
 Diff: https://reviews.apache.org/r/29772/diff/
 
 
 Testing
 ---
 
 $ git status
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 29772: Add build-support/rbtools to .gitignore

2015-01-09 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29772/#review67483
---



.gitignore
https://reviews.apache.org/r/29772/#comment111527

I don't see this in my repo - is there some more context for this change?


- Kevin Sweeney


On Jan. 9, 2015, 10:47 a.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29772/
 ---
 
 (Updated Jan. 9, 2015, 10:47 a.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add build-support/rbtools to .gitignore
 
 
 Diffs
 -
 
   .gitignore 86840972c53ea52a793968d3d00df6763a7d6ffb 
 
 Diff: https://reviews.apache.org/r/29772/diff/
 
 
 Testing
 ---
 
 $ git status
 
 
 Thanks,
 
 Joshua Cohen
 




Re: Review Request 29772: Add build-support/rbtools to .gitignore

2015-01-09 Thread Bill Farner


 On Jan. 9, 2015, 7:06 p.m., Kevin Sweeney wrote:
  .gitignore, line 18
  https://reviews.apache.org/r/29772/diff/1/?file=814816#file814816line18
 
  I don't see this in my repo - is there some more context for this 
  change?

Ditto.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29772/#review67483
---


On Jan. 9, 2015, 6:47 p.m., Joshua Cohen wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29772/
 ---
 
 (Updated Jan. 9, 2015, 6:47 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Bill Farner.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add build-support/rbtools to .gitignore
 
 
 Diffs
 -
 
   .gitignore 86840972c53ea52a793968d3d00df6763a7d6ffb 
 
 Diff: https://reviews.apache.org/r/29772/diff/
 
 
 Testing
 ---
 
 $ git status
 
 
 Thanks,
 
 Joshua Cohen