Re: Review Request 30649: Upgrade pants to 0.0.28

2015-02-05 Thread Joe Smith


> On Feb. 5, 2015, 11:49 a.m., Brian Wickman wrote:
> > Ship It!

Brian, any chance you can commit this for me?

Thanks!
Joe


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649/#review71284
---


On Feb. 4, 2015, 8:13 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30649/
> ---
> 
> (Updated Feb. 4, 2015, 8:13 p.m.)
> 
> 
> Review request for Aurora, Brian Wickman and Zameer Manji.
> 
> 
> Bugs: AURORA-1104
> https://issues.apache.org/jira/browse/AURORA-1104
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade pants to 0.0.28
> 
> pants
> =
> 
> [0.0.28 changelog](https://pypi.python.org/pypi/pantsbuild.pants/0.0.28) and 
> selected highlights:
> 
> * bump virtualenv version to 12.0.5 RB #1621
> * Make ‘setup-py’ show up in ‘./pants goal goals’ RB #1466
> * Support use of pytest’s –pdb mode RB #1570
> * Upgrade pex dependency to 0.8.4
> 
> Pick up several perf wins
> Pick up fix that allows pex to read older pexes
> RB #1648 RB #1693
> * Refactor setting of PYTHONPATH in pants.ini RB #1586
> 
> 
> Diffs
> -
> 
>   .pantsversion 24ff85581f81976c5f70fe1a8c3c0f62b5275c91 
>   build-support/pants_requirements.txt 
> fb9a2d2dd5f17b3523eea1e4a7a77d69feddff39 
> 
> Diff: https://reviews.apache.org/r/30649/diff/
> 
> 
> Testing
> ---
> 
> Reviewed the diff [for 
> twitter/commons](https://github.com/twitter/commons/commit/574d79891d74a3a142e1db6b085b4c7e13c67659#diff-570e3786705ee6965f4f2f72c715382bR194)
> 
> ```
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
> ```
> 
> 
> Thanks,
> 
> Joe Smith
> 
>



Re: Review Request 30649: Upgrade pants to 0.0.28

2015-02-05 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649/#review71284
---

Ship it!


Ship It!

- Brian Wickman


On Feb. 5, 2015, 4:13 a.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30649/
> ---
> 
> (Updated Feb. 5, 2015, 4:13 a.m.)
> 
> 
> Review request for Aurora, Brian Wickman and Zameer Manji.
> 
> 
> Bugs: AURORA-1104
> https://issues.apache.org/jira/browse/AURORA-1104
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade pants to 0.0.28
> 
> pants
> =
> 
> [0.0.28 changelog](https://pypi.python.org/pypi/pantsbuild.pants/0.0.28) and 
> selected highlights:
> 
> * bump virtualenv version to 12.0.5 RB #1621
> * Make ‘setup-py’ show up in ‘./pants goal goals’ RB #1466
> * Support use of pytest’s –pdb mode RB #1570
> * Upgrade pex dependency to 0.8.4
> 
> Pick up several perf wins
> Pick up fix that allows pex to read older pexes
> RB #1648 RB #1693
> * Refactor setting of PYTHONPATH in pants.ini RB #1586
> 
> 
> Diffs
> -
> 
>   .pantsversion 24ff85581f81976c5f70fe1a8c3c0f62b5275c91 
>   build-support/pants_requirements.txt 
> fb9a2d2dd5f17b3523eea1e4a7a77d69feddff39 
> 
> Diff: https://reviews.apache.org/r/30649/diff/
> 
> 
> Testing
> ---
> 
> Reviewed the diff [for 
> twitter/commons](https://github.com/twitter/commons/commit/574d79891d74a3a142e1db6b085b4c7e13c67659#diff-570e3786705ee6965f4f2f72c715382bR194)
> 
> ```
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
> ```
> 
> 
> Thanks,
> 
> Joe Smith
> 
>



Re: Review Request 30649: Upgrade pants to 0.0.28

2015-02-04 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649/#review71172
---

Ship it!


Ship It!

- Zameer Manji


On Feb. 4, 2015, 8:13 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30649/
> ---
> 
> (Updated Feb. 4, 2015, 8:13 p.m.)
> 
> 
> Review request for Aurora, Brian Wickman and Zameer Manji.
> 
> 
> Bugs: AURORA-1104
> https://issues.apache.org/jira/browse/AURORA-1104
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade pants to 0.0.28
> 
> pants
> =
> 
> [0.0.28 changelog](https://pypi.python.org/pypi/pantsbuild.pants/0.0.28) and 
> selected highlights:
> 
> * bump virtualenv version to 12.0.5 RB #1621
> * Make ‘setup-py’ show up in ‘./pants goal goals’ RB #1466
> * Support use of pytest’s –pdb mode RB #1570
> * Upgrade pex dependency to 0.8.4
> 
> Pick up several perf wins
> Pick up fix that allows pex to read older pexes
> RB #1648 RB #1693
> * Refactor setting of PYTHONPATH in pants.ini RB #1586
> 
> 
> Diffs
> -
> 
>   .pantsversion 24ff85581f81976c5f70fe1a8c3c0f62b5275c91 
>   build-support/pants_requirements.txt 
> fb9a2d2dd5f17b3523eea1e4a7a77d69feddff39 
> 
> Diff: https://reviews.apache.org/r/30649/diff/
> 
> 
> Testing
> ---
> 
> Reviewed the diff [for 
> twitter/commons](https://github.com/twitter/commons/commit/574d79891d74a3a142e1db6b085b4c7e13c67659#diff-570e3786705ee6965f4f2f72c715382bR194)
> 
> ```
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
> ```
> 
> 
> Thanks,
> 
> Joe Smith
> 
>



Re: Review Request 30649: Upgrade pants to 0.0.28

2015-02-04 Thread Joe Smith


> On Feb. 4, 2015, 7:39 p.m., Zameer Manji wrote:
> > Please put the pants release notes in the commit. Or at least some sort of 
> > summary that explains what is new.

Done.


- Joe


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649/#review71148
---


On Feb. 4, 2015, 8:07 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30649/
> ---
> 
> (Updated Feb. 4, 2015, 8:07 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Bugs: AURORA-1104
> https://issues.apache.org/jira/browse/AURORA-1104
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade pants to 0.0.28
> 
> pants
> =
> 
> [0.0.28 changelog](https://pypi.python.org/pypi/pantsbuild.pants/0.0.28) and 
> selected highlights:
> 
> * bump virtualenv version to 12.0.5 RB #1621
> * Make ‘setup-py’ show up in ‘./pants goal goals’ RB #1466
> * Support use of pytest’s –pdb mode RB #1570
> * Upgrade pex dependency to 0.8.4
> 
> Pick up several perf wins
> Pick up fix that allows pex to read older pexes
> RB #1648 RB #1693
> * Refactor setting of PYTHONPATH in pants.ini RB #1586
> 
> 
> Diffs
> -
> 
>   .pantsversion 24ff85581f81976c5f70fe1a8c3c0f62b5275c91 
>   build-support/pants_requirements.txt 
> fb9a2d2dd5f17b3523eea1e4a7a77d69feddff39 
> 
> Diff: https://reviews.apache.org/r/30649/diff/
> 
> 
> Testing
> ---
> 
> Reviewed the diff [for 
> twitter/commons](https://github.com/twitter/commons/commit/574d79891d74a3a142e1db6b085b4c7e13c67659#diff-570e3786705ee6965f4f2f72c715382bR194)
> 
> ```
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
> ```
> 
> 
> Thanks,
> 
> Joe Smith
> 
>



Re: Review Request 30649: Upgrade pants to 0.0.28

2015-02-04 Thread Joe Smith

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649/
---

(Updated Feb. 4, 2015, 8:07 p.m.)


Review request for Aurora and Brian Wickman.


Bugs: AURORA-1104
https://issues.apache.org/jira/browse/AURORA-1104


Repository: aurora


Description (updated)
---

Upgrade pants to 0.0.28

pants
=

[0.0.28 changelog](https://pypi.python.org/pypi/pantsbuild.pants/0.0.28) and 
selected highlights:

* bump virtualenv version to 12.0.5 RB #1621
* Make ‘setup-py’ show up in ‘./pants goal goals’ RB #1466
* Support use of pytest’s –pdb mode RB #1570
* Upgrade pex dependency to 0.8.4

Pick up several perf wins
Pick up fix that allows pex to read older pexes
RB #1648 RB #1693
* Refactor setting of PYTHONPATH in pants.ini RB #1586


Diffs
-

  .pantsversion 24ff85581f81976c5f70fe1a8c3c0f62b5275c91 
  build-support/pants_requirements.txt fb9a2d2dd5f17b3523eea1e4a7a77d69feddff39 

Diff: https://reviews.apache.org/r/30649/diff/


Testing (updated)
---

Reviewed the diff [for 
twitter/commons](https://github.com/twitter/commons/commit/574d79891d74a3a142e1db6b085b4c7e13c67659#diff-570e3786705ee6965f4f2f72c715382bR194)

```
$ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
```


Thanks,

Joe Smith



Re: Review Request 30649: Upgrade pants to 0.0.28

2015-02-04 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649/#review71148
---


Please put the pants release notes in the commit. Or at least some sort of 
summary that explains what is new.

- Zameer Manji


On Feb. 4, 2015, 6:46 p.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30649/
> ---
> 
> (Updated Feb. 4, 2015, 6:46 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Bugs: AURORA-1104
> https://issues.apache.org/jira/browse/AURORA-1104
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade pants to 0.0.28
> 
> 
> Diffs
> -
> 
>   .pantsversion 24ff85581f81976c5f70fe1a8c3c0f62b5275c91 
>   build-support/pants_requirements.txt 
> fb9a2d2dd5f17b3523eea1e4a7a77d69feddff39 
> 
> Diff: https://reviews.apache.org/r/30649/diff/
> 
> 
> Testing
> ---
> 
> Reviewed the diff [for 
> twitter/commons](https://github.com/twitter/commons/commit/574d79891d74a3a142e1db6b085b4c7e13c67659#diff-570e3786705ee6965f4f2f72c715382bR194)
>  and
> 
> ```
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
> ```
> 
> 
> Thanks,
> 
> Joe Smith
> 
>



Re: Review Request 30649: Upgrade pants to 0.0.28

2015-02-04 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649/#review71146
---

Ship it!


Master (edcc252) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 5, 2015, 2:46 a.m., Joe Smith wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30649/
> ---
> 
> (Updated Feb. 5, 2015, 2:46 a.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Bugs: AURORA-1104
> https://issues.apache.org/jira/browse/AURORA-1104
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Upgrade pants to 0.0.28
> 
> 
> Diffs
> -
> 
>   .pantsversion 24ff85581f81976c5f70fe1a8c3c0f62b5275c91 
>   build-support/pants_requirements.txt 
> fb9a2d2dd5f17b3523eea1e4a7a77d69feddff39 
> 
> Diff: https://reviews.apache.org/r/30649/diff/
> 
> 
> Testing
> ---
> 
> Reviewed the diff [for 
> twitter/commons](https://github.com/twitter/commons/commit/574d79891d74a3a142e1db6b085b4c7e13c67659#diff-570e3786705ee6965f4f2f72c715382bR194)
>  and
> 
> ```
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
> ```
> 
> 
> Thanks,
> 
> Joe Smith
> 
>