Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-03-20 Thread George Sirois
> On Feb. 6, 2015, 6:52 p.m., Brian Wickman wrote: > > This is super rad. Thanks for taking this on. > > > > Before I do a deeper dive, what do you think about making the logrotate > > policy be specified by the user instead of the framework owner, with a > > sensible default? For example, i

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-03-09 Thread Brian Wickman
> On Feb. 6, 2015, 6:52 p.m., Brian Wickman wrote: > > This is super rad. Thanks for taking this on. > > > > Before I do a deeper dive, what do you think about making the logrotate > > policy be specified by the user instead of the framework owner, with a > > sensible default? For example, i

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-02-08 Thread Brian Wickman
> On Feb. 6, 2015, 6:52 p.m., Brian Wickman wrote: > > This is super rad. Thanks for taking this on. > > > > Before I do a deeper dive, what do you think about making the logrotate > > policy be specified by the user instead of the framework owner, with a > > sensible default? For example, i

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-02-08 Thread George Sirois
> On Feb. 6, 2015, 6:52 p.m., Brian Wickman wrote: > > This is super rad. Thanks for taking this on. > > > > Before I do a deeper dive, what do you think about making the logrotate > > policy be specified by the user instead of the framework owner, with a > > sensible default? For example, i

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-02-08 Thread George Sirois
> On Feb. 6, 2015, 6:52 p.m., Brian Wickman wrote: > > This is super rad. Thanks for taking this on. > > > > Before I do a deeper dive, what do you think about making the logrotate > > policy be specified by the user instead of the framework owner, with a > > sensible default? For example, i

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-02-06 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review71472 --- This is super rad. Thanks for taking this on. Before I do a deeper

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-02-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review71459 --- Ship it! Master (5059040) is green with this patch. ./build-suppo

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-02-06 Thread George Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/ --- (Updated Feb. 6, 2015, 5:51 p.m.) Review request for Aurora, Bill Farner and Br

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-02-06 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review71447 --- This patch does not apply cleanly on master (5059040), do you need t

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-02-06 Thread George Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/ --- (Updated Feb. 6, 2015, 5:14 p.m.) Review request for Aurora, Bill Farner and Br

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review71335 --- Master (1c78721) is red with this patch. ./build-support/jenkins/b

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-02-05 Thread George Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review71331 --- @ReviewBot retry - George Sirois On Feb. 5, 2015, 10:32 p.m., Geo

Re: Review Request 30695: Implements log rotation in the Thermos runner.

2015-02-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30695/#review71329 --- Master (1c78721) is red with this patch. ./build-support/jenkins/b