Re: Review Request 30942: Displaying blockIfNoPulseAfterMs in the UI

2015-02-12 Thread David McLaughlin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30942/#review72248
---

Ship it!


Ship It!

- David McLaughlin


On Feb. 12, 2015, 6:40 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30942/
> ---
> 
> (Updated Feb. 12, 2015, 6:40 p.m.)
> 
> 
> Review request for Aurora and David McLaughlin.
> 
> 
> Bugs: AURORA-1088
> https://issues.apache.org/jira/browse/AURORA-1088
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Displaying blockIfNoPulseAfterMs in the UI
> 
> 
> Diffs
> -
> 
>   src/main/resources/scheduler/assets/updateSettings.html 
> 5e48402561beb51efecd356f6ee44bdd1e465905 
> 
> Diff: https://reviews.apache.org/r/30942/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>



Re: Review Request 30942: Displaying blockIfNoPulseAfterMs in the UI

2015-02-12 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30942/#review72210
---


Master (ab8fae2) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Feb. 12, 2015, 6:40 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30942/
> ---
> 
> (Updated Feb. 12, 2015, 6:40 p.m.)
> 
> 
> Review request for Aurora and David McLaughlin.
> 
> 
> Bugs: AURORA-1088
> https://issues.apache.org/jira/browse/AURORA-1088
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Displaying blockIfNoPulseAfterMs in the UI
> 
> 
> Diffs
> -
> 
>   src/main/resources/scheduler/assets/updateSettings.html 
> 5e48402561beb51efecd356f6ee44bdd1e465905 
> 
> Diff: https://reviews.apache.org/r/30942/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>