Re: Review Request 31123: Enable checkstyle indentation check, fix violations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72778 --- This patch does not apply cleanly on master (2b8eb4b), do you need to rebase? I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 17, 2015, 6 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/ --- (Updated Feb. 17, 2015, 6 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Repository: aurora Description --- This is the first step of many to align our configuration with checkstyle's Google style config. There are enough differences that a full switch will touch every file in our code base, so i'd like to start with targeted changes. Diffs - config/checkstyle/checkstyle.xml c4c6c4457c879fb4becedfff51847ec840df9300 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java b5a3140e3560f790d1db496dca3c2ee0dc96a195 src/main/java/org/apache/aurora/scheduler/http/StructDump.java 12b28be5a5c711edeed10d8e570e3d61cf9ccfbf src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java eae79d59b445ea58f46dc9e3107c03fbd83b6a95 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 9158271f255eb5c04a1394bf4d470875e8e07b45 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java cb870f9a127b97d3274d07765a65bcb3eaa40dea src/main/java/org/apache/aurora/scheduler/storage/SnapshotStore.java 49584a9e8158f80a45f2df34f917d4bf2229c87b src/main/java/org/apache/aurora/scheduler/storage/Storage.java 2055e11149ca18180a5f21a36e8c16099f0efa49 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 1b7985084d227ef09d483665ae934540a1512ef4 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2a9d36ab2c01960dc5384fc3ed90df4e11c0b12a src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 5647349854a5e04de749c4d809684a0066d4da06 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 5f08d00d39f016af9bc296e517ad49b66ab5a8de src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java bc26c4c742a7d2e022edae79e1b06f1982a27764 Diff: https://reviews.apache.org/r/31123/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31123: Enable checkstyle indentation check, fix violations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72739 --- Ship it! Ship It! - Zameer Manji On Feb. 17, 2015, 10 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/ --- (Updated Feb. 17, 2015, 10 a.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Repository: aurora Description --- This is the first step of many to align our configuration with checkstyle's Google style config. There are enough differences that a full switch will touch every file in our code base, so i'd like to start with targeted changes. Diffs - config/checkstyle/checkstyle.xml c4c6c4457c879fb4becedfff51847ec840df9300 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java b5a3140e3560f790d1db496dca3c2ee0dc96a195 src/main/java/org/apache/aurora/scheduler/http/StructDump.java 12b28be5a5c711edeed10d8e570e3d61cf9ccfbf src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java eae79d59b445ea58f46dc9e3107c03fbd83b6a95 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 9158271f255eb5c04a1394bf4d470875e8e07b45 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java cb870f9a127b97d3274d07765a65bcb3eaa40dea src/main/java/org/apache/aurora/scheduler/storage/SnapshotStore.java 49584a9e8158f80a45f2df34f917d4bf2229c87b src/main/java/org/apache/aurora/scheduler/storage/Storage.java 2055e11149ca18180a5f21a36e8c16099f0efa49 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 1b7985084d227ef09d483665ae934540a1512ef4 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2a9d36ab2c01960dc5384fc3ed90df4e11c0b12a src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 5647349854a5e04de749c4d809684a0066d4da06 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 5f08d00d39f016af9bc296e517ad49b66ab5a8de src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java bc26c4c742a7d2e022edae79e1b06f1982a27764 Diff: https://reviews.apache.org/r/31123/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31123: Enable checkstyle indentation check, fix violations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72787 --- Ship it! Ship It! - Kevin Sweeney On Feb. 17, 2015, 10 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/ --- (Updated Feb. 17, 2015, 10 a.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Repository: aurora Description --- This is the first step of many to align our configuration with checkstyle's Google style config. There are enough differences that a full switch will touch every file in our code base, so i'd like to start with targeted changes. Diffs - config/checkstyle/checkstyle.xml c4c6c4457c879fb4becedfff51847ec840df9300 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java b5a3140e3560f790d1db496dca3c2ee0dc96a195 src/main/java/org/apache/aurora/scheduler/http/StructDump.java 12b28be5a5c711edeed10d8e570e3d61cf9ccfbf src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java eae79d59b445ea58f46dc9e3107c03fbd83b6a95 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 9158271f255eb5c04a1394bf4d470875e8e07b45 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java cb870f9a127b97d3274d07765a65bcb3eaa40dea src/main/java/org/apache/aurora/scheduler/storage/SnapshotStore.java 49584a9e8158f80a45f2df34f917d4bf2229c87b src/main/java/org/apache/aurora/scheduler/storage/Storage.java 2055e11149ca18180a5f21a36e8c16099f0efa49 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 1b7985084d227ef09d483665ae934540a1512ef4 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2a9d36ab2c01960dc5384fc3ed90df4e11c0b12a src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 5647349854a5e04de749c4d809684a0066d4da06 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 5f08d00d39f016af9bc296e517ad49b66ab5a8de src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java bc26c4c742a7d2e022edae79e1b06f1982a27764 Diff: https://reviews.apache.org/r/31123/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31123: Enable checkstyle indentation check, fix violations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72796 --- Ship it! Ship It! - Joshua Cohen On Feb. 17, 2015, 6 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/ --- (Updated Feb. 17, 2015, 6 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Repository: aurora Description --- This is the first step of many to align our configuration with checkstyle's Google style config. There are enough differences that a full switch will touch every file in our code base, so i'd like to start with targeted changes. Diffs - config/checkstyle/checkstyle.xml c4c6c4457c879fb4becedfff51847ec840df9300 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java b5a3140e3560f790d1db496dca3c2ee0dc96a195 src/main/java/org/apache/aurora/scheduler/http/StructDump.java 12b28be5a5c711edeed10d8e570e3d61cf9ccfbf src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java eae79d59b445ea58f46dc9e3107c03fbd83b6a95 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 9158271f255eb5c04a1394bf4d470875e8e07b45 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java cb870f9a127b97d3274d07765a65bcb3eaa40dea src/main/java/org/apache/aurora/scheduler/storage/SnapshotStore.java 49584a9e8158f80a45f2df34f917d4bf2229c87b src/main/java/org/apache/aurora/scheduler/storage/Storage.java 2055e11149ca18180a5f21a36e8c16099f0efa49 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 1b7985084d227ef09d483665ae934540a1512ef4 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2a9d36ab2c01960dc5384fc3ed90df4e11c0b12a src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 5647349854a5e04de749c4d809684a0066d4da06 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 5f08d00d39f016af9bc296e517ad49b66ab5a8de src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java bc26c4c742a7d2e022edae79e1b06f1982a27764 Diff: https://reviews.apache.org/r/31123/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31123: Enable checkstyle indentation check, fix violations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/ --- (Updated Feb. 17, 2015, 9:49 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Changes --- Rebased. Repository: aurora Description --- This is the first step of many to align our configuration with checkstyle's Google style config. There are enough differences that a full switch will touch every file in our code base, so i'd like to start with targeted changes. Diffs (updated) - config/checkstyle/checkstyle.xml c4c6c4457c879fb4becedfff51847ec840df9300 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java b5a3140e3560f790d1db496dca3c2ee0dc96a195 src/main/java/org/apache/aurora/scheduler/http/StructDump.java 12b28be5a5c711edeed10d8e570e3d61cf9ccfbf src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java eae79d59b445ea58f46dc9e3107c03fbd83b6a95 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 9158271f255eb5c04a1394bf4d470875e8e07b45 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java cb870f9a127b97d3274d07765a65bcb3eaa40dea src/main/java/org/apache/aurora/scheduler/storage/SnapshotStore.java 49584a9e8158f80a45f2df34f917d4bf2229c87b src/main/java/org/apache/aurora/scheduler/storage/Storage.java 2055e11149ca18180a5f21a36e8c16099f0efa49 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 1b7985084d227ef09d483665ae934540a1512ef4 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7014d598d41f007b0dee0b2db1aa2d4cdd592be6 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java d0e11932e8b5ba1393279137c8465a308e1d6bf5 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 5f08d00d39f016af9bc296e517ad49b66ab5a8de src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java bc26c4c742a7d2e022edae79e1b06f1982a27764 Diff: https://reviews.apache.org/r/31123/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31123: Enable checkstyle indentation check, fix violations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/ --- (Updated Feb. 17, 2015, 10:01 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Changes --- This must be prime time for new commits. Rebased again. Repository: aurora Description --- This is the first step of many to align our configuration with checkstyle's Google style config. There are enough differences that a full switch will touch every file in our code base, so i'd like to start with targeted changes. Diffs (updated) - config/checkstyle/checkstyle.xml c4c6c4457c879fb4becedfff51847ec840df9300 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java b5a3140e3560f790d1db496dca3c2ee0dc96a195 src/main/java/org/apache/aurora/scheduler/http/StructDump.java 12b28be5a5c711edeed10d8e570e3d61cf9ccfbf src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java eae79d59b445ea58f46dc9e3107c03fbd83b6a95 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 9158271f255eb5c04a1394bf4d470875e8e07b45 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java cb870f9a127b97d3274d07765a65bcb3eaa40dea src/main/java/org/apache/aurora/scheduler/storage/SnapshotStore.java 49584a9e8158f80a45f2df34f917d4bf2229c87b src/main/java/org/apache/aurora/scheduler/storage/Storage.java 2055e11149ca18180a5f21a36e8c16099f0efa49 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 1b7985084d227ef09d483665ae934540a1512ef4 src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 2e58f67d1b0e5d0290b59d399e3ea8b6708477d0 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 580369f31e0394ec8987be1109de7fd91e1e6bec src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java d0e11932e8b5ba1393279137c8465a308e1d6bf5 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 5f08d00d39f016af9bc296e517ad49b66ab5a8de src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java bc26c4c742a7d2e022edae79e1b06f1982a27764 Diff: https://reviews.apache.org/r/31123/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31123: Enable checkstyle indentation check, fix violations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72801 --- Ship it! Ship It! - Joshua Cohen On Feb. 17, 2015, 9:49 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/ --- (Updated Feb. 17, 2015, 9:49 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Repository: aurora Description --- This is the first step of many to align our configuration with checkstyle's Google style config. There are enough differences that a full switch will touch every file in our code base, so i'd like to start with targeted changes. Diffs - config/checkstyle/checkstyle.xml c4c6c4457c879fb4becedfff51847ec840df9300 src/main/java/org/apache/aurora/scheduler/configuration/Resources.java b5a3140e3560f790d1db496dca3c2ee0dc96a195 src/main/java/org/apache/aurora/scheduler/http/StructDump.java 12b28be5a5c711edeed10d8e570e3d61cf9ccfbf src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java eae79d59b445ea58f46dc9e3107c03fbd83b6a95 src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java 9158271f255eb5c04a1394bf4d470875e8e07b45 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java cb870f9a127b97d3274d07765a65bcb3eaa40dea src/main/java/org/apache/aurora/scheduler/storage/SnapshotStore.java 49584a9e8158f80a45f2df34f917d4bf2229c87b src/main/java/org/apache/aurora/scheduler/storage/Storage.java 2055e11149ca18180a5f21a36e8c16099f0efa49 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 1b7985084d227ef09d483665ae934540a1512ef4 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7014d598d41f007b0dee0b2db1aa2d4cdd592be6 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java d0e11932e8b5ba1393279137c8465a308e1d6bf5 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 5f08d00d39f016af9bc296e517ad49b66ab5a8de src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java bc26c4c742a7d2e022edae79e1b06f1982a27764 Diff: https://reviews.apache.org/r/31123/diff/ Testing --- Thanks, Bill Farner