---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/
---
(Updated March 3, 2015, 3:21 p.m.)
Review request for Aurora, Jay Buffington
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review75000
---
@ReviewBot retry
- Bill Farner
On March 3, 2015, 3:23 p.m.,
On March 3, 2015, 6:28 p.m., Aurora ReviewBot wrote:
Master (782e3e7) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.update
. SUCCESS
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review75005
---
@ReviewBot retry
- Bill Farner
On March 3, 2015, 3:23 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review75050
---
Ship it!
Master (782e3e7) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/
---
(Updated March 2, 2015, 9:03 p.m.)
Review request for Aurora, Jay Buffington
On March 2, 2015, 6:56 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 133
https://reviews.apache.org/r/31338/diff/8/?file=882131#file882131line133
I think you can drop this since it's == `Resources.NONE` (default).
Done
On March
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review74821
---
This patch does not apply cleanly on master (4cca6a6), do you need
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review74752
---
@ReviewBot retry
- Steve Niemitz
On March 2, 2015, 4:59 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review74751
---
Master (4cca6a6) is red with this patch.
On Feb. 27, 2015, 5:01 p.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java,
lines 215-227
https://reviews.apache.org/r/31338/diff/4/?file=876499#file876499line215
Can this instead be an exact comparison of ListVolume? Presumably
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review74782
---
Ship it!
LGTM mod nits.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review74507
---
Overall LGTM, all minor issues.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/
---
(Updated Feb. 27, 2015, 8:19 p.m.)
Review request for Aurora, Jay Buffington
On Feb. 27, 2015, 5:01 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java, line
36
https://reviews.apache.org/r/31338/diff/4/?file=876495#file876495line36
should this be private?
I wanted it to be, but got style checker violations when
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review74627
---
Master (4cca6a6) is red with this patch.
On Feb. 27, 2015, 5:01 p.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java,
lines 215-227
https://reviews.apache.org/r/31338/diff/4/?file=876499#file876499line215
Can this instead be an exact comparison of ListVolume? Presumably
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/
---
(Updated Feb. 27, 2015, 11:16 p.m.)
Review request for Aurora, Jay Buffington
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review74103
---
lgtm minus a few nits...
On Feb. 25, 2015, 10:06 p.m., Joshua Cohen wrote:
src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java, lines
44-45
https://reviews.apache.org/r/31338/diff/2/?file=876074#file876074line44
this should be unnecessary, we will have thrown on the previous line?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review74154
---
Ship it!
Master (9442e08) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/
---
(Updated Feb. 25, 2015, 10:35 p.m.)
Review request for Aurora, Jay Buffington
On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote:
Steve Niemitz wrote:
I'm not a big fan of how the parsing works here either. I was thinking
about this last night, I think I have a better plan here. Lemme know what
you think.
I already want to add volume support
On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote:
Steve Niemitz wrote:
I'm not a big fan of how the parsing works here either. I was thinking
about this last night, I think I have a better plan here. Lemme know what
you think.
I already want to add volume support
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review73822
---
On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote:
Steve Niemitz wrote:
I'm not a big fan of how the parsing works here either. I was thinking
about this last night, I think I have a better plan here. Lemme know what
you think.
I already want to add volume support
On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote:
Steve Niemitz wrote:
I'm not a big fan of how the parsing works here either. I was thinking
about this last night, I think I have a better plan here. Lemme know what
you think.
I already want to add volume support
On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote:
Steve Niemitz wrote:
I'm not a big fan of how the parsing works here either. I was thinking
about this last night, I think I have a better plan here. Lemme know what
you think.
I already want to add volume support
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31338/#review73744
---
Ship it!
Master (19378c1) is green with this patch.
29 matches
Mail list logo