Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review75050 --- Ship it! Master (782e3e7) is green with this patch. ./build-suppo

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On March 3, 2015, 6:28 p.m., Aurora ReviewBot wrote: > > Master (782e3e7) is red with this patch. > > ./build-support/jenkins/build.sh > > > > src.test.python.apache.aurora.client.cli.update > > . SUCCESS > > sr

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review75005 --- @ReviewBot retry - Bill Farner On March 3, 2015, 3:23 p.m., Steve

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review75003 --- Master (782e3e7) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review75000 --- @ReviewBot retry - Bill Farner On March 3, 2015, 3:23 p.m., Steve

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On March 3, 2015, 3:43 p.m., Aurora ReviewBot wrote: > > Master (4cca6a6) is red with this patch. > > ./build-support/jenkins/build.sh > > > > > > src.test.python.apache.aurora.executor.bin.gc_executor_entry_point > > . SUCCESS > >

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74965 --- Master (4cca6a6) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated March 3, 2015, 3:23 p.m.) Review request for Aurora, Jay Buffington an

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated March 3, 2015, 3:21 p.m.) Review request for Aurora, Jay Buffington an

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74821 --- This patch does not apply cleanly on master (4cca6a6), do you need t

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated March 2, 2015, 9:03 p.m.) Review request for Aurora, Jay Buffington an

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On March 2, 2015, 6:56 p.m., Bill Farner wrote: > > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 133 > > > > > > I think you can drop this since it's == `Resources.NONE` (default). Done

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74782 --- Ship it! LGTM mod nits. src/jmh/java/org/apache/aurora/benchmark/

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 27, 2015, 5:01 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java, > > lines 215-227 > > > > > > Can this instead be an exact comparison of List? Pres

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74755 --- Ship it! Master (4cca6a6) is green with this patch. ./build-suppo

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74752 --- @ReviewBot retry - Steve Niemitz On March 2, 2015, 4:59 p.m., Ste

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74751 --- Master (4cca6a6) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated March 2, 2015, 4:59 p.m.) Review request for Aurora, Jay Buffington an

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 27, 2015, 5:01 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java, > > lines 215-227 > > > > > > Can this instead be an exact comparison of List? Pres

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74745 --- Master (4cca6a6) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated March 2, 2015, 4:37 p.m.) Review request for Aurora, Jay Buffington an

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 27, 2015, 5:01 p.m., Bill Farner wrote: > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java, > > lines 215-227 > > > > > > Can this instead be an exact comparison of List? Pres

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74627 --- Master (4cca6a6) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated Feb. 27, 2015, 11:16 p.m.) Review request for Aurora, Jay Buffington a

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74582 --- Master (443f668) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated Feb. 27, 2015, 8:19 p.m.) Review request for Aurora, Jay Buffington an

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 27, 2015, 5:01 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java, line > > 36 > > > > > > should this be private? I wanted it to be, but got style checker vio

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74507 --- Overall LGTM, all minor issues. api/src/main/thrift/org/apache/aur

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74154 --- Ship it! Master (9442e08) is green with this patch. ./build-suppo

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74134 --- @ReviewBot retry - Steve Niemitz On Feb. 25, 2015, 10:35 p.m., St

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74131 --- Master (9442e08) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated Feb. 25, 2015, 10:35 p.m.) Review request for Aurora, Jay Buffington a

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74111 --- Ship it! Looks good to me! I'll let someone a little bit more famil

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74110 --- Master (9442e08) is red with this patch. ./build-support/jenkins/b

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated Feb. 25, 2015, 10:30 p.m.) Review request for Aurora, Jay Buffington a

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 25, 2015, 10:06 p.m., Joshua Cohen wrote: > > src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java, lines > > 44-45 > > > > > > this should be unnecessary, we will have thrown on the previous l

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74103 --- lgtm minus a few nits... src/test/java/org/apache/aurora/scheduler

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74066 --- Ship it! Master (81641a1) is green with this patch. ./build-suppo

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated Feb. 25, 2015, 7:15 p.m.) Review request for Aurora, Jay Buffington an

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review73943 --- Drive-by, i realizer you're in-flight on an update to the diff so i

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote: > > > > Steve Niemitz wrote: > I'm not a big fan of how the parsing works here either. I was thinking > about this last night, I think I have a better plan here. Lemme know what > you think. > > I already want to add volume supp

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote: > > > > Steve Niemitz wrote: > I'm not a big fan of how the parsing works here either. I was thinking > about this last night, I think I have a better plan here. Lemme know what > you think. > > I already want to add volume supp

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote: > > > > Steve Niemitz wrote: > I'm not a big fan of how the parsing works here either. I was thinking > about this last night, I think I have a better plan here. Lemme know what > you think. > > I already want to add volume supp

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote: > > > > Steve Niemitz wrote: > I'm not a big fan of how the parsing works here either. I was thinking > about this last night, I think I have a better plan here. Lemme know what > you think. > > I already want to add volume supp

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote: > > > > Steve Niemitz wrote: > I'm not a big fan of how the parsing works here either. I was thinking > about this last night, I think I have a better plan here. Lemme know what > you think. > > I already want to add volume supp

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 24, 2015, 3:34 p.m., Stephan Erb wrote: > > That's interesting, I didn't know the filesystem isolator would pick up volumes and mount them as well. I think its outside the scope of this patch to refactor the code for this, however, I created AURORA-1140 to track it, as I agree it'd

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review73822 --- src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.ja

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote: > > > > Steve Niemitz wrote: > I'm not a big fan of how the parsing works here either. I was thinking > about this last night, I think I have a better plan here. Lemme know what > you think. > > I already want to add volume supp

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 24, 2015, 7:01 a.m., Joshua Cohen wrote: > > > > Steve Niemitz wrote: > I'm not a big fan of how the parsing works here either. I was thinking > about this last night, I think I have a better plan here. Lemme know what > you think. > > I already want to add volume supp

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

> On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote: > > I'm not a big fan of how the parsing works here either. I was thinking about this last night, I think I have a better plan here. Lemme know what you think. I already want to add volume support per-job at some point, so I propose adding

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review73755 --- src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review73744 --- Ship it! Master (19378c1) is green with this patch. ./build-suppo