Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-27 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74513
---

Ship it!


Master (766d1c9) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Feb. 27, 2015, 5:11 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31388/
 ---
 
 (Updated Feb. 27, 2015, 5:11 p.m.)
 
 
 Review request for Aurora, Joshua Cohen and Bill Farner.
 
 
 Bugs: AURORA-1093
 https://issues.apache.org/jira/browse/AURORA-1093
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Update thrift API and internal code to use JobUpdateSummary.key rather than 
 job key and id.
 
 Note: This change will leave the client in a broken state w.r.t. the 
 scheduler.  I will hold commiting this change until i have another review 
 ready to go that updates the client.
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6a00ce2c30ce24851560c4d499c395194dbeed16 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
 8444d225e91c75e9a571049d28af7264b6d2d017 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 6ade817284b4c0607fe1ff09ad61ea47768f7297 
   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
 d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 06de5384182f84f973a28e312c0dc4329f593dad 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 b9dce16fa705fc14b5af394f8edb6301c789aff4 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  56398f33206cfa1fa45601a21760c7e23e2616bf 
   
 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
  d1bd3c975b2057b46597f38555c2a73d14835600 
   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
 b8c919585307e27f154782ee179153165458bed7 
   src/main/python/apache/aurora/client/api/__init__.py 
 07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
   src/main/python/apache/aurora/client/cli/context.py 
 ea64010ab20c1292fb3fd1f5eb71394b7c965743 
   src/main/python/apache/aurora/client/cli/update.py 
 bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
  c08f09a511e1fc631abdae50630b8b7ab10a440b 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
   src/main/resources/scheduler/assets/breadcrumb.html 
 b5f82ca120d3b76b63a61628437525cec8870015 
   src/main/resources/scheduler/assets/job.html 
 4a00a8863d676f168fbfce9f45ec4bad0244199f 
   src/main/resources/scheduler/assets/js/controllers.js 
 092e7d5df2121f45f99f5a788187d52bebb7e5dd 
   src/main/resources/scheduler/assets/js/services.js 
 87eef8c689ac2c2e8b6aae5c91ba7b0e3b353efd 
   src/main/resources/scheduler/assets/latestUpdates.html 
 9844edadbdea1c123b1c0afea87dd94664f93f37 
   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
 b79b07c23e00fab524aef21481070c5f09c9fa18 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
  81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
   
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
  e969b972806bef9aa67729c8a35283df6145e687 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
 2405bb8ad379e355a7987e9bb4163e1693f18777 
   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
 3ba6274b97393ac2228d3eac8ba1615cb57014f8 
   src/test/python/apache/aurora/client/api/test_api.py 
 ff1aff2eac391f219bc7c2483a16e35f916a224c 
   src/test/python/apache/aurora/client/cli/test_status.py 
 1f39aa1c50a41e174804751b4cce25b96b6aebed 
   src/test/python/apache/aurora/client/cli/test_supdate.py 
 6413c0db20db5914c7b1537da2bbc6e110705dc2 
 
 Diff: https://reviews.apache.org/r/31388/diff/
 
 
 Testing
 ---
 
 Manually :-( verified javascript changes by performing an async update in 
 vagrant and viewing relevant pages.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-27 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74508
---

Ship it!


Ship It!

- Maxim Khutornenko


On Feb. 27, 2015, 4:49 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31388/
 ---
 
 (Updated Feb. 27, 2015, 4:49 p.m.)
 
 
 Review request for Aurora, Joshua Cohen and Bill Farner.
 
 
 Bugs: AURORA-1093
 https://issues.apache.org/jira/browse/AURORA-1093
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Update thrift API and internal code to use JobUpdateSummary.key rather than 
 job key and id.
 
 Note: This change will leave the client in a broken state w.r.t. the 
 scheduler.  I will hold commiting this change until i have another review 
 ready to go that updates the client.
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6a00ce2c30ce24851560c4d499c395194dbeed16 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
 8444d225e91c75e9a571049d28af7264b6d2d017 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 6ade817284b4c0607fe1ff09ad61ea47768f7297 
   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
 d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 06de5384182f84f973a28e312c0dc4329f593dad 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 b9dce16fa705fc14b5af394f8edb6301c789aff4 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  56398f33206cfa1fa45601a21760c7e23e2616bf 
   
 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
  d1bd3c975b2057b46597f38555c2a73d14835600 
   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
 b8c919585307e27f154782ee179153165458bed7 
   src/main/python/apache/aurora/client/api/__init__.py 
 07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
   src/main/python/apache/aurora/client/cli/context.py 
 ea64010ab20c1292fb3fd1f5eb71394b7c965743 
   src/main/python/apache/aurora/client/cli/update.py 
 bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
  c08f09a511e1fc631abdae50630b8b7ab10a440b 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
   src/main/resources/scheduler/assets/breadcrumb.html 
 b5f82ca120d3b76b63a61628437525cec8870015 
   src/main/resources/scheduler/assets/job.html 
 4a00a8863d676f168fbfce9f45ec4bad0244199f 
   src/main/resources/scheduler/assets/js/controllers.js 
 092e7d5df2121f45f99f5a788187d52bebb7e5dd 
   src/main/resources/scheduler/assets/js/services.js 
 87eef8c689ac2c2e8b6aae5c91ba7b0e3b353efd 
   src/main/resources/scheduler/assets/latestUpdates.html 
 9844edadbdea1c123b1c0afea87dd94664f93f37 
   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
 b79b07c23e00fab524aef21481070c5f09c9fa18 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
  81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
   
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
  e969b972806bef9aa67729c8a35283df6145e687 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
 2405bb8ad379e355a7987e9bb4163e1693f18777 
   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
 3ba6274b97393ac2228d3eac8ba1615cb57014f8 
   src/test/python/apache/aurora/client/api/test_api.py 
 ff1aff2eac391f219bc7c2483a16e35f916a224c 
   src/test/python/apache/aurora/client/cli/test_status.py 
 1f39aa1c50a41e174804751b4cce25b96b6aebed 
   src/test/python/apache/aurora/client/cli/test_supdate.py 
 6413c0db20db5914c7b1537da2bbc6e110705dc2 
 
 Diff: https://reviews.apache.org/r/31388/diff/
 
 
 Testing
 ---
 
 Manually :-( verified javascript changes by performing an async update in 
 vagrant and viewing relevant pages.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-27 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/
---

(Updated Feb. 27, 2015, 4:49 p.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
---

Updated javascript API usages.


Bugs: AURORA-1093
https://issues.apache.org/jira/browse/AURORA-1093


Repository: aurora


Description (updated)
---

Update thrift API and internal code to use JobUpdateSummary.key rather than job 
key and id.

Note: This change will leave the client in a broken state w.r.t. the scheduler. 
 I will hold commiting this change until i have another review ready to go that 
updates the client.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
6a00ce2c30ce24851560c4d499c395194dbeed16 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
8444d225e91c75e9a571049d28af7264b6d2d017 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
6ade817284b4c0607fe1ff09ad61ea47768f7297 
  src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
  src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
06de5384182f84f973a28e312c0dc4329f593dad 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
b9dce16fa705fc14b5af394f8edb6301c789aff4 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
56398f33206cfa1fa45601a21760c7e23e2616bf 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
d1bd3c975b2057b46597f38555c2a73d14835600 
  src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
b8c919585307e27f154782ee179153165458bed7 
  src/main/python/apache/aurora/client/api/__init__.py 
07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
  src/main/python/apache/aurora/client/cli/context.py 
ea64010ab20c1292fb3fd1f5eb71394b7c965743 
  src/main/python/apache/aurora/client/cli/update.py 
bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
 c08f09a511e1fc631abdae50630b8b7ab10a440b 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
  src/main/resources/scheduler/assets/breadcrumb.html 
b5f82ca120d3b76b63a61628437525cec8870015 
  src/main/resources/scheduler/assets/job.html 
4a00a8863d676f168fbfce9f45ec4bad0244199f 
  src/main/resources/scheduler/assets/js/controllers.js 
092e7d5df2121f45f99f5a788187d52bebb7e5dd 
  src/main/resources/scheduler/assets/js/services.js 
87eef8c689ac2c2e8b6aae5c91ba7b0e3b353efd 
  src/main/resources/scheduler/assets/latestUpdates.html 
9844edadbdea1c123b1c0afea87dd94664f93f37 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
b79b07c23e00fab524aef21481070c5f09c9fa18 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 
81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
e969b972806bef9aa67729c8a35283df6145e687 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
2405bb8ad379e355a7987e9bb4163e1693f18777 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
3ba6274b97393ac2228d3eac8ba1615cb57014f8 
  src/test/python/apache/aurora/client/api/test_api.py 
ff1aff2eac391f219bc7c2483a16e35f916a224c 
  src/test/python/apache/aurora/client/cli/test_status.py 
1f39aa1c50a41e174804751b4cce25b96b6aebed 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
6413c0db20db5914c7b1537da2bbc6e110705dc2 

Diff: https://reviews.apache.org/r/31388/diff/


Testing (updated)
---

Manually :-( verified javascript changes by performing an async update in 
vagrant and viewing relevant pages.


Thanks,

Bill Farner



Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-27 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74509
---


Master (766d1c9) is red with this patch.
  ./build-support/jenkins/build.sh

Note: Recompile with -Xlint:unchecked for details.

:api:checkPython
:api:generateThriftEntitiesJava
:api:classesThriftEntities
:api:compileJava UP-TO-DATE
:api:generateThriftResources
:api:processResources UP-TO-DATE
:api:classes
:api:jar
:compileJavaNote: Writing 
file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

:processResources
:classes
:jar
:assemble
:compileJmhJavawarning: Supported source version 'RELEASE_6' from annotation 
processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source 
'1.7'
1 warning

:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
'JobUpdateKey' is not defined. 
(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/resources/scheduler/assets/js/controllers.js:270:27)
 var updateKey = new JobUpdateKey();

:jsHint FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':jsHint'.
 Process 'command '/home/jenkins/tools/java/jdk1.7.0_25-32/bin/java'' finished 
 with non-zero exit value 2

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 33.519 secs


I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Feb. 27, 2015, 4:49 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31388/
 ---
 
 (Updated Feb. 27, 2015, 4:49 p.m.)
 
 
 Review request for Aurora, Joshua Cohen and Bill Farner.
 
 
 Bugs: AURORA-1093
 https://issues.apache.org/jira/browse/AURORA-1093
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Update thrift API and internal code to use JobUpdateSummary.key rather than 
 job key and id.
 
 Note: This change will leave the client in a broken state w.r.t. the 
 scheduler.  I will hold commiting this change until i have another review 
 ready to go that updates the client.
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6a00ce2c30ce24851560c4d499c395194dbeed16 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
 8444d225e91c75e9a571049d28af7264b6d2d017 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 6ade817284b4c0607fe1ff09ad61ea47768f7297 
   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
 d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 06de5384182f84f973a28e312c0dc4329f593dad 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 b9dce16fa705fc14b5af394f8edb6301c789aff4 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  56398f33206cfa1fa45601a21760c7e23e2616bf 
   
 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
  d1bd3c975b2057b46597f38555c2a73d14835600 
   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
 b8c919585307e27f154782ee179153165458bed7 
   src/main/python/apache/aurora/client/api/__init__.py 
 07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
   src/main/python/apache/aurora/client/cli/context.py 
 ea64010ab20c1292fb3fd1f5eb71394b7c965743 
   src/main/python/apache/aurora/client/cli/update.py 
 bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
  c08f09a511e1fc631abdae50630b8b7ab10a440b 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
   src/main/resources/scheduler/assets/breadcrumb.html 
 b5f82ca120d3b76b63a61628437525cec8870015 
   src/main/resources/scheduler/assets/job.html 
 4a00a8863d676f168fbfce9f45ec4bad0244199f 
   src/main/resources/scheduler/assets/js/controllers.js 
 092e7d5df2121f45f99f5a788187d52bebb7e5dd 
   src/main/resources/scheduler/assets/js/services.js 
 87eef8c689ac2c2e8b6aae5c91ba7b0e3b353efd 
   src/main/resources/scheduler/assets/latestUpdates.html 
 9844edadbdea1c123b1c0afea87dd94664f93f37 
   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
 b79b07c23e00fab524aef21481070c5f09c9fa18 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
  81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
   
 

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-25 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/
---

(Updated Feb. 25, 2015, 8:37 p.m.)


Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Changes
---

Updated console and javascript clients to use the new fields.


Bugs: AURORA-1093
https://issues.apache.org/jira/browse/AURORA-1093


Repository: aurora


Description
---

Update thrift API and internal code to use JobUpdateSummary.key rather than job 
key and id.

Note: This change will leave the client in a broken state w.r.t. the scheduler. 
 I will hold commiting this change until i have another review ready to go that 
updates the client.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
6a00ce2c30ce24851560c4d499c395194dbeed16 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
8444d225e91c75e9a571049d28af7264b6d2d017 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
6ade817284b4c0607fe1ff09ad61ea47768f7297 
  src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
  src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
06de5384182f84f973a28e312c0dc4329f593dad 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
b9dce16fa705fc14b5af394f8edb6301c789aff4 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
56398f33206cfa1fa45601a21760c7e23e2616bf 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
d1bd3c975b2057b46597f38555c2a73d14835600 
  src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
b8c919585307e27f154782ee179153165458bed7 
  src/main/python/apache/aurora/client/api/__init__.py 
07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
  src/main/python/apache/aurora/client/cli/context.py 
ea64010ab20c1292fb3fd1f5eb71394b7c965743 
  src/main/python/apache/aurora/client/cli/update.py 
bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
 c08f09a511e1fc631abdae50630b8b7ab10a440b 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
  src/main/resources/scheduler/assets/breadcrumb.html 
b5f82ca120d3b76b63a61628437525cec8870015 
  src/main/resources/scheduler/assets/job.html 
4a00a8863d676f168fbfce9f45ec4bad0244199f 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
b79b07c23e00fab524aef21481070c5f09c9fa18 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 
81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
e969b972806bef9aa67729c8a35283df6145e687 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
2405bb8ad379e355a7987e9bb4163e1693f18777 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
3ba6274b97393ac2228d3eac8ba1615cb57014f8 
  src/test/python/apache/aurora/client/api/test_api.py 
ff1aff2eac391f219bc7c2483a16e35f916a224c 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
6413c0db20db5914c7b1537da2bbc6e110705dc2 

Diff: https://reviews.apache.org/r/31388/diff/


Testing
---


Thanks,

Bill Farner



Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-25 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74092
---


Master (895d03b) is red with this patch.
  ./build-support/jenkins/build.sh

SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/test_admin_util.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/test_maintenance.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/test_admin.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/test_admin_sla.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/admin/util.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/test_transport.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/test_cluster_option.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/test_cluster.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/test_clusters.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/test_pex_version.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/test_shellify.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/test_aurora_job_key.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/test_http_signaler.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/config/test_constraint_parsing.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/config/test_thrift.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/config/test_loader.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/config/test_base.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/test_status_manager.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/test_executor_vars.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/test_executor_base.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/test_thermos_executor.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/test_gc_executor.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/test_thermos_task_runner.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/test_path_detector.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/test_announcer.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/test_kill_manager.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/__init__.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/test_executor_timeout.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/fixtures.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/test_health_checker.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/test_directory_sandbox.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/test_status_checker.py
 Everything Looks Good!
SUCCESS: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/executor/common/test_resource_manager.py
 Everything Looks Good!
SUCCESS: 

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-25 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74102
---


@ReviewBot retry

The last reply was not for the latest diff.

- Bill Farner


On Feb. 25, 2015, 8:58 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31388/
 ---
 
 (Updated Feb. 25, 2015, 8:58 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-1093
 https://issues.apache.org/jira/browse/AURORA-1093
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Update thrift API and internal code to use JobUpdateSummary.key rather than 
 job key and id.
 
 Note: This change will leave the client in a broken state w.r.t. the 
 scheduler.  I will hold commiting this change until i have another review 
 ready to go that updates the client.
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6a00ce2c30ce24851560c4d499c395194dbeed16 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
 8444d225e91c75e9a571049d28af7264b6d2d017 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 6ade817284b4c0607fe1ff09ad61ea47768f7297 
   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
 d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 06de5384182f84f973a28e312c0dc4329f593dad 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 b9dce16fa705fc14b5af394f8edb6301c789aff4 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  56398f33206cfa1fa45601a21760c7e23e2616bf 
   
 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
  d1bd3c975b2057b46597f38555c2a73d14835600 
   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
 b8c919585307e27f154782ee179153165458bed7 
   src/main/python/apache/aurora/client/api/__init__.py 
 07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
   src/main/python/apache/aurora/client/cli/context.py 
 ea64010ab20c1292fb3fd1f5eb71394b7c965743 
   src/main/python/apache/aurora/client/cli/update.py 
 bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
  c08f09a511e1fc631abdae50630b8b7ab10a440b 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
   src/main/resources/scheduler/assets/breadcrumb.html 
 b5f82ca120d3b76b63a61628437525cec8870015 
   src/main/resources/scheduler/assets/job.html 
 4a00a8863d676f168fbfce9f45ec4bad0244199f 
   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
 b79b07c23e00fab524aef21481070c5f09c9fa18 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
  81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
   
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
  e969b972806bef9aa67729c8a35283df6145e687 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
 2405bb8ad379e355a7987e9bb4163e1693f18777 
   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
 3ba6274b97393ac2228d3eac8ba1615cb57014f8 
   src/test/python/apache/aurora/client/api/test_api.py 
 ff1aff2eac391f219bc7c2483a16e35f916a224c 
   src/test/python/apache/aurora/client/cli/test_supdate.py 
 6413c0db20db5914c7b1537da2bbc6e110705dc2 
 
 Diff: https://reviews.apache.org/r/31388/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-25 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74193
---

Ship it!


Ship It!

- Zameer Manji


On Feb. 25, 2015, 5:39 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31388/
 ---
 
 (Updated Feb. 25, 2015, 5:39 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-1093
 https://issues.apache.org/jira/browse/AURORA-1093
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Update thrift API and internal code to use JobUpdateSummary.key rather than 
 job key and id.
 
 Note: This change will leave the client in a broken state w.r.t. the 
 scheduler.  I will hold commiting this change until i have another review 
 ready to go that updates the client.
 
 TODO: Update javascript uses of the API
 https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/controllers.js#L279
 https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/services.js#L174
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6a00ce2c30ce24851560c4d499c395194dbeed16 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
 8444d225e91c75e9a571049d28af7264b6d2d017 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 6ade817284b4c0607fe1ff09ad61ea47768f7297 
   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
 d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 06de5384182f84f973a28e312c0dc4329f593dad 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 b9dce16fa705fc14b5af394f8edb6301c789aff4 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  56398f33206cfa1fa45601a21760c7e23e2616bf 
   
 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
  d1bd3c975b2057b46597f38555c2a73d14835600 
   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
 b8c919585307e27f154782ee179153165458bed7 
   src/main/python/apache/aurora/client/api/__init__.py 
 07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
   src/main/python/apache/aurora/client/cli/context.py 
 ea64010ab20c1292fb3fd1f5eb71394b7c965743 
   src/main/python/apache/aurora/client/cli/update.py 
 bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
  c08f09a511e1fc631abdae50630b8b7ab10a440b 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
   src/main/resources/scheduler/assets/breadcrumb.html 
 b5f82ca120d3b76b63a61628437525cec8870015 
   src/main/resources/scheduler/assets/job.html 
 4a00a8863d676f168fbfce9f45ec4bad0244199f 
   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
 b79b07c23e00fab524aef21481070c5f09c9fa18 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
  81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
   
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
  e969b972806bef9aa67729c8a35283df6145e687 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
 2405bb8ad379e355a7987e9bb4163e1693f18777 
   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
 3ba6274b97393ac2228d3eac8ba1615cb57014f8 
   src/test/python/apache/aurora/client/api/test_api.py 
 ff1aff2eac391f219bc7c2483a16e35f916a224c 
   src/test/python/apache/aurora/client/cli/test_status.py 
 1f39aa1c50a41e174804751b4cce25b96b6aebed 
   src/test/python/apache/aurora/client/cli/test_supdate.py 
 6413c0db20db5914c7b1537da2bbc6e110705dc2 
 
 Diff: https://reviews.apache.org/r/31388/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-25 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74190
---

Ship it!


Master (9442e08) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Feb. 26, 2015, 1:39 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31388/
 ---
 
 (Updated Feb. 26, 2015, 1:39 a.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-1093
 https://issues.apache.org/jira/browse/AURORA-1093
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Update thrift API and internal code to use JobUpdateSummary.key rather than 
 job key and id.
 
 Note: This change will leave the client in a broken state w.r.t. the 
 scheduler.  I will hold commiting this change until i have another review 
 ready to go that updates the client.
 
 TODO: Update javascript uses of the API
 https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/controllers.js#L279
 https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/services.js#L174
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6a00ce2c30ce24851560c4d499c395194dbeed16 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
 8444d225e91c75e9a571049d28af7264b6d2d017 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 6ade817284b4c0607fe1ff09ad61ea47768f7297 
   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
 d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 06de5384182f84f973a28e312c0dc4329f593dad 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 b9dce16fa705fc14b5af394f8edb6301c789aff4 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  56398f33206cfa1fa45601a21760c7e23e2616bf 
   
 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
  d1bd3c975b2057b46597f38555c2a73d14835600 
   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
 b8c919585307e27f154782ee179153165458bed7 
   src/main/python/apache/aurora/client/api/__init__.py 
 07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
   src/main/python/apache/aurora/client/cli/context.py 
 ea64010ab20c1292fb3fd1f5eb71394b7c965743 
   src/main/python/apache/aurora/client/cli/update.py 
 bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
  c08f09a511e1fc631abdae50630b8b7ab10a440b 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
   src/main/resources/scheduler/assets/breadcrumb.html 
 b5f82ca120d3b76b63a61628437525cec8870015 
   src/main/resources/scheduler/assets/job.html 
 4a00a8863d676f168fbfce9f45ec4bad0244199f 
   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
 b79b07c23e00fab524aef21481070c5f09c9fa18 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
  81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
   
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
  e969b972806bef9aa67729c8a35283df6145e687 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
 2405bb8ad379e355a7987e9bb4163e1693f18777 
   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
 3ba6274b97393ac2228d3eac8ba1615cb57014f8 
   src/test/python/apache/aurora/client/api/test_api.py 
 ff1aff2eac391f219bc7c2483a16e35f916a224c 
   src/test/python/apache/aurora/client/cli/test_status.py 
 1f39aa1c50a41e174804751b4cce25b96b6aebed 
   src/test/python/apache/aurora/client/cli/test_supdate.py 
 6413c0db20db5914c7b1537da2bbc6e110705dc2 
 
 Diff: https://reviews.apache.org/r/31388/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-25 Thread Maxim Khutornenko


 On Feb. 25, 2015, 11:01 p.m., Maxim Khutornenko wrote:
  This does not seem to address js invocations of the job update APIs. E.g:
  
  https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/controllers.js#L279
  https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/services.js#L174
 
 Bill Farner wrote:
 Thanks.  Mind doing a review in parallel with me addressing those?

Rest lgtm.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74129
---


On Feb. 25, 2015, 11:04 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31388/
 ---
 
 (Updated Feb. 25, 2015, 11:04 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-1093
 https://issues.apache.org/jira/browse/AURORA-1093
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Update thrift API and internal code to use JobUpdateSummary.key rather than 
 job key and id.
 
 Note: This change will leave the client in a broken state w.r.t. the 
 scheduler.  I will hold commiting this change until i have another review 
 ready to go that updates the client.
 
 TODO: Update javascript uses of the API
 https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/controllers.js#L279
 https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/services.js#L174
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6a00ce2c30ce24851560c4d499c395194dbeed16 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
 8444d225e91c75e9a571049d28af7264b6d2d017 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 6ade817284b4c0607fe1ff09ad61ea47768f7297 
   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
 d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 06de5384182f84f973a28e312c0dc4329f593dad 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 b9dce16fa705fc14b5af394f8edb6301c789aff4 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  56398f33206cfa1fa45601a21760c7e23e2616bf 
   
 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
  d1bd3c975b2057b46597f38555c2a73d14835600 
   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
 b8c919585307e27f154782ee179153165458bed7 
   src/main/python/apache/aurora/client/api/__init__.py 
 07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
   src/main/python/apache/aurora/client/cli/context.py 
 ea64010ab20c1292fb3fd1f5eb71394b7c965743 
   src/main/python/apache/aurora/client/cli/update.py 
 bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
  c08f09a511e1fc631abdae50630b8b7ab10a440b 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
   src/main/resources/scheduler/assets/breadcrumb.html 
 b5f82ca120d3b76b63a61628437525cec8870015 
   src/main/resources/scheduler/assets/job.html 
 4a00a8863d676f168fbfce9f45ec4bad0244199f 
   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
 b79b07c23e00fab524aef21481070c5f09c9fa18 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
  81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
   
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
  e969b972806bef9aa67729c8a35283df6145e687 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
 2405bb8ad379e355a7987e9bb4163e1693f18777 
   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
 3ba6274b97393ac2228d3eac8ba1615cb57014f8 
   src/test/python/apache/aurora/client/api/test_api.py 
 ff1aff2eac391f219bc7c2483a16e35f916a224c 
   src/test/python/apache/aurora/client/cli/test_supdate.py 
 6413c0db20db5914c7b1537da2bbc6e110705dc2 
 
 Diff: https://reviews.apache.org/r/31388/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-25 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74142
---



src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java
https://reviews.apache.org/r/31388/#comment120669

Will this be addresed as apart of this effort?



src/main/python/apache/aurora/client/cli/update.py
https://reviews.apache.org/r/31388/#comment120671

I think the code is authored in this way to take advantage of the insert 
order of the dict. I think this was desired so the serialized string will have 
keys in certain order.



src/test/python/apache/aurora/client/cli/test_supdate.py
https://reviews.apache.org/r/31388/#comment120673

Instead of this todo, can you please replace the equality check with 
json.loads(mock_context.get_out_str()) == json.loads(fixture)

Even nicer would be to make the LHS a python dict to compare against the 
json.loads.


- Zameer Manji


On Feb. 25, 2015, 3:04 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31388/
 ---
 
 (Updated Feb. 25, 2015, 3:04 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-1093
 https://issues.apache.org/jira/browse/AURORA-1093
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Update thrift API and internal code to use JobUpdateSummary.key rather than 
 job key and id.
 
 Note: This change will leave the client in a broken state w.r.t. the 
 scheduler.  I will hold commiting this change until i have another review 
 ready to go that updates the client.
 
 TODO: Update javascript uses of the API
 https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/controllers.js#L279
 https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/services.js#L174
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6a00ce2c30ce24851560c4d499c395194dbeed16 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
 8444d225e91c75e9a571049d28af7264b6d2d017 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 6ade817284b4c0607fe1ff09ad61ea47768f7297 
   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
 d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 06de5384182f84f973a28e312c0dc4329f593dad 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 b9dce16fa705fc14b5af394f8edb6301c789aff4 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  56398f33206cfa1fa45601a21760c7e23e2616bf 
   
 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
  d1bd3c975b2057b46597f38555c2a73d14835600 
   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
 b8c919585307e27f154782ee179153165458bed7 
   src/main/python/apache/aurora/client/api/__init__.py 
 07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
   src/main/python/apache/aurora/client/cli/context.py 
 ea64010ab20c1292fb3fd1f5eb71394b7c965743 
   src/main/python/apache/aurora/client/cli/update.py 
 bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
  c08f09a511e1fc631abdae50630b8b7ab10a440b 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
   src/main/resources/scheduler/assets/breadcrumb.html 
 b5f82ca120d3b76b63a61628437525cec8870015 
   src/main/resources/scheduler/assets/job.html 
 4a00a8863d676f168fbfce9f45ec4bad0244199f 
   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
 b79b07c23e00fab524aef21481070c5f09c9fa18 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
  81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
   
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
  e969b972806bef9aa67729c8a35283df6145e687 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
 2405bb8ad379e355a7987e9bb4163e1693f18777 
   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
 3ba6274b97393ac2228d3eac8ba1615cb57014f8 
   src/test/python/apache/aurora/client/api/test_api.py 
 ff1aff2eac391f219bc7c2483a16e35f916a224c 
   src/test/python/apache/aurora/client/cli/test_supdate.py 
 

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-25 Thread Bill Farner


 On Feb. 25, 2015, 11:27 p.m., Zameer Manji wrote:
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java,
   line 219
  https://reviews.apache.org/r/31388/diff/5/?file=876605#file876605line219
 
  Will this be addresed as apart of this effort?

It actually is, this is a rogue TODO.  Thanks, removed.


 On Feb. 25, 2015, 11:27 p.m., Zameer Manji wrote:
  src/main/python/apache/aurora/client/cli/update.py, line 269
  https://reviews.apache.org/r/31388/diff/5/?file=876612#file876612line269
 
  I think the code is authored in this way to take advantage of the 
  insert order of the dict. I think this was desired so the serialized string 
  will have keys in certain order.

Thanks.  Along with addressing your comment below, i have removed the TODO and 
comment.


 On Feb. 25, 2015, 11:27 p.m., Zameer Manji wrote:
  src/test/python/apache/aurora/client/cli/test_supdate.py, line 359
  https://reviews.apache.org/r/31388/diff/5/?file=876624#file876624line359
 
  Instead of this todo, can you please replace the equality check with 
  json.loads(mock_context.get_out_str()) == json.loads(fixture)
  
  Even nicer would be to make the LHS a python dict to compare against 
  the json.loads.

Thanks for the nudge, this was straightforward and did not result in a large 
code delta at all.  Fixed this and other similar tests.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74142
---


On Feb. 25, 2015, 11:04 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31388/
 ---
 
 (Updated Feb. 25, 2015, 11:04 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-1093
 https://issues.apache.org/jira/browse/AURORA-1093
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Update thrift API and internal code to use JobUpdateSummary.key rather than 
 job key and id.
 
 Note: This change will leave the client in a broken state w.r.t. the 
 scheduler.  I will hold commiting this change until i have another review 
 ready to go that updates the client.
 
 TODO: Update javascript uses of the API
 https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/controllers.js#L279
 https://github.com/apache/incubator-aurora/blob/master/src/main/resources/scheduler/assets/js/services.js#L174
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6a00ce2c30ce24851560c4d499c395194dbeed16 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
 8444d225e91c75e9a571049d28af7264b6d2d017 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 6ade817284b4c0607fe1ff09ad61ea47768f7297 
   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
 d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 06de5384182f84f973a28e312c0dc4329f593dad 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 b9dce16fa705fc14b5af394f8edb6301c789aff4 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  56398f33206cfa1fa45601a21760c7e23e2616bf 
   
 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
  d1bd3c975b2057b46597f38555c2a73d14835600 
   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
 b8c919585307e27f154782ee179153165458bed7 
   src/main/python/apache/aurora/client/api/__init__.py 
 07d1b1c5405b1329a15e8900b07c2a3dba6c592f 
   src/main/python/apache/aurora/client/cli/context.py 
 ea64010ab20c1292fb3fd1f5eb71394b7c965743 
   src/main/python/apache/aurora/client/cli/update.py 
 bfa7a27c4e283b981a4ce37d382aa117a0074ee1 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
  c08f09a511e1fc631abdae50630b8b7ab10a440b 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
   src/main/resources/scheduler/assets/breadcrumb.html 
 b5f82ca120d3b76b63a61628437525cec8870015 
   src/main/resources/scheduler/assets/job.html 
 4a00a8863d676f168fbfce9f45ec4bad0244199f 
   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
 b79b07c23e00fab524aef21481070c5f09c9fa18 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
  81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
   
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
  e969b972806bef9aa67729c8a35283df6145e687 

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-24 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/
---

(Updated Feb. 25, 2015, midnight)


Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Bugs: AURORA-1093
https://issues.apache.org/jira/browse/AURORA-1093


Repository: aurora


Description (updated)
---

Update thrift API and internal code to use JobUpdateSummary.key rather than job 
key and id.

Note: This change will leave the client in a broken state w.r.t. the scheduler. 
 I will hold commiting this change until i have another review ready to go that 
updates the client.


Diffs
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
6a00ce2c30ce24851560c4d499c395194dbeed16 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
bb727214b19ec6074d04eacdd997832e50b756f9 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
fc8e2f4e75a33789b28588204cbbfd56b5d049a4 
  src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
  src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
72b9895214aa372c4fd75e5bb6dee8485b3594f6 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
34763851cd59996559f160c57b00d23de3dc49b4 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
d24b31bf1034c69ac8a9891aaa9b8653674ce0ce 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
d1bd3c975b2057b46597f38555c2a73d14835600 
  src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
b8c919585307e27f154782ee179153165458bed7 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
 c08f09a511e1fc631abdae50630b8b7ab10a440b 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
eac2033cffc09f6a9e867a2499569b51d94f0705 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 
81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
daaa759ca5c2cda26802187698f0a33ceb0dd39f 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 5b0565e6477644047a237b8d185027a6fdc5c6a5 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
2405bb8ad379e355a7987e9bb4163e1693f18777 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
3ba6274b97393ac2228d3eac8ba1615cb57014f8 

Diff: https://reviews.apache.org/r/31388/diff/


Testing
---


Thanks,

Bill Farner



Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-24 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review73936
---


This patch does not apply cleanly on master (cd681d9), do you need to rebase?

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Feb. 24, 2015, 11:47 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31388/
 ---
 
 (Updated Feb. 24, 2015, 11:47 p.m.)
 
 
 Review request for Aurora, Maxim Khutornenko and Zameer Manji.
 
 
 Bugs: AURORA-1093
 https://issues.apache.org/jira/browse/AURORA-1093
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Update thrift API and internal code to use JobUpdateSummary.key rather than 
 job key and id.
 
 
 Diffs
 -
 
   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
 6a00ce2c30ce24851560c4d499c395194dbeed16 
   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
 bb727214b19ec6074d04eacdd997832e50b756f9 
   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
 fc8e2f4e75a33789b28588204cbbfd56b5d049a4 
   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
 4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
 d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
   
 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
 72b9895214aa372c4fd75e5bb6dee8485b3594f6 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 34763851cd59996559f160c57b00d23de3dc49b4 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  d24b31bf1034c69ac8a9891aaa9b8653674ce0ce 
   
 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
  d1bd3c975b2057b46597f38555c2a73d14835600 
   src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
 b8c919585307e27f154782ee179153165458bed7 
   
 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
  c08f09a511e1fc631abdae50630b8b7ab10a440b 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
 eac2033cffc09f6a9e867a2499569b51d94f0705 
   
 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
  81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
   
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
  daaa759ca5c2cda26802187698f0a33ceb0dd39f 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  5b0565e6477644047a237b8d185027a6fdc5c6a5 
   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
 2405bb8ad379e355a7987e9bb4163e1693f18777 
   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
 3ba6274b97393ac2228d3eac8ba1615cb57014f8 
 
 Diff: https://reviews.apache.org/r/31388/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-24 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/
---

(Updated Feb. 25, 2015, 12:07 a.m.)


Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Changes
---

Rebase on master.


Bugs: AURORA-1093
https://issues.apache.org/jira/browse/AURORA-1093


Repository: aurora


Description
---

Update thrift API and internal code to use JobUpdateSummary.key rather than job 
key and id.

Note: This change will leave the client in a broken state w.r.t. the scheduler. 
 I will hold commiting this change until i have another review ready to go that 
updates the client.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
6a00ce2c30ce24851560c4d499c395194dbeed16 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
199dc1123cd1966b1c8075e7a486efdf627c45f3 
  src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
fc8e2f4e75a33789b28588204cbbfd56b5d049a4 
  src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
4b8b00cc74d81aa5cc772a7b4e077da6a4ed2a83 
  src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
d52c15e0a7083e0d02bbf6dbaa58d8956bc5dd6f 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
72b9895214aa372c4fd75e5bb6dee8485b3594f6 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
b9dce16fa705fc14b5af394f8edb6301c789aff4 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
059626f742ce806fded754ef04a83e2eb5405ff2 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
d1bd3c975b2057b46597f38555c2a73d14835600 
  src/main/java/org/apache/aurora/scheduler/updater/Updates.java 
b8c919585307e27f154782ee179153165458bed7 
  
src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
 c08f09a511e1fc631abdae50630b8b7ab10a440b 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
e6184dd2de0e86849d811ec05c168bbb4db8e8cd 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
b79b07c23e00fab524aef21481070c5f09c9fa18 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 
81c8be7685854c47ed4a7c6deeffb6a0b80023ab 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
e969b972806bef9aa67729c8a35283df6145e687 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 d36418807ace4f61e8709a2827cea0e7bb8ac6b7 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
2405bb8ad379e355a7987e9bb4163e1693f18777 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
3ba6274b97393ac2228d3eac8ba1615cb57014f8 

Diff: https://reviews.apache.org/r/31388/diff/


Testing
---


Thanks,

Bill Farner