Re: Review Request 31652: Returning pending reason for all tasks in a group

2015-03-05 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31652/#review75413
---

Ship it!


Master (70494a1) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On March 5, 2015, 6:48 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31652/
 ---
 
 (Updated March 5, 2015, 6:48 p.m.)
 
 
 Review request for Aurora, Bill Farner and Zameer Manji.
 
 
 Bugs: AURORA-911
 https://issues.apache.org/jira/browse/AURORA-911
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Modifying `Vetoed` event to broadcast `TaskGroupKey` instead of task ID and 
 storing veto reasons by TaskGroupKey in NearestFit.
 
 Depends on https://reviews.apache.org/r/31646/.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
  edaf2f4f845544c13b2fb9bc77c34f6e6d96fb48 
   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
 c103472b9404df1c690b3a6019d64d42e15f2fed 
   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
 c3097e49c0f6588ea765aa4fab69dd35e3d90e8b 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 53582c63ddee23e643bd4654cad2bef75dfba36d 
   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
 13520eb5846022ed0b43b402096fe02565103aa9 
   
 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
  ab7817f929bbcc96a6046043ea17921a388fdb9f 
   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
 78a236c0f9074692b67ce18e6e03f18fe4529e02 
   
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
  ce5a62650cebab9a53743460f5a5119f62efec1c 
 
 Diff: https://reviews.apache.org/r/31652/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 31652: Returning pending reason for all tasks in a group

2015-03-05 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31652/
---

(Updated March 5, 2015, 6:48 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Bill's comments.


Bugs: AURORA-911
https://issues.apache.org/jira/browse/AURORA-911


Repository: aurora


Description
---

Modifying `Vetoed` event to broadcast `TaskGroupKey` instead of task ID and 
storing veto reasons by TaskGroupKey in NearestFit.

Depends on https://reviews.apache.org/r/31646/.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 
edaf2f4f845544c13b2fb9bc77c34f6e6d96fb48 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
c103472b9404df1c690b3a6019d64d42e15f2fed 
  src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
c3097e49c0f6588ea765aa4fab69dd35e3d90e8b 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
53582c63ddee23e643bd4654cad2bef75dfba36d 
  src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
13520eb5846022ed0b43b402096fe02565103aa9 
  
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
 ab7817f929bbcc96a6046043ea17921a388fdb9f 
  src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
78a236c0f9074692b67ce18e6e03f18fe4529e02 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
ce5a62650cebab9a53743460f5a5119f62efec1c 

Diff: https://reviews.apache.org/r/31652/diff/


Testing
---

./gradlew -Pq build


Thanks,

Maxim Khutornenko



Re: Review Request 31652: Returning pending reason for all tasks in a group

2015-03-05 Thread Maxim Khutornenko


 On March 3, 2015, 11:56 p.m., Bill Farner wrote:
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java, line 237
  https://reviews.apache.org/r/31652/diff/1/?file=882474#file882474line237
 
  s/taskId/groupKey/

Good catch, fixed.


 On March 3, 2015, 11:56 p.m., Bill Farner wrote:
  src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java, line 57
  https://reviews.apache.org/r/31652/diff/1/?file=882475#file882475line57
 
  Should this cache be renamed?

No preference here, renamed.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31652/#review75096
---


On March 3, 2015, 12:58 a.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31652/
 ---
 
 (Updated March 3, 2015, 12:58 a.m.)
 
 
 Review request for Aurora, Bill Farner and Zameer Manji.
 
 
 Bugs: AURORA-911
 https://issues.apache.org/jira/browse/AURORA-911
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Modifying `Vetoed` event to broadcast `TaskGroupKey` instead of task ID and 
 storing veto reasons by TaskGroupKey in NearestFit.
 
 Depends on https://reviews.apache.org/r/31646/.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
  edaf2f4f845544c13b2fb9bc77c34f6e6d96fb48 
   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
 c103472b9404df1c690b3a6019d64d42e15f2fed 
   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
 c3097e49c0f6588ea765aa4fab69dd35e3d90e8b 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 53582c63ddee23e643bd4654cad2bef75dfba36d 
   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
 13520eb5846022ed0b43b402096fe02565103aa9 
   
 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
  ab7817f929bbcc96a6046043ea17921a388fdb9f 
   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
 78a236c0f9074692b67ce18e6e03f18fe4529e02 
   
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
  ce5a62650cebab9a53743460f5a5119f62efec1c 
 
 Diff: https://reviews.apache.org/r/31652/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 31652: Returning pending reason for all tasks in a group

2015-03-03 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31652/#review75096
---

Ship it!


Nice!


src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java
https://reviews.apache.org/r/31652/#comment122032

s/taskId/groupKey/



src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java
https://reviews.apache.org/r/31652/#comment122034

Should this cache be renamed?


- Bill Farner


On March 3, 2015, 12:58 a.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31652/
 ---
 
 (Updated March 3, 2015, 12:58 a.m.)
 
 
 Review request for Aurora, Bill Farner and Zameer Manji.
 
 
 Bugs: AURORA-911
 https://issues.apache.org/jira/browse/AURORA-911
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Modifying `Vetoed` event to broadcast `TaskGroupKey` instead of task ID and 
 storing veto reasons by TaskGroupKey in NearestFit.
 
 Depends on https://reviews.apache.org/r/31646/.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
  edaf2f4f845544c13b2fb9bc77c34f6e6d96fb48 
   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
 c103472b9404df1c690b3a6019d64d42e15f2fed 
   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
 c3097e49c0f6588ea765aa4fab69dd35e3d90e8b 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 53582c63ddee23e643bd4654cad2bef75dfba36d 
   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
 13520eb5846022ed0b43b402096fe02565103aa9 
   
 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
  ab7817f929bbcc96a6046043ea17921a388fdb9f 
   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
 78a236c0f9074692b67ce18e6e03f18fe4529e02 
   
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
  ce5a62650cebab9a53743460f5a5119f62efec1c 
 
 Diff: https://reviews.apache.org/r/31652/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 31652: Returning pending reason for all tasks in a group

2015-03-03 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31652/#review75099
---

Ship it!


Ship It!

- Zameer Manji


On March 2, 2015, 4:58 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31652/
 ---
 
 (Updated March 2, 2015, 4:58 p.m.)
 
 
 Review request for Aurora, Bill Farner and Zameer Manji.
 
 
 Bugs: AURORA-911
 https://issues.apache.org/jira/browse/AURORA-911
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Modifying `Vetoed` event to broadcast `TaskGroupKey` instead of task ID and 
 storing veto reasons by TaskGroupKey in NearestFit.
 
 Depends on https://reviews.apache.org/r/31646/.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
  edaf2f4f845544c13b2fb9bc77c34f6e6d96fb48 
   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
 c103472b9404df1c690b3a6019d64d42e15f2fed 
   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
 c3097e49c0f6588ea765aa4fab69dd35e3d90e8b 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 53582c63ddee23e643bd4654cad2bef75dfba36d 
   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
 13520eb5846022ed0b43b402096fe02565103aa9 
   
 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
  ab7817f929bbcc96a6046043ea17921a388fdb9f 
   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
 78a236c0f9074692b67ce18e6e03f18fe4529e02 
   
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
  ce5a62650cebab9a53743460f5a5119f62efec1c 
 
 Diff: https://reviews.apache.org/r/31652/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 31652: Returning pending reason for all tasks in a group

2015-03-02 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31652/
---

(Updated March 3, 2015, 12:58 a.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
---

Adding ticket number.


Bugs: AURORA-911
https://issues.apache.org/jira/browse/AURORA-911


Repository: aurora


Description
---

Modifying `Vetoed` event to broadcast `TaskGroupKey` instead of task ID and 
storing veto reasons by TaskGroupKey in NearestFit.

Depends on https://reviews.apache.org/r/31646/.


Diffs
-

  
src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 
edaf2f4f845544c13b2fb9bc77c34f6e6d96fb48 
  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
c103472b9404df1c690b3a6019d64d42e15f2fed 
  src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
c3097e49c0f6588ea765aa4fab69dd35e3d90e8b 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
53582c63ddee23e643bd4654cad2bef75dfba36d 
  src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
13520eb5846022ed0b43b402096fe02565103aa9 
  
src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
 ab7817f929bbcc96a6046043ea17921a388fdb9f 
  src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
78a236c0f9074692b67ce18e6e03f18fe4529e02 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
ce5a62650cebab9a53743460f5a5119f62efec1c 

Diff: https://reviews.apache.org/r/31652/diff/


Testing
---

./gradlew -Pq build


Thanks,

Maxim Khutornenko



Re: Review Request 31652: Returning pending reason for all tasks in a group

2015-03-02 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31652/#review74865
---


Master (4cca6a6) is red with this patch.
  ./build-support/jenkins/build.sh

  ^
  symbol: class TaskGroupKey
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java:97:
 error: cannot find symbol
new FunctionITaskConfig, TaskGroupKey() {
  ^
  symbol:   class TaskGroupKey
  location: class NearestFit
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java:99:
 error: cannot find symbol
  public TaskGroupKey apply(ITaskConfig task) {
 ^
  symbol: class TaskGroupKey
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java:100:
 error: cannot find symbol
return TaskGroupKey.from(task);
   ^
  symbol: variable TaskGroupKey
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java:115:
 error: cannot find symbol
  
fitByTask.invalidate(TaskGroupKey.from(event.getTask().getAssignedTask().getTask()));
   ^
  symbol:   variable TaskGroupKey
  location: class NearestFit
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java:61:
 error: cannot find symbol
  eventSink.post(new Vetoed(TaskGroupKey.from(request.getTask()), vetoes));
^
  symbol:   variable TaskGroupKey
  location: class NotifyingSchedulingFilter
18 errors
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
 Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 1 mins 20.724 secs


I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On March 3, 2015, 12:58 a.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/31652/
 ---
 
 (Updated March 3, 2015, 12:58 a.m.)
 
 
 Review request for Aurora, Bill Farner and Zameer Manji.
 
 
 Bugs: AURORA-911
 https://issues.apache.org/jira/browse/AURORA-911
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Modifying `Vetoed` event to broadcast `TaskGroupKey` instead of task ID and 
 storing veto reasons by TaskGroupKey in NearestFit.
 
 Depends on https://reviews.apache.org/r/31646/.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java
  edaf2f4f845544c13b2fb9bc77c34f6e6d96fb48 
   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
 c103472b9404df1c690b3a6019d64d42e15f2fed 
   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
 c3097e49c0f6588ea765aa4fab69dd35e3d90e8b 
   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
 53582c63ddee23e643bd4654cad2bef75dfba36d 
   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 
 13520eb5846022ed0b43b402096fe02565103aa9 
   
 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java
  ab7817f929bbcc96a6046043ea17921a388fdb9f 
   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
 78a236c0f9074692b67ce18e6e03f18fe4529e02 
   
 src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
  ce5a62650cebab9a53743460f5a5119f62efec1c 
 
 Diff: https://reviews.apache.org/r/31652/diff/
 
 
 Testing
 ---
 
 ./gradlew -Pq build
 
 
 Thanks,
 
 Maxim Khutornenko