Re: Review Request 31754: Break out API servlet configuration into its own module.

2015-03-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31754/ --- (Updated March 5, 2015, 12:03 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 31754: Break out API servlet configuration into its own module.

2015-03-05 Thread Bill Farner
On March 5, 2015, 3:18 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/app/AppModule.java, line 141 https://reviews.apache.org/r/31754/diff/1/?file=885268#file885268line141 There seems to be implementation detail leaking here. Can you make JettyServerModule

Re: Review Request 31754: Break out API servlet configuration into its own module.

2015-03-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31754/#review75389 --- Ship it! Ship It! - Bill Farner On March 5, 2015, 8:03 p.m.,

Re: Review Request 31754: Break out API servlet configuration into its own module.

2015-03-05 Thread Kevin Sweeney
On March 5, 2015, 10:40 a.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/SchedulerAPIServlet.java, line 25 https://reviews.apache.org/r/31754/diff/1/?file=885270#file885270line25 Any reason not to call this `ApiThriftServlet` to be more explicit? Done.

Re: Review Request 31754: Break out API servlet configuration into its own module.

2015-03-05 Thread Kevin Sweeney
On March 4, 2015, 7:18 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/app/AppModule.java, line 141 https://reviews.apache.org/r/31754/diff/1/?file=885268#file885268line141 There seems to be implementation detail leaking here. Can you make JettyServerModule

Re: Review Request 31754: Break out API servlet configuration into its own module.

2015-03-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31754/ --- (Updated March 5, 2015, 11:52 a.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 31754: Break out API servlet configuration into its own module.

2015-03-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31754/#review75404 --- This patch does not apply cleanly on master (70494a1), do you need

Re: Review Request 31754: Break out API servlet configuration into its own module.

2015-03-05 Thread Kevin Sweeney
On March 4, 2015, 7:18 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/app/AppModule.java, line 141 https://reviews.apache.org/r/31754/diff/1/?file=885268#file885268line141 There seems to be implementation detail leaking here. Can you make JettyServerModule

Re: Review Request 31754: Break out API servlet configuration into its own module.

2015-03-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31754/#review75275 --- Looks like my IDE was a little overzealous applying a different