Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

2015-03-06 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31779/#review75602
---

Ship it!


Master (5aa130e) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 7, 2015, 1:10 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31779/
> ---
> 
> (Updated March 7, 2015, 1:10 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1093
> https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This was overlooked in AURORA-1093.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 1cd21e598db0c0d51cfed293e5e0fc51d84e0bb0 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  8ec5f9a3810b4deae981988487c6a46a20db72a2 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 5989a62f1651aede6e2372ad3f519a9a947470de 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  acdade3dca807a221b4da975d0310c91884ee752 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 
> 9b15b2d12eaea00b3c734bc61ad74b5887d31a5f 
>   src/main/python/apache/aurora/client/api/__init__.py 
> c07122744e89fe61dbe4bea0c14400425983b2ef 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2e996775c7be460555b0a59b98441e01513f69c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> a4890057b7d258926bc3dfb84fd1248e68051f31 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  824740856236976984d2114ec6a6aea989a87d1e 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 459f745cec1f85ece41376cade39c09254b50013 
>   
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java
>  7ebc4d4642df107356ffbafabc25b560409022d7 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e24d6bde5f3479a75522e825cce4ec6c30c117aa 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 0d552e8b9f9be300fc28a3f52aabe19e5a51b252 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> a65aab71ee8ce19dc2c05ea230258084d6f55727 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> c8d217da005afe7f65a8215882a5a119d4899b98 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> b596babc3c6877f68094943126b8cd49be3fc635 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 93a5532dc6f7aee2c40bc86385a630b9a1b6f528 
>   src/test/python/apache/aurora/client/cli/util.py 
> 6d3cc51f50b417405549c254531c854565a54949 
> 
> Diff: https://reviews.apache.org/r/31779/diff/
> 
> 
> Testing
> ---
> 
> Normal test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

2015-03-06 Thread Bill Farner 


> On March 6, 2015, 11:11 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 54
> > 
> >
> > Is this needed?

Thanks, it's not - this was me trying to diagnose some strange behavior, 
resulting in AURORA-1176


> On March 6, 2015, 11:11 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/__init__.py, line 328
> > 
> >
> > When should this block be removed?

I have elaborated on the comment, and amended AURORA-1176 to fold it in.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31779/#review75563
---


On March 6, 2015, 10:38 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31779/
> ---
> 
> (Updated March 6, 2015, 10:38 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1093
> https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This was overlooked in AURORA-1093.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 1cd21e598db0c0d51cfed293e5e0fc51d84e0bb0 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  8ec5f9a3810b4deae981988487c6a46a20db72a2 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 5989a62f1651aede6e2372ad3f519a9a947470de 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  acdade3dca807a221b4da975d0310c91884ee752 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 
> 9b15b2d12eaea00b3c734bc61ad74b5887d31a5f 
>   src/main/python/apache/aurora/client/api/__init__.py 
> c07122744e89fe61dbe4bea0c14400425983b2ef 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2e996775c7be460555b0a59b98441e01513f69c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> a4890057b7d258926bc3dfb84fd1248e68051f31 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  824740856236976984d2114ec6a6aea989a87d1e 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 459f745cec1f85ece41376cade39c09254b50013 
>   
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java
>  7ebc4d4642df107356ffbafabc25b560409022d7 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e24d6bde5f3479a75522e825cce4ec6c30c117aa 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 0d552e8b9f9be300fc28a3f52aabe19e5a51b252 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> a65aab71ee8ce19dc2c05ea230258084d6f55727 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> c8d217da005afe7f65a8215882a5a119d4899b98 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> b596babc3c6877f68094943126b8cd49be3fc635 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 93a5532dc6f7aee2c40bc86385a630b9a1b6f528 
>   src/test/python/apache/aurora/client/cli/util.py 
> 6d3cc51f50b417405549c254531c854565a54949 
> 
> Diff: https://reviews.apache.org/r/31779/diff/
> 
> 
> Testing
> ---
> 
> Normal test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

2015-03-06 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31779/
---

(Updated March 7, 2015, 1:10 a.m.)


Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Bugs: AURORA-1093
https://issues.apache.org/jira/browse/AURORA-1093


Repository: aurora


Description
---

This was overlooked in AURORA-1093.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
1cd21e598db0c0d51cfed293e5e0fc51d84e0bb0 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
8ec5f9a3810b4deae981988487c6a46a20db72a2 
  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
5989a62f1651aede6e2372ad3f519a9a947470de 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
acdade3dca807a221b4da975d0310c91884ee752 
  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 
9b15b2d12eaea00b3c734bc61ad74b5887d31a5f 
  src/main/python/apache/aurora/client/api/__init__.py 
c07122744e89fe61dbe4bea0c14400425983b2ef 
  src/main/python/apache/aurora/client/cli/__init__.py 
2e996775c7be460555b0a59b98441e01513f69c4 
  src/main/python/apache/aurora/client/cli/update.py 
a4890057b7d258926bc3dfb84fd1248e68051f31 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 824740856236976984d2114ec6a6aea989a87d1e 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
459f745cec1f85ece41376cade39c09254b50013 
  
src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java
 7ebc4d4642df107356ffbafabc25b560409022d7 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
e24d6bde5f3479a75522e825cce4ec6c30c117aa 
  src/test/python/apache/aurora/client/api/test_api.py 
0d552e8b9f9be300fc28a3f52aabe19e5a51b252 
  src/test/python/apache/aurora/client/cli/test_create.py 
a65aab71ee8ce19dc2c05ea230258084d6f55727 
  src/test/python/apache/aurora/client/cli/test_quota.py 
c8d217da005afe7f65a8215882a5a119d4899b98 
  src/test/python/apache/aurora/client/cli/test_restart.py 
b596babc3c6877f68094943126b8cd49be3fc635 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
93a5532dc6f7aee2c40bc86385a630b9a1b6f528 
  src/test/python/apache/aurora/client/cli/util.py 
6d3cc51f50b417405549c254531c854565a54949 

Diff: https://reviews.apache.org/r/31779/diff/


Testing
---

Normal test suite + end-to-end tests.


Thanks,

Bill Farner

Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

2015-03-06 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31779/#review75563
---

Ship it!



src/main/python/apache/aurora/client/cli/update.py


Is this needed?



src/main/python/apache/aurora/client/cli/__init__.py


When should this block be removed?


- Joshua Cohen


On March 6, 2015, 10:38 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31779/
> ---
> 
> (Updated March 6, 2015, 10:38 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1093
> https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This was overlooked in AURORA-1093.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 1cd21e598db0c0d51cfed293e5e0fc51d84e0bb0 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  8ec5f9a3810b4deae981988487c6a46a20db72a2 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 5989a62f1651aede6e2372ad3f519a9a947470de 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  acdade3dca807a221b4da975d0310c91884ee752 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 
> 9b15b2d12eaea00b3c734bc61ad74b5887d31a5f 
>   src/main/python/apache/aurora/client/api/__init__.py 
> c07122744e89fe61dbe4bea0c14400425983b2ef 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2e996775c7be460555b0a59b98441e01513f69c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> a4890057b7d258926bc3dfb84fd1248e68051f31 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  824740856236976984d2114ec6a6aea989a87d1e 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 459f745cec1f85ece41376cade39c09254b50013 
>   
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java
>  7ebc4d4642df107356ffbafabc25b560409022d7 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e24d6bde5f3479a75522e825cce4ec6c30c117aa 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 0d552e8b9f9be300fc28a3f52aabe19e5a51b252 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> a65aab71ee8ce19dc2c05ea230258084d6f55727 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> c8d217da005afe7f65a8215882a5a119d4899b98 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> b596babc3c6877f68094943126b8cd49be3fc635 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 93a5532dc6f7aee2c40bc86385a630b9a1b6f528 
>   src/test/python/apache/aurora/client/cli/util.py 
> 6d3cc51f50b417405549c254531c854565a54949 
> 
> Diff: https://reviews.apache.org/r/31779/diff/
> 
> 
> Testing
> ---
> 
> Normal test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

2015-03-06 Thread Joshua Cohen 


> On March 5, 2015, 11:37 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 66
> > 
> >
> > Would it make more sense to have this be a context manager or a 
> > decorator to reduce (further) the boilerplate?
> 
> Bill Farner wrote:
> I'm not sure what the patterns are for use of context managers, but this 
> would seem odd since there's no 'cleanup'.  I suppose i'm ambivalent here, 
> and opted for what is (to me) simpler code.  Feel free to push if you feel 
> strongly.

Yeah, I was a little bit hand-wavy myself, because I'm not sure what the 
"pythonic" solution is. It's probably a decorator? I don't feel super strongly 
about it though.


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31779/#review75416
---


On March 6, 2015, 10:38 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31779/
> ---
> 
> (Updated March 6, 2015, 10:38 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1093
> https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This was overlooked in AURORA-1093.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 1cd21e598db0c0d51cfed293e5e0fc51d84e0bb0 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  8ec5f9a3810b4deae981988487c6a46a20db72a2 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 5989a62f1651aede6e2372ad3f519a9a947470de 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  acdade3dca807a221b4da975d0310c91884ee752 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 
> 9b15b2d12eaea00b3c734bc61ad74b5887d31a5f 
>   src/main/python/apache/aurora/client/api/__init__.py 
> c07122744e89fe61dbe4bea0c14400425983b2ef 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2e996775c7be460555b0a59b98441e01513f69c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> a4890057b7d258926bc3dfb84fd1248e68051f31 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  824740856236976984d2114ec6a6aea989a87d1e 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 459f745cec1f85ece41376cade39c09254b50013 
>   
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java
>  7ebc4d4642df107356ffbafabc25b560409022d7 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e24d6bde5f3479a75522e825cce4ec6c30c117aa 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 0d552e8b9f9be300fc28a3f52aabe19e5a51b252 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> a65aab71ee8ce19dc2c05ea230258084d6f55727 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> c8d217da005afe7f65a8215882a5a119d4899b98 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> b596babc3c6877f68094943126b8cd49be3fc635 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 93a5532dc6f7aee2c40bc86385a630b9a1b6f528 
>   src/test/python/apache/aurora/client/cli/util.py 
> 6d3cc51f50b417405549c254531c854565a54949 
> 
> Diff: https://reviews.apache.org/r/31779/diff/
> 
> 
> Testing
> ---
> 
> Normal test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

2015-03-06 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31779/#review75565
---

Ship it!


Master (8e71b58) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 6, 2015, 10:38 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31779/
> ---
> 
> (Updated March 6, 2015, 10:38 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1093
> https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This was overlooked in AURORA-1093.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 1cd21e598db0c0d51cfed293e5e0fc51d84e0bb0 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  8ec5f9a3810b4deae981988487c6a46a20db72a2 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 5989a62f1651aede6e2372ad3f519a9a947470de 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  acdade3dca807a221b4da975d0310c91884ee752 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 
> 9b15b2d12eaea00b3c734bc61ad74b5887d31a5f 
>   src/main/python/apache/aurora/client/api/__init__.py 
> c07122744e89fe61dbe4bea0c14400425983b2ef 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2e996775c7be460555b0a59b98441e01513f69c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> a4890057b7d258926bc3dfb84fd1248e68051f31 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  824740856236976984d2114ec6a6aea989a87d1e 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 459f745cec1f85ece41376cade39c09254b50013 
>   
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java
>  7ebc4d4642df107356ffbafabc25b560409022d7 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e24d6bde5f3479a75522e825cce4ec6c30c117aa 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 0d552e8b9f9be300fc28a3f52aabe19e5a51b252 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> a65aab71ee8ce19dc2c05ea230258084d6f55727 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> c8d217da005afe7f65a8215882a5a119d4899b98 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> b596babc3c6877f68094943126b8cd49be3fc635 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 93a5532dc6f7aee2c40bc86385a630b9a1b6f528 
>   src/test/python/apache/aurora/client/cli/util.py 
> 6d3cc51f50b417405549c254531c854565a54949 
> 
> Diff: https://reviews.apache.org/r/31779/diff/
> 
> 
> Testing
> ---
> 
> Normal test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

2015-03-06 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31779/#review75559
---

Ship it!


Ship It!

- Maxim Khutornenko


On March 6, 2015, 10:38 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31779/
> ---
> 
> (Updated March 6, 2015, 10:38 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1093
> https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This was overlooked in AURORA-1093.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 1cd21e598db0c0d51cfed293e5e0fc51d84e0bb0 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  8ec5f9a3810b4deae981988487c6a46a20db72a2 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 5989a62f1651aede6e2372ad3f519a9a947470de 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  acdade3dca807a221b4da975d0310c91884ee752 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 
> 9b15b2d12eaea00b3c734bc61ad74b5887d31a5f 
>   src/main/python/apache/aurora/client/api/__init__.py 
> c07122744e89fe61dbe4bea0c14400425983b2ef 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 2e996775c7be460555b0a59b98441e01513f69c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> a4890057b7d258926bc3dfb84fd1248e68051f31 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  824740856236976984d2114ec6a6aea989a87d1e 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 459f745cec1f85ece41376cade39c09254b50013 
>   
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java
>  7ebc4d4642df107356ffbafabc25b560409022d7 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e24d6bde5f3479a75522e825cce4ec6c30c117aa 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 0d552e8b9f9be300fc28a3f52aabe19e5a51b252 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> a65aab71ee8ce19dc2c05ea230258084d6f55727 
>   src/test/python/apache/aurora/client/cli/test_quota.py 
> c8d217da005afe7f65a8215882a5a119d4899b98 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> b596babc3c6877f68094943126b8cd49be3fc635 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 93a5532dc6f7aee2c40bc86385a630b9a1b6f528 
>   src/test/python/apache/aurora/client/cli/util.py 
> 6d3cc51f50b417405549c254531c854565a54949 
> 
> Diff: https://reviews.apache.org/r/31779/diff/
> 
> 
> Testing
> ---
> 
> Normal test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

2015-03-06 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31779/
---

(Updated March 6, 2015, 10:38 p.m.)


Review request for Aurora, Joshua Cohen and Maxim Khutornenko.


Bugs: AURORA-1093
https://issues.apache.org/jira/browse/AURORA-1093


Repository: aurora


Description
---

This was overlooked in AURORA-1093.


Diffs (updated)
-

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
1cd21e598db0c0d51cfed293e5e0fc51d84e0bb0 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
8ec5f9a3810b4deae981988487c6a46a20db72a2 
  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
5989a62f1651aede6e2372ad3f519a9a947470de 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
acdade3dca807a221b4da975d0310c91884ee752 
  src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 
9b15b2d12eaea00b3c734bc61ad74b5887d31a5f 
  src/main/python/apache/aurora/client/api/__init__.py 
c07122744e89fe61dbe4bea0c14400425983b2ef 
  src/main/python/apache/aurora/client/cli/__init__.py 
2e996775c7be460555b0a59b98441e01513f69c4 
  src/main/python/apache/aurora/client/cli/update.py 
a4890057b7d258926bc3dfb84fd1248e68051f31 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 824740856236976984d2114ec6a6aea989a87d1e 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
459f745cec1f85ece41376cade39c09254b50013 
  
src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java
 7ebc4d4642df107356ffbafabc25b560409022d7 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
e24d6bde5f3479a75522e825cce4ec6c30c117aa 
  src/test/python/apache/aurora/client/api/test_api.py 
0d552e8b9f9be300fc28a3f52aabe19e5a51b252 
  src/test/python/apache/aurora/client/cli/test_create.py 
a65aab71ee8ce19dc2c05ea230258084d6f55727 
  src/test/python/apache/aurora/client/cli/test_quota.py 
c8d217da005afe7f65a8215882a5a119d4899b98 
  src/test/python/apache/aurora/client/cli/test_restart.py 
b596babc3c6877f68094943126b8cd49be3fc635 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
93a5532dc6f7aee2c40bc86385a630b9a1b6f528 
  src/test/python/apache/aurora/client/cli/util.py 
6d3cc51f50b417405549c254531c854565a54949 

Diff: https://reviews.apache.org/r/31779/diff/


Testing
---

Normal test suite + end-to-end tests.


Thanks,

Bill Farner

Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

2015-03-06 Thread Bill Farner 


> On March 5, 2015, 11:37 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 68
> > 
> >
> > `if not update_key:`

IIRC comparison to `None` is the best practice here when you are truly testing 
for `None`.  Otherwise you rely on the definition of `__bool__`, which could 
have additional meanings.


> On March 5, 2015, 11:37 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/update.py, lines 60-64
> > 
> >
> > Are we 100% confident that we'll never get back multiple active updates 
> > for a job key?
> > 
> > Should we raise if for some reason we get back more than one match here 
> > just to be safe?

I like the sound of being defensive.  You've convinced me to also not use a 
loop, which IMHO further emphasizes the expectations.


> On March 5, 2015, 11:37 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 66
> > 
> >
> > Would it make more sense to have this be a context manager or a 
> > decorator to reduce (further) the boilerplate?

I'm not sure what the patterns are for use of context managers, but this would 
seem odd since there's no 'cleanup'.  I suppose i'm ambivalent here, and opted 
for what is (to me) simpler code.  Feel free to push if you feel strongly.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31779/#review75416
---


On March 5, 2015, 11:10 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31779/
> ---
> 
> (Updated March 5, 2015, 11:10 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1093
> https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This was overlooked in AURORA-1093.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 1cd21e598db0c0d51cfed293e5e0fc51d84e0bb0 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  8ec5f9a3810b4deae981988487c6a46a20db72a2 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 5989a62f1651aede6e2372ad3f519a9a947470de 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  acdade3dca807a221b4da975d0310c91884ee752 
>   src/main/python/apache/aurora/client/api/__init__.py 
> c07122744e89fe61dbe4bea0c14400425983b2ef 
>   src/main/python/apache/aurora/client/cli/update.py 
> a4890057b7d258926bc3dfb84fd1248e68051f31 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  824740856236976984d2114ec6a6aea989a87d1e 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 459f745cec1f85ece41376cade39c09254b50013 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e24d6bde5f3479a75522e825cce4ec6c30c117aa 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 0d552e8b9f9be300fc28a3f52aabe19e5a51b252 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> a65aab71ee8ce19dc2c05ea230258084d6f55727 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> b596babc3c6877f68094943126b8cd49be3fc635 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 93a5532dc6f7aee2c40bc86385a630b9a1b6f528 
>   src/test/python/apache/aurora/client/cli/util.py 
> 6d3cc51f50b417405549c254531c854565a54949 
> 
> Diff: https://reviews.apache.org/r/31779/diff/
> 
> 
> Testing
> ---
> 
> Normal test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

2015-03-06 Thread Bill Farner 


> On March 6, 2015, 2:16 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
> >  line 213
> > 
> >
> > This change loses the "active" filter where it's actually vital. 
> > Recommend refactoring `queryActiveByJob` to take a `IJobUpdateKey` instead.

Thanks for noticing this.  My intention was to let the state machine handle 
this behavior, since i think the user experience of "Update x cannot be 
transitioned to ABORTED" (analog to HTTP 400) is better than "Update x does not 
exist" (analog to HTTP 404).

However, adding a test case for this reveals that `IllegalStateException` 
surfaces in this case (HTTP 500), rather than `UpdateStateException`.  
Correcting this resulted in some ripple, but i think it's the right change.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31779/#review75447
---


On March 5, 2015, 11:10 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31779/
> ---
> 
> (Updated March 5, 2015, 11:10 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1093
> https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This was overlooked in AURORA-1093.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 1cd21e598db0c0d51cfed293e5e0fc51d84e0bb0 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  8ec5f9a3810b4deae981988487c6a46a20db72a2 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 5989a62f1651aede6e2372ad3f519a9a947470de 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  acdade3dca807a221b4da975d0310c91884ee752 
>   src/main/python/apache/aurora/client/api/__init__.py 
> c07122744e89fe61dbe4bea0c14400425983b2ef 
>   src/main/python/apache/aurora/client/cli/update.py 
> a4890057b7d258926bc3dfb84fd1248e68051f31 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  824740856236976984d2114ec6a6aea989a87d1e 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 459f745cec1f85ece41376cade39c09254b50013 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e24d6bde5f3479a75522e825cce4ec6c30c117aa 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 0d552e8b9f9be300fc28a3f52aabe19e5a51b252 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> a65aab71ee8ce19dc2c05ea230258084d6f55727 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> b596babc3c6877f68094943126b8cd49be3fc635 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 93a5532dc6f7aee2c40bc86385a630b9a1b6f528 
>   src/test/python/apache/aurora/client/cli/util.py 
> 6d3cc51f50b417405549c254531c854565a54949 
> 
> Diff: https://reviews.apache.org/r/31779/diff/
> 
> 
> Testing
> ---
> 
> Normal test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

2015-03-05 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31779/#review75447
---



src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java


This change loses the "active" filter where it's actually vital. Recommend 
refactoring `queryActiveByJob` to take a `IJobUpdateKey` instead.


- Maxim Khutornenko


On March 5, 2015, 11:10 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31779/
> ---
> 
> (Updated March 5, 2015, 11:10 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1093
> https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This was overlooked in AURORA-1093.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 1cd21e598db0c0d51cfed293e5e0fc51d84e0bb0 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  8ec5f9a3810b4deae981988487c6a46a20db72a2 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 5989a62f1651aede6e2372ad3f519a9a947470de 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  acdade3dca807a221b4da975d0310c91884ee752 
>   src/main/python/apache/aurora/client/api/__init__.py 
> c07122744e89fe61dbe4bea0c14400425983b2ef 
>   src/main/python/apache/aurora/client/cli/update.py 
> a4890057b7d258926bc3dfb84fd1248e68051f31 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  824740856236976984d2114ec6a6aea989a87d1e 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 459f745cec1f85ece41376cade39c09254b50013 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e24d6bde5f3479a75522e825cce4ec6c30c117aa 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 0d552e8b9f9be300fc28a3f52aabe19e5a51b252 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> a65aab71ee8ce19dc2c05ea230258084d6f55727 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> b596babc3c6877f68094943126b8cd49be3fc635 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 93a5532dc6f7aee2c40bc86385a630b9a1b6f528 
>   src/test/python/apache/aurora/client/cli/util.py 
> 6d3cc51f50b417405549c254531c854565a54949 
> 
> Diff: https://reviews.apache.org/r/31779/diff/
> 
> 
> Testing
> ---
> 
> Normal test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

2015-03-05 Thread Aurora ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31779/#review75427
---


Master (21661a7) is red with this patch.
  ./build-support/jenkins/build.sh

 src.test.python.apache.aurora.client.api.scheduler_client  
 .   SUCCESS
 src.test.python.apache.aurora.client.api.sla   
 .   SUCCESS
 src.test.python.apache.aurora.client.api.task_util 
 .   SUCCESS
 src.test.python.apache.aurora.client.api.updater   
 .   SUCCESS
 src.test.python.apache.aurora.client.api.updater_util  
 .   SUCCESS
 src.test.python.apache.aurora.client.base  
 .   SUCCESS
 src.test.python.apache.aurora.client.binding_helper
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.api   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.client
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.command_hooks 
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.config
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.context   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.cron  
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.inspect   
 .   SUCCESS
 src.test.python.apache.aurora.client.cli.job   
 .   FAILURE
 src.test.python.apache.aurora.client.cli.sla   
 .   SUCCESS
 src.test.python.apache.aurora.client.config
 .   SUCCESS
 src.test.python.apache.aurora.client.factory   
 .   SUCCESS
 src.test.python.apache.aurora.client.hooks.non_hooked_api  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_aurora_job_key   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_cluster_option   
 .   SUCCESS
 src.test.python.apache.aurora.common.test_clusters 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_http_signaler
 .   SUCCESS
 src.test.python.apache.aurora.common.test_pex_version  
 .   SUCCESS
 src.test.python.apache.aurora.common.test_shellify 
 .   SUCCESS
 src.test.python.apache.aurora.common.test_transport
 .   SUCCESS
 
src.test.python.apache.aurora.executor.common.path_detector 
.   SUCCESS
 src.test.python.apache.aurora.executor.common.task_info
 .   SUCCESS
 src.test.python.apache.thermos.cli.commands.commands   
 .   SUCCESS
 src.test.python.apache.thermos.cli.common  
 .   SUCCESS
 src.test.python.apache.thermos.cli.main
 .   SUCCESS
 src.test.python.apache.thermos.common.test_pathspec
 .   SUCCESS
 
src.test.python.apache.thermos.core.test_runner_integration 
.   SUCCESS
 src.test.python.apache.thermos.monitoring.test_disk
 .   SUCCESS
 
FAILURE


   FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On March 5, 2015, 11:10 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31779/
> ---
> 
> (Updated March 5, 2015, 11:10 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko

Re: Review Request 31779: Change remaining update-related RPCs to use JobUpdateKey.

2015-03-05 Thread Joshua Cohen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31779/#review75416
---



src/main/python/apache/aurora/client/cli/update.py


Are we 100% confident that we'll never get back multiple active updates for 
a job key?

Should we raise if for some reason we get back more than one match here 
just to be safe?



src/main/python/apache/aurora/client/cli/update.py


Would it make more sense to have this be a context manager or a decorator 
to reduce (further) the boilerplate?



src/main/python/apache/aurora/client/cli/update.py


`if not update_key:`


- Joshua Cohen


On March 5, 2015, 11:10 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31779/
> ---
> 
> (Updated March 5, 2015, 11:10 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1093
> https://issues.apache.org/jira/browse/AURORA-1093
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This was overlooked in AURORA-1093.
> 
> 
> Diffs
> -
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> 1cd21e598db0c0d51cfed293e5e0fc51d84e0bb0 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  8ec5f9a3810b4deae981988487c6a46a20db72a2 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 5989a62f1651aede6e2372ad3f519a9a947470de 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  acdade3dca807a221b4da975d0310c91884ee752 
>   src/main/python/apache/aurora/client/api/__init__.py 
> c07122744e89fe61dbe4bea0c14400425983b2ef 
>   src/main/python/apache/aurora/client/cli/update.py 
> a4890057b7d258926bc3dfb84fd1248e68051f31 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  824740856236976984d2114ec6a6aea989a87d1e 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> 459f745cec1f85ece41376cade39c09254b50013 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e24d6bde5f3479a75522e825cce4ec6c30c117aa 
>   src/test/python/apache/aurora/client/api/test_api.py 
> 0d552e8b9f9be300fc28a3f52aabe19e5a51b252 
>   src/test/python/apache/aurora/client/cli/test_create.py 
> a65aab71ee8ce19dc2c05ea230258084d6f55727 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> b596babc3c6877f68094943126b8cd49be3fc635 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 93a5532dc6f7aee2c40bc86385a630b9a1b6f528 
>   src/test/python/apache/aurora/client/cli/util.py 
> 6d3cc51f50b417405549c254531c854565a54949 
> 
> Diff: https://reviews.apache.org/r/31779/diff/
> 
> 
> Testing
> ---
> 
> Normal test suite + end-to-end tests.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>