---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/#review75926
---
Ship it!
lgtm!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/
---
(Updated March 10, 2015, 12:45 p.m.)
Review request for Aurora, Joshua Cohen
On March 10, 2015, 11:48 a.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java,
lines 59-62
https://reviews.apache.org/r/31820/diff/3/?file=889978#file889978line59
Maybe move this to the ticket and kill the commented out code
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/#review75959
---
Ship it!
Master (48dc4c7) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/#review75954
---
Ship it!
Ship It!
- Bill Farner
On March 10, 2015, 7:45 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/#review75723
---
Should we add tests for the full scheduler API as well as the admin
On March 9, 2015, 6:36 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java,
line 50
https://reviews.apache.org/r/31820/diff/1/?file=888081#file888081line50
Would it be possible to create a Ini parser for Args instead of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/
---
(Updated March 9, 2015, 5:37 p.m.)
Review request for Aurora, Joshua Cohen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/#review75827
---
Master (e55113d) is red with this patch.
On March 9, 2015, 11:36 a.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java,
line 50
https://reviews.apache.org/r/31820/diff/1/?file=888081#file888081line50
Would it be possible to create a Ini parser for Args instead of
On March 9, 2015, 1:47 p.m., Bill Farner wrote:
build.gradle, line 260
https://reviews.apache.org/r/31820/diff/1/?file=888077#file888077line260
Holy cow, they're on guava 9!? Hopefully this doesn't burn us, but a
quick grep through their code suggests they only have minimal use
On March 9, 2015, 11:27 a.m., Joshua Cohen wrote:
Should we add tests for the full scheduler API as well as the admin
interface?
Also, worth adding a unit test for the interceptor?
Added ShiroThriftInterceptorTest.
Not sure what you mean by test the full scheduler API - I check
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/
---
(Updated March 9, 2015, 6:18 p.m.)
Review request for Aurora, Joshua Cohen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/#review75839
---
Ship it!
Master (1b1931c) is green with this patch.
14 matches
Mail list logo
