Re: Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

2015-03-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32220/#review77139 --- Ship it! Master (6396410) is green with this patch. ./build-suppo

Re: Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

2015-03-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32220/ --- (Updated March 19, 2015, 11:39 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

2015-03-19 Thread Maxim Khutornenko
> On March 19, 2015, 9:23 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotCache.java, > > line 45 > > > > > > This should refer to the parameter, not the guice bindi

Re: Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

2015-03-19 Thread Maxim Khutornenko
> On March 19, 2015, 9:41 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotFinder.java, > > line 254 > > > > > > This is a bit confusing to see .getSlaveId and then

Re: Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

2015-03-19 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32220/#review77112 --- Ship it! src/main/java/org/apache/aurora/scheduler/async/preemptor

Re: Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

2015-03-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32220/#review77106 --- Ship it! src/main/java/org/apache/aurora/scheduler/async/preemptor

Re: Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

2015-03-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32220/#review76986 --- Ship it! Master (6396410) is green with this patch. ./build-suppo

Re: Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

2015-03-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32220/ --- (Updated March 19, 2015, 12:29 a.m.) Review request for Aurora, Bill Farner and

Re: Review Request 32220: Making preemptor asynchronous. Part 2 - async handling.

2015-03-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32220/#review76969 --- Ship it! Master (6396410) is green with this patch. ./build-suppo