Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-20 Thread Joe Smith
On March 20, 2015, 3:52 p.m., Joe Smith wrote: It seems like the `self.quitquitquit` is the important part (on line 340 of the runner)- doesn't decreasing the timeout not give `quitquitquit` the time it needs? - Joe --- This is an

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-20 Thread Joe Smith
On March 20, 2015, 3:52 p.m., Joe Smith wrote: Joe Smith wrote: It seems like the `self.quitquitquit` is the important part (on line 340 of the runner)- doesn't decreasing the timeout not give `quitquitquit` the time it needs? In

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-20 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32221/#review77296 --- src/test/python/apache/aurora/executor/test_thermos_task_runner.py

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-18 Thread Brian Wickman
On March 18, 2015, 11:01 p.m., Aurora ReviewBot wrote: Master (6396410) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.plugins . SUCCESS

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-18 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32221/#review76992 --- @ReviewBot retry - Brian Wickman On March 19, 2015, 1:20 a.m.,

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32221/#review76991 --- Ship it! Master (6396410) is green with this patch.

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32221/#review76999 --- Ship it! Master (6396410) is green with this patch.

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-18 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32221/ --- (Updated March 19, 2015, 1:20 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32221/#review76965 --- Master (6396410) is red with this patch.

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-18 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32221/#review76998 --- @ReviewBot retry - Brian Wickman On March 19, 2015, 1:20 a.m.,

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32221/#review76997 --- Ship it! Master (6396410) is green with this patch.