Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77302 --- Ship it! Master (f12d9fe) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 20, 2015, 10:48 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 10:48 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs - docs/client-commands.md fe13fb380010f20e704608c4e82db0e5b93298ab src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77242 --- Realized i neglected to update docs. Please review what's here, new patch will come shortly with doc updates. - Bill Farner On March 20, 2015, 5:26 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 5:26 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77248 --- Ship it! src/test/python/apache/aurora/client/cli/test_supdate.py https://reviews.apache.org/r/32313/#comment125117 Using a raw mock here is a little bit dangerous if the shape of the raw config changes underneath the test. Would you mind setting the spec argument of the Mock class here? http://www.voidspace.org.uk/python/mock/mock.html#mock.Mock I was thinking of something like Mock(spec=['has_cron_schedule']). Alternatively you could set the spec to be the Job schema object. I think it could be of the form of Mock(spec=aurora.config.schema.base.Job) or Mock(spec=aurora.config.schema.base.Job()). This might be impossible because Job() is a pystachio object but I strongly suggest investigating it. This way if we try to access other attributes the test will fail. - Zameer Manji On March 20, 2015, 10:26 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 10:26 a.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77243 --- Ship it! Master (91aec8c) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 20, 2015, 5:26 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 5:26 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77268 --- Ship it! Master (f12d9fe) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 20, 2015, 8:23 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 8:23 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs - docs/client-commands.md fe13fb380010f20e704608c4e82db0e5b93298ab src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
On March 20, 2015, 5:59 p.m., Zameer Manji wrote: src/test/python/apache/aurora/client/cli/test_supdate.py, line 101 https://reviews.apache.org/r/32313/diff/1/?file=901501#file901501line101 Using a raw mock here is a little bit dangerous if the shape of the raw config changes underneath the test. Would you mind setting the spec argument of the Mock class here? http://www.voidspace.org.uk/python/mock/mock.html#mock.Mock I was thinking of something like Mock(spec=['has_cron_schedule']). Alternatively you could set the spec to be the Job schema object. I think it could be of the form of Mock(spec=aurora.config.schema.base.Job) or Mock(spec=aurora.config.schema.base.Job()). This might be impossible because Job() is a pystachio object but I strongly suggest investigating it. This way if we try to access other attributes the test will fail. I ventured down this path, but it appears that pystachio is too dynamic for this to be possible [1]. I'll do the spec_set routine, but i fear this will be untenable in other scenarios. [1] https://github.com/wickman/pystachio/blob/master/pystachio/composite.py#L205-L211 - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77248 --- On March 20, 2015, 5:26 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 5:26 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 7:51 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs (updated) - src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 8:15 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Changes --- Kevin rightly pointed out that i could use a real `Job()` instead of a mock, which is better on all counts. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs (updated) - src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 8:23 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Changes --- Updated doc. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs (updated) - docs/client-commands.md fe13fb380010f20e704608c4e82db0e5b93298ab src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77284 --- Ship it! src/test/python/apache/aurora/client/cli/test_supdate.py https://reviews.apache.org/r/32313/#comment125167 Can we assert `self._mock_api.start_job.mock_calls = [call(...)]` instead? - Joshua Cohen On March 20, 2015, 8:23 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 8:23 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs - docs/client-commands.md fe13fb380010f20e704608c4e82db0e5b93298ab src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
On March 20, 2015, 10:11 p.m., Joshua Cohen wrote: src/test/python/apache/aurora/client/cli/test_supdate.py, lines 158-162 https://reviews.apache.org/r/32313/diff/4/?file=901692#file901692line158 Can we assert `self._mock_api.start_job.mock_calls = [call(...)]` instead? We can! This wasn't done before because validating the resulting `AuroraConfig` was likely deemed some combination of too complex and/or too much coupling. However, you prompted me to discover `mock.ANY`, which fits the bill here. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77284 --- On March 20, 2015, 8:23 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 8:23 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs - docs/client-commands.md fe13fb380010f20e704608c4e82db0e5b93298ab src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 10:30 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description (updated) --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs (updated) - docs/client-commands.md fe13fb380010f20e704608c4e82db0e5b93298ab src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 10:31 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs (updated) - docs/client-commands.md fe13fb380010f20e704608c4e82db0e5b93298ab src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77291 --- Ship it! src/test/python/apache/aurora/client/cli/test_supdate.py https://reviews.apache.org/r/32313/#comment125174 Yes, let us add stuff! Stuff is great and junk! - Joshua Cohen On March 20, 2015, 10:31 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 10:31 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs - docs/client-commands.md fe13fb380010f20e704608c4e82db0e5b93298ab src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77292 --- Master (f12d9fe) is red with this patch. ./build-support/jenkins/build.sh SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/statuses.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/common/options.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/muxer.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/inspector.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/process.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/__init__.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/helper.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/core/runner.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/main.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/common.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/help.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/kill.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/run.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/status.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/inspect.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/read.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/simplerun.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/tail.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/commands/gc.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/cli/bin/thermos.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/observed_task.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/task_observer.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/__init__.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/detector.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/templating.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/vars_endpoint.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/file_browser.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/diagnostics.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/configure.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/static_assets.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/__init__.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/http_observer.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/http/json.py Everything Looks Good! SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/bin/__init__.py Everything Looks Good! SUCCESS:
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
On March 20, 2015, 10:33 p.m., Joshua Cohen wrote: src/test/python/apache/aurora/client/cli/test_supdate.py, line 636 https://reviews.apache.org/r/32313/diff/5/?file=901848#file901848line636 Yes, let us add stuff! Stuff is great and junk! Stuff=added. This pointed out that i neglected to update these tests to the new style. Key result: mock.patch import is now gone! - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/#review77291 --- On March 20, 2015, 10:31 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 10:31 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs - docs/client-commands.md fe13fb380010f20e704608c4e82db0e5b93298ab src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32313/ --- (Updated March 20, 2015, 10:48 p.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1206 https://issues.apache.org/jira/browse/AURORA-1206 Repository: aurora Description --- One change i snuck in here is in `cli/__init__.py`. This makes the subcommand help include the description: ``` $ aurora update info -h usage: aurora update info [-h] [--write-json] [--verbose] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME [ID] Display detailed status information about a scheduler-driven in-progress update. If no update ID is provided, information will be displayed about the active update for the job. positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format IDUpdate identifier provided by the scheduler when an update was started. optional arguments: -h, --helpshow this help message and exit --write-json Generate command output in JSON format --verbose, -v Show verbose output --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted ``` Prior to this change, the description was only displayed in the parent command's help text. Diffs (updated) - docs/client-commands.md fe13fb380010f20e704608c4e82db0e5b93298ab src/main/python/apache/aurora/client/cli/__init__.py 6a0c129bc5d5dac8d8d393705a69586c9918983d src/main/python/apache/aurora/client/cli/update.py 830ef4424fe46bc8c14456492f29dea681cf5200 src/test/python/apache/aurora/client/cli/test_supdate.py f9acbdfd65adb252f3059717a6bc1a1f4ba39c44 src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 320c1fbeee0161528745edd38360cd1fd5d53104 Diff: https://reviews.apache.org/r/32313/diff/ Testing --- I have converted all test cases in `test_supdate.py` to use the 'new style' non-integration testing, which removed a ton of boilerplate. I also corrected some holes in the end-to-end tests, wherein `test` and conditions could silently fail. Thanks, Bill Farner
