Re: Review Request 17666: Adding DRAINING state into api.thrift.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/#review33462 --- Ship it! Ship It! - Kevin Sweeney On Feb. 3, 2014, 10:16 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/ --- (Updated Feb. 3, 2014, 10:16 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-82 https://issues.apache.org/jira/browse/AURORA-82 Repository: aurora Description --- Splitting this work into 3 steps to ensure schema compatibility between releases. Step1: Adding DRAINING state into api.thrift. To come: Step2: Adding DRAINING into StorageBackfill. Step3: Implement support for DRAINING in state machine. Diffs - src/main/thrift/org/apache/aurora/gen/api.thrift 94569f9abfb56c50e67e09cc018484463f9de427 src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 153f82c1136daac69653f0083250bb3343b1148e src/test/resources/org/apache/aurora/gen/api.thrift.md5 e88d29732ee8652ede6c7ee13513122086385646 Diff: https://reviews.apache.org/r/17666/diff/ Testing --- gradle clean build Thanks, Maxim Khutornenko
Re: Review Request 17666: Adding DRAINING state into api.thrift.
On Feb. 3, 2014, 7:22 p.m., Bill Farner wrote: You might want to do a bit more in this commit, specifically to ensure read sites handle the new state. You probably also want to rewrite the state in StorageBackfill. Also look out for another regression like https://issues.apache.org/jira/browse/AURORA-150 I was intending to delay StorageBackfill until Step2 but I agree adding it now would be safer. Done. I am addressing readers in Step3 (now Step2) as with StorageBackfill rewrite there should be no way to get anything in DRAINING state (except for someone trying to call forceTaskState(DRAINING) in which case a simple scheduler failover would clear the problem). - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/#review33472 --- On Feb. 3, 2014, 6:16 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/ --- (Updated Feb. 3, 2014, 6:16 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-82 https://issues.apache.org/jira/browse/AURORA-82 Repository: aurora Description --- Splitting this work into 3 steps to ensure schema compatibility between releases. Step1: Adding DRAINING state into api.thrift. To come: Step2: Adding DRAINING into StorageBackfill. Step3: Implement support for DRAINING in state machine. Diffs - src/main/thrift/org/apache/aurora/gen/api.thrift 94569f9abfb56c50e67e09cc018484463f9de427 src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 153f82c1136daac69653f0083250bb3343b1148e src/test/resources/org/apache/aurora/gen/api.thrift.md5 e88d29732ee8652ede6c7ee13513122086385646 Diff: https://reviews.apache.org/r/17666/diff/ Testing --- gradle clean build Thanks, Maxim Khutornenko
Re: Review Request 17666: Adding DRAINING state into api.thrift.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/ --- (Updated Feb. 3, 2014, 8:44 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- CR comments addressed. Bugs: AURORA-82 https://issues.apache.org/jira/browse/AURORA-82 Repository: aurora Description (updated) --- Splitting this work into 3 steps to ensure schema compatibility between releases. Step1: Adding DRAINING state into api.thrift and rewriting DRAINING to RESTARTING in StorageBackfill. To come: Step2: Implement support for DRAINING in state machine. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 3ce5bd38482c40279694fd068d0e4df825be40df src/main/thrift/org/apache/aurora/gen/api.thrift 94569f9abfb56c50e67e09cc018484463f9de427 src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 153f82c1136daac69653f0083250bb3343b1148e src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java PRE-CREATION src/test/resources/org/apache/aurora/gen/api.thrift.md5 e88d29732ee8652ede6c7ee13513122086385646 Diff: https://reviews.apache.org/r/17666/diff/ Testing --- gradle clean build Thanks, Maxim Khutornenko
