Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/#review34221 --- Thanks, pushed. - Maxim Khutornenko On Feb. 11, 2014, 7:40 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17955/ > --- > > (Updated Feb. 11, 2014, 7:40 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-210 > https://issues.apache.org/jira/browse/AURORA-210 > > > Repository: aurora > > > Description > --- > > Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup. > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > 388926c2c51c381b91ab2dcf7e4af7993d19d111 > src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java > b5d97af7454e7c4fe4b7428e2adf2c7b9ca0c1dc > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > 24e1bc49a446bab9ec9a8aff62438cbde89e6569 > src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java > 0b565abc2187deeba466a63162de80b5e2bb5d47 > > Diff: https://reviews.apache.org/r/17955/diff/ > > > Testing > --- > > gradle clean build > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/#review34220 --- Ship it! Thanks for the additional test coverage. LGTM! - Bill Farner On Feb. 11, 2014, 7:40 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17955/ > --- > > (Updated Feb. 11, 2014, 7:40 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-210 > https://issues.apache.org/jira/browse/AURORA-210 > > > Repository: aurora > > > Description > --- > > Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup. > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > 388926c2c51c381b91ab2dcf7e4af7993d19d111 > src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java > b5d97af7454e7c4fe4b7428e2adf2c7b9ca0c1dc > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > 24e1bc49a446bab9ec9a8aff62438cbde89e6569 > src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java > 0b565abc2187deeba466a63162de80b5e2bb5d47 > > Diff: https://reviews.apache.org/r/17955/diff/ > > > Testing > --- > > gradle clean build > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/ --- (Updated Feb. 11, 2014, 7:40 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- CR comments. Bugs: AURORA-210 https://issues.apache.org/jira/browse/AURORA-210 Repository: aurora Description --- Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 388926c2c51c381b91ab2dcf7e4af7993d19d111 src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java b5d97af7454e7c4fe4b7428e2adf2c7b9ca0c1dc src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 24e1bc49a446bab9ec9a8aff62438cbde89e6569 src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 0b565abc2187deeba466a63162de80b5e2bb5d47 Diff: https://reviews.apache.org/r/17955/diff/ Testing --- gradle clean build Thanks, Maxim Khutornenko
Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.
> On Feb. 11, 2014, 7:27 p.m., Bill Farner wrote: > > I don't see a test case that reproduces the bug. Can you add that as > > confirmation that schedulerActive now succeeds? Added. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/#review34218 --- On Feb. 11, 2014, 6:58 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17955/ > --- > > (Updated Feb. 11, 2014, 6:58 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-210 > https://issues.apache.org/jira/browse/AURORA-210 > > > Repository: aurora > > > Description > --- > > Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup. > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > 388926c2c51c381b91ab2dcf7e4af7993d19d111 > src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java > b5d97af7454e7c4fe4b7428e2adf2c7b9ca0c1dc > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > 24e1bc49a446bab9ec9a8aff62438cbde89e6569 > src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java > 0b565abc2187deeba466a63162de80b5e2bb5d47 > > Diff: https://reviews.apache.org/r/17955/diff/ > > > Testing > --- > > gradle clean build > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/#review34218 --- I don't see a test case that reproduces the bug. Can you add that as confirmation that schedulerActive now succeeds? - Bill Farner On Feb. 11, 2014, 6:58 p.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17955/ > --- > > (Updated Feb. 11, 2014, 6:58 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-210 > https://issues.apache.org/jira/browse/AURORA-210 > > > Repository: aurora > > > Description > --- > > Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup. > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > 388926c2c51c381b91ab2dcf7e4af7993d19d111 > src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java > b5d97af7454e7c4fe4b7428e2adf2c7b9ca0c1dc > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > 24e1bc49a446bab9ec9a8aff62438cbde89e6569 > src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java > 0b565abc2187deeba466a63162de80b5e2bb5d47 > > Diff: https://reviews.apache.org/r/17955/diff/ > > > Testing > --- > > gradle clean build > > > Thanks, > > Maxim Khutornenko > >
Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/#review34215 --- Ship it! Ship It! - Kevin Sweeney On Feb. 11, 2014, 10:58 a.m., Maxim Khutornenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17955/ > --- > > (Updated Feb. 11, 2014, 10:58 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-210 > https://issues.apache.org/jira/browse/AURORA-210 > > > Repository: aurora > > > Description > --- > > Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup. > > > Diffs > - > > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > 388926c2c51c381b91ab2dcf7e4af7993d19d111 > src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java > b5d97af7454e7c4fe4b7428e2adf2c7b9ca0c1dc > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > 24e1bc49a446bab9ec9a8aff62438cbde89e6569 > src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java > 0b565abc2187deeba466a63162de80b5e2bb5d47 > > Diff: https://reviews.apache.org/r/17955/diff/ > > > Testing > --- > > gradle clean build > > > Thanks, > > Maxim Khutornenko > >
Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-210 https://issues.apache.org/jira/browse/AURORA-210 Repository: aurora Description --- Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup. Diffs - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 388926c2c51c381b91ab2dcf7e4af7993d19d111 src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java b5d97af7454e7c4fe4b7428e2adf2c7b9ca0c1dc src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 24e1bc49a446bab9ec9a8aff62438cbde89e6569 src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 0b565abc2187deeba466a63162de80b5e2bb5d47 Diff: https://reviews.apache.org/r/17955/diff/ Testing --- gradle clean build Thanks, Maxim Khutornenko
