Re: Review Request 18655: Added JobKey set into TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36547 --- Ship it! Ship It! - Kevin Sweeney On March 3, 2014, 5:03 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 3, 2014, 5:03 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-235 https://issues.apache.org/jira/browse/AURORA-235 Repository: aurora Description --- Added an optional JobKey set filter into the TaskQuery. Diffs - src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 336e91b10dc25d761dfc4389ac27d9ac324c52c0 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0 src/main/thrift/org/apache/aurora/gen/api.thrift 2afbb4ce98e49332495d264218a7112bce8d450b src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 095cc4a881b16ab4d9e66b1e1f907fd781f8b0cb src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2 src/test/resources/org/apache/aurora/gen/api.thrift.md5 5cfa330f54c0297c84b8f41ee550a7bc6f163010 Diff: https://reviews.apache.org/r/18655/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18655: Added JobKey set into TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 7, 2014, 6:21 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Merged with master. Bugs: AURORA-235 https://issues.apache.org/jira/browse/AURORA-235 Repository: aurora Description --- Added an optional JobKey set filter into the TaskQuery. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 336e91b10dc25d761dfc4389ac27d9ac324c52c0 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0 src/main/thrift/org/apache/aurora/gen/api.thrift 159bdaaaf1a717ca53b027e88199075a5372e3b6 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 095cc4a881b16ab4d9e66b1e1f907fd781f8b0cb src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2 src/test/resources/org/apache/aurora/gen/api.thrift.md5 593d1542db33c884d0a65604f8237f8ea9558c6c Diff: https://reviews.apache.org/r/18655/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18655: Added JobKey set into TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36427 --- Waiting for Kevin. - Maxim Khutornenko On March 4, 2014, 1:03 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 4, 2014, 1:03 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-235 https://issues.apache.org/jira/browse/AURORA-235 Repository: aurora Description --- Added an optional JobKey set filter into the TaskQuery. Diffs - src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 336e91b10dc25d761dfc4389ac27d9ac324c52c0 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0 src/main/thrift/org/apache/aurora/gen/api.thrift 2afbb4ce98e49332495d264218a7112bce8d450b src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 095cc4a881b16ab4d9e66b1e1f907fd781f8b0cb src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2 src/test/resources/org/apache/aurora/gen/api.thrift.md5 5cfa330f54c0297c84b8f41ee550a7bc6f163010 Diff: https://reviews.apache.org/r/18655/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18655: Added JobKey set into TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36187 --- Ping, Kevin? - Maxim Khutornenko On March 4, 2014, 1:03 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 4, 2014, 1:03 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-235 https://issues.apache.org/jira/browse/AURORA-235 Repository: aurora Description --- Added an optional JobKey set filter into the TaskQuery. Diffs - src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 336e91b10dc25d761dfc4389ac27d9ac324c52c0 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0 src/main/thrift/org/apache/aurora/gen/api.thrift 2afbb4ce98e49332495d264218a7112bce8d450b src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 095cc4a881b16ab4d9e66b1e1f907fd781f8b0cb src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2 src/test/resources/org/apache/aurora/gen/api.thrift.md5 5cfa330f54c0297c84b8f41ee550a7bc6f163010 Diff: https://reviews.apache.org/r/18655/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18655: Added JobKey set into TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review35988 --- src/main/java/org/apache/aurora/scheduler/base/Query.java https://reviews.apache.org/r/18655/#comment66778 To continue this conversation, I don't quite feel merging job (role/env/name) and jobKey extraction/building points would make much logical sense. Given the current filter implementation, the jobKeys from the set would be ORed between each other but ANDed with the job key derived from role/env/name fields. Unionizing the two would just send the wrong message as the job built out of role/env/name will not be treated the same way as the set of keys. Combining the two would make for mutually exclusive combinations. Example: byJobs(IJobKey jobKey, IJobKey... jobKeys) would have to shred the first key to role/env/name fields and send the rest to the SetIJobKey (see the test case below). Given the above, I can see some benefits in merging the two on the extraction side (i.e. from(), isJobKeyScoped()) but I feel that the construction side should remain separate (byJob, byJobKeys). Thoughts? - Maxim Khutornenko On March 1, 2014, 12:54 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 1, 2014, 12:54 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-235 https://issues.apache.org/jira/browse/AURORA-235 Repository: aurora Description --- Added an optional JobKey set filter into the TaskQuery. Diffs - src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0 src/main/thrift/org/apache/aurora/gen/api.thrift f9fc6bcb7fdc2380043cf673a4002886192c20c1 src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2 src/test/resources/org/apache/aurora/gen/api.thrift.md5 08c4c2a4717a1c827f4cef6405d78e7db5046a00 Diff: https://reviews.apache.org/r/18655/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18655: Added JobKey set into TaskQuery.
On March 3, 2014, 6:06 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/base/Query.java, line 387 https://reviews.apache.org/r/18655/diff/1/?file=507500#file507500line387 To continue this conversation, I don't quite feel merging job (role/env/name) and jobKey extraction/building points would make much logical sense. Given the current filter implementation, the jobKeys from the set would be ORed between each other but ANDed with the job key derived from role/env/name fields. Unionizing the two would just send the wrong message as the job built out of role/env/name will not be treated the same way as the set of keys. Combining the two would make for mutually exclusive combinations. Example: byJobs(IJobKey jobKey, IJobKey... jobKeys) would have to shred the first key to role/env/name fields and send the rest to the SetIJobKey (see the test case below). Given the above, I can see some benefits in merging the two on the extraction side (i.e. from(), isJobKeyScoped()) but I feel that the construction side should remain separate (byJob, byJobKeys). Thoughts? I'll let you make the call from here. The semantic probably isn't too important given that we want to get rid of the overlap in short order. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review35988 --- On March 1, 2014, 12:54 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 1, 2014, 12:54 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-235 https://issues.apache.org/jira/browse/AURORA-235 Repository: aurora Description --- Added an optional JobKey set filter into the TaskQuery. Diffs - src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0 src/main/thrift/org/apache/aurora/gen/api.thrift f9fc6bcb7fdc2380043cf673a4002886192c20c1 src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2 src/test/resources/org/apache/aurora/gen/api.thrift.md5 08c4c2a4717a1c827f4cef6405d78e7db5046a00 Diff: https://reviews.apache.org/r/18655/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18655: Added JobKey set into TaskQuery.
On March 1, 2014, 1:32 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/base/JobKeys.java, line 178 https://reviews.apache.org/r/18655/diff/1/?file=507499#file507499line178 from is currently intended to unambiguously give a single IJobKey instance derived from role/env/name. I am not sure exposing a SetIJobKey would be a good idea. Bill Farner wrote: It gets weird though if i call from() with a query that has a singleton set of job keys and get back Optional.absent(). Agree. That comment is superseded by a later one. The current plan is to merge extraction side (from) and keep the builder side (byJob/byJobKeys) separated to allow proper filter construction. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review35889 --- On March 1, 2014, 12:54 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 1, 2014, 12:54 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-235 https://issues.apache.org/jira/browse/AURORA-235 Repository: aurora Description --- Added an optional JobKey set filter into the TaskQuery. Diffs - src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0 src/main/thrift/org/apache/aurora/gen/api.thrift f9fc6bcb7fdc2380043cf673a4002886192c20c1 src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2 src/test/resources/org/apache/aurora/gen/api.thrift.md5 08c4c2a4717a1c827f4cef6405d78e7db5046a00 Diff: https://reviews.apache.org/r/18655/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18655: Added JobKey set into TaskQuery.
On March 4, 2014, 12:02 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/base/Query.java, line 78 https://reviews.apache.org/r/18655/diff/2/?file=509070#file509070line78 Iterables.getOnlyELement is a bit of a land mine. An unsuspecting caller can hit IllegalArgumentException or NoSuchElementException. SchedulerCoreImpl.killTasks is currently victim to this. That's the unfortunate outcome of merging the extraction side, which I have commented in the killTasks. Are you proposing to take on that refactoring now? - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36054 --- On March 3, 2014, 11:26 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 3, 2014, 11:26 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-235 https://issues.apache.org/jira/browse/AURORA-235 Repository: aurora Description --- Added an optional JobKey set filter into the TaskQuery. Diffs - src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 336e91b10dc25d761dfc4389ac27d9ac324c52c0 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0 src/main/thrift/org/apache/aurora/gen/api.thrift f9fc6bcb7fdc2380043cf673a4002886192c20c1 src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2 src/test/resources/org/apache/aurora/gen/api.thrift.md5 08c4c2a4717a1c827f4cef6405d78e7db5046a00 Diff: https://reviews.apache.org/r/18655/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18655: Added JobKey set into TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 4, 2014, 1:03 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- CR comments. Bugs: AURORA-235 https://issues.apache.org/jira/browse/AURORA-235 Repository: aurora Description --- Added an optional JobKey set filter into the TaskQuery. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 336e91b10dc25d761dfc4389ac27d9ac324c52c0 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0 src/main/thrift/org/apache/aurora/gen/api.thrift 2afbb4ce98e49332495d264218a7112bce8d450b src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 095cc4a881b16ab4d9e66b1e1f907fd781f8b0cb src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2 src/test/resources/org/apache/aurora/gen/api.thrift.md5 5cfa330f54c0297c84b8f41ee550a7bc6f163010 Diff: https://reviews.apache.org/r/18655/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18655: Added JobKey set into TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36072 --- src/main/java/org/apache/aurora/scheduler/base/JobKeys.java https://reviews.apache.org/r/18655/#comment66910 Good point. I initially used it in Query but that changed. Done. src/main/java/org/apache/aurora/scheduler/base/Query.java https://reviews.apache.org/r/18655/#comment66917 Not afraid. Done. src/main/java/org/apache/aurora/scheduler/base/Query.java https://reviews.apache.org/r/18655/#comment66920 Thanks, I see what you meant now. Done. src/main/java/org/apache/aurora/scheduler/base/Query.java https://reviews.apache.org/r/18655/#comment66921 Reverted. src/main/java/org/apache/aurora/scheduler/base/Query.java https://reviews.apache.org/r/18655/#comment66922 Done. - Maxim Khutornenko On March 3, 2014, 11:26 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 3, 2014, 11:26 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-235 https://issues.apache.org/jira/browse/AURORA-235 Repository: aurora Description --- Added an optional JobKey set filter into the TaskQuery. Diffs - src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 336e91b10dc25d761dfc4389ac27d9ac324c52c0 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0 src/main/thrift/org/apache/aurora/gen/api.thrift f9fc6bcb7fdc2380043cf673a4002886192c20c1 src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2 src/test/resources/org/apache/aurora/gen/api.thrift.md5 08c4c2a4717a1c827f4cef6405d78e7db5046a00 Diff: https://reviews.apache.org/r/18655/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18655: Added JobKey set into TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36073 --- Ship it! Ship It! - Bill Farner On March 4, 2014, 1:03 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 4, 2014, 1:03 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-235 https://issues.apache.org/jira/browse/AURORA-235 Repository: aurora Description --- Added an optional JobKey set filter into the TaskQuery. Diffs - src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 336e91b10dc25d761dfc4389ac27d9ac324c52c0 src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0 src/main/thrift/org/apache/aurora/gen/api.thrift 2afbb4ce98e49332495d264218a7112bce8d450b src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 095cc4a881b16ab4d9e66b1e1f907fd781f8b0cb src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2 src/test/resources/org/apache/aurora/gen/api.thrift.md5 5cfa330f54c0297c84b8f41ee550a7bc6f163010 Diff: https://reviews.apache.org/r/18655/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Review Request 18655: Added JobKey set into TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-235 https://issues.apache.org/jira/browse/AURORA-235 Repository: aurora Description --- Added an optional JobKey set filter into the TaskQuery. Diffs - src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0 src/main/thrift/org/apache/aurora/gen/api.thrift f9fc6bcb7fdc2380043cf673a4002886192c20c1 src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2 src/test/resources/org/apache/aurora/gen/api.thrift.md5 08c4c2a4717a1c827f4cef6405d78e7db5046a00 Diff: https://reviews.apache.org/r/18655/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18655: Added JobKey set into TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review35885 --- src/main/java/org/apache/aurora/scheduler/base/JobKeys.java https://reviews.apache.org/r/18655/#comment66696 Did you consider building this into from()? Looks like the 3 existing callers should be relatively easy to update. src/main/java/org/apache/aurora/scheduler/base/Query.java https://reviews.apache.org/r/18655/#comment66697 This should really be built into isJobScoped, having them behave differently is asking for bugs src/main/java/org/apache/aurora/scheduler/base/Query.java https://reviews.apache.org/r/18655/#comment66698 with the other changes, this can take over for the existing non-varargs variant src/main/java/org/apache/aurora/scheduler/base/Query.java https://reviews.apache.org/r/18655/#comment66699 byJobs, which should take over for byJob src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java https://reviews.apache.org/r/18655/#comment66701 Same issue as we saw with the introduction of slaveHosts - one field hides the other. Please fix. - Bill Farner On March 1, 2014, 12:54 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 1, 2014, 12:54 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-235 https://issues.apache.org/jira/browse/AURORA-235 Repository: aurora Description --- Added an optional JobKey set filter into the TaskQuery. Diffs - src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0 src/main/thrift/org/apache/aurora/gen/api.thrift f9fc6bcb7fdc2380043cf673a4002886192c20c1 src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2 src/test/resources/org/apache/aurora/gen/api.thrift.md5 08c4c2a4717a1c827f4cef6405d78e7db5046a00 Diff: https://reviews.apache.org/r/18655/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Re: Review Request 18655: Added JobKey set into TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review35889 --- src/main/java/org/apache/aurora/scheduler/base/JobKeys.java https://reviews.apache.org/r/18655/#comment66705 from is currently intended to unambiguously give a single IJobKey instance derived from role/env/name. I am not sure exposing a SetIJobKey would be a good idea. - Maxim Khutornenko On March 1, 2014, 12:54 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/ --- (Updated March 1, 2014, 12:54 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-235 https://issues.apache.org/jira/browse/AURORA-235 Repository: aurora Description --- Added an optional JobKey set filter into the TaskQuery. Diffs - src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 5f684bc1f19470a8df4df167aa5c15ad6b9c9f95 src/main/java/org/apache/aurora/scheduler/base/Query.java d6f27fd6b8029401c918f942253beb59b6a71ddf src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 421b33023e3b443d579685f434a4e09957b1c6e0 src/main/thrift/org/apache/aurora/gen/api.thrift f9fc6bcb7fdc2380043cf673a4002886192c20c1 src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 0c1b144bf22f1bf400da04bd5826a04891dfada2 src/test/resources/org/apache/aurora/gen/api.thrift.md5 08c4c2a4717a1c827f4cef6405d78e7db5046a00 Diff: https://reviews.apache.org/r/18655/diff/ Testing --- /build-support/jenkins/build.sh Thanks, Maxim Khutornenko
