Re: Review Request 18658: GZIP HTTP thrift API responses
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18658/ --- (Updated March 25, 2014, 10:28 a.m.) Review request for Aurora, Suman Karumuri and Bill Farner. Changes --- Go back to just wrapping the thrift API. Repository: aurora Description --- GZIP HTTP thrift API responses Diffs (updated) - src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 12113532eb062308af3c43458661c7b43b23237f src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d Diff: https://reviews.apache.org/r/18658/diff/ Testing --- Verified API responses are gzipped. Thanks, Kevin Sweeney
Re: Review Request 18658: GZIP HTTP thrift API responses
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18658/ --- (Updated March 25, 2014, 11:06 a.m.) Review request for Aurora, Suman Karumuri and Bill Farner. Changes --- Fix the diff Repository: aurora Description --- GZIP HTTP thrift API responses Diffs (updated) - build-support/tools/list-missing-shipits 69225732eeced6e2a41bda5e675e6f109e041656 build.gradle f3beb00f69f40e81c1be80f5f6ade84720ae config/checkstyle/checkstyle.xml 99f48b2792eb8a7619423088a3ab40fb3a3df772 src/main/java/org/apache/aurora/GuiceUtils.java 9342d4fe7638cbf16233e6f1267b94cd910b6c84 src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java be67e7d1f93584542a645ada4499e26ab9bb1fb4 src/main/java/org/apache/aurora/scheduler/async/HistoryPruner.java 5bf9838e56f074fc5e66ace2a9c4e7bc50d1480f src/main/java/org/apache/aurora/scheduler/base/Jobs.java 3f027032a785810bddfb3ff4dd4e472989c9493f src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java b3f3124a73b56e48339f89dbd3b1067527757d04 src/main/java/org/apache/aurora/scheduler/http/StructDump.java b7a33a6e8a3c01a45cdc02b28077523f102f282b src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 071c4fcf96099819aac6276306034434e3eec879 src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 7371c12eb1efc3686582fdbbcb5e3b404bac61a6 src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 15d1c1f5c2dc8161d9a203a98e4c40b123b93938 src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 543536384bf9630fb93e7db5ba7286c117638199 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java ee81b494b9b4dff9839a9e32c9b81fa8ef898e1b src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 12113532eb062308af3c43458661c7b43b23237f src/main/python/apache/aurora/client/BUILD fafd055d8c51c24c8ded56f4316b7f6ddd96ac28 src/main/python/apache/aurora/client/api/scheduler_client.py f770df7a23779f919cd11cc28b2aaf7cfdf9c5a1 src/main/python/apache/aurora/client/api/sla.py 7b4d75c6bf39993737a681b70dd2ee93bfd23938 src/main/python/apache/aurora/client/cli/jobs.py 2e62519a0531b2c910bc2c0227fd835baee644f1 src/main/python/apache/aurora/client/cli/options.py 0e0bd45f9506e5dc729a24cd68b04b49650605b6 src/main/python/apache/aurora/client/cli/sla.py 62d13851787fd7a08fb1b9bb778e03b37aca3944 src/main/python/apache/aurora/client/commands/core.py 9977c725528086d3e8cf58de294adee542570411 src/main/python/apache/aurora/client/config.py 1fe5db429007850911f19517565d49b0518e8196 src/main/python/apache/aurora/client/hooks/hooked_api.py 6de81347e021a71fc6aef598e6933c440335c8bf src/main/python/apache/aurora/client/options.py b8278bdeeb777a1b6a72167100323fb177bc9636 src/main/python/apache/aurora/common/BUILD ce73f93b37d96c5667a6b9bef66b8e7521f0cd83 src/main/python/apache/aurora/executor/aurora_executor.py 28e50540f4a431b78fae21200599a55e64001bc1 src/main/python/apache/aurora/executor/common/kill_manager.py 0d0d553932bd3504bd4ee967bb860531c03c3657 src/main/python/apache/aurora/executor/common/status_checker.py f94042c0e90e1b36bbb6766fcdc1c474a2e2bc05 src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py 3143c6afe8adeb18fac44e92f94b9860753c3eb0 src/main/python/apache/thermos/README.md 4bfefd37163dfbc5947acc7adc52f57c95cd174f src/main/python/apache/thermos/core/BUILD 6da1a61f328edaa0eed2fe02c8c5bdcdbda751c3 src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st 39c1d9527bff88ff191233629babfd6e6035d4e7 src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d src/main/thrift/org/apache/aurora/gen/api.thrift e64f844cbd58d92621c6c21b896a9baf0c5a5f07 src/test/java/org/apache/aurora/scheduler/async/HistoryPrunerTest.java f7c9e5ed408b44e93df8cfff9c9beeb2f717b2d2 src/test/java/org/apache/aurora/scheduler/base/JobsTest.java 6524e2441d25de6573190866a8559be620961330 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java d2e1166860a4c3241b9f7f3e1fd420fb42133d45 src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java 359f5d44e030a53cedd612a350b161b392d929c4 src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 77380d9aaab99a9ad739bbc22251232354133c8d src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java b85e270d748601c0e979581cde4b1ce273cb2ee2 src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 77c292d7fc985f385f36979fa90a832de565fef7 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 60df209150f29e2658c47d81042bd36c57d5afef src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java
Re: Review Request 18658: GZIP HTTP thrift API responses
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18658/ --- (Updated March 25, 2014, 11:08 a.m.) Review request for Aurora, Suman Karumuri and Bill Farner. Changes --- Really fix the diff Repository: aurora Description --- GZIP HTTP thrift API responses Diffs (updated) - src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 12113532eb062308af3c43458661c7b43b23237f src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d Diff: https://reviews.apache.org/r/18658/diff/ Testing --- Verified API responses are gzipped. Thanks, Kevin Sweeney
Re: Review Request 18658: GZIP HTTP thrift API responses
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18658/#review37924 --- Update or discard? - Bill Farner On March 1, 2014, 1:27 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18658/ --- (Updated March 1, 2014, 1:27 a.m.) Review request for Aurora, Suman Karumuri and Bill Farner. Repository: aurora Description --- GZIP HTTP thrift API responses Diffs - src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 12113532eb062308af3c43458661c7b43b23237f src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 94189642a4f35aa0cad8176589cfbd84964c2e14 Diff: https://reviews.apache.org/r/18658/diff/ Testing --- Verified API responses are gzipped. Thanks, Kevin Sweeney
Re: Review Request 18658: GZIP HTTP thrift API responses
On March 1, 2014, 5:23 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java, line 40
https://reviews.apache.org/r/18658/diff/2/?file=507574#file507574line40
I can't think of a good reason to not apply this to /, can you? If so,
the filter should probably be applied in a different module.
Kevin Sweeney wrote:
From the docs:
* This filter will gzip the content of a response iff: ul
* liThe filter is mapped to a matching path/li
* liThe response status code is =200 and 300
* liThe content length is unknown or more than the
codeminGzipSize/code initParameter or the minGzipSize is 0(default)/li
* liThe content-type is in the comma separated list of mimeTypes set
in the codemimeTypes/code initParameter or
* if no mimeTypes are defined the content-type is not
application/gzip/li
* liNo content-encoding is specified by the resource/li
* /ul
I'm not certain that generally applies to the whole application (/health
for example probably shouldn't be gzipped).
Bill Farner wrote:
That doc defines the server-dependent details needed to enable gzip. The
client still needs to set 'accept-encoding', which i think does make it apply
universally.
From org.mortbay.servlet.GzipFilter:
String ae = request.getHeader(accept-encoding);
Boolean gzip=(Boolean)request.getAttribute(GzipFilter);
if (ae != null ae.indexOf(gzip)=0
!response.containsHeader(Content-Encoding)
(gzip==null || gzip.booleanValue())
!HEAD.equalsIgnoreCase(request.getMethod()))
{
// snip
}
else
{
super.doFilter(request,response,chain);
}
+1 to applying gzip encoding universally.
- Suman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18658/#review35907
---
On March 1, 2014, 1:27 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18658/
---
(Updated March 1, 2014, 1:27 a.m.)
Review request for Aurora, Suman Karumuri and Bill Farner.
Repository: aurora
Description
---
GZIP HTTP thrift API responses
Diffs
-
src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java
12113532eb062308af3c43458661c7b43b23237f
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
94189642a4f35aa0cad8176589cfbd84964c2e14
Diff: https://reviews.apache.org/r/18658/diff/
Testing
---
Verified API responses are gzipped.
Thanks,
Kevin Sweeney
Re: Review Request 18658: GZIP HTTP thrift API responses
On March 1, 2014, 9:23 a.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java, line 40 https://reviews.apache.org/r/18658/diff/2/?file=507574#file507574line40 I can't think of a good reason to not apply this to /, can you? If so, the filter should probably be applied in a different module. From the docs: * This filter will gzip the content of a response iff: ul * liThe filter is mapped to a matching path/li * liThe response status code is =200 and 300 * liThe content length is unknown or more than the codeminGzipSize/code initParameter or the minGzipSize is 0(default)/li * liThe content-type is in the comma separated list of mimeTypes set in the codemimeTypes/code initParameter or * if no mimeTypes are defined the content-type is not application/gzip/li * liNo content-encoding is specified by the resource/li * /ul I'm not certain that generally applies to the whole application (/health for example probably shouldn't be gzipped). - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18658/#review35907 --- On Feb. 28, 2014, 5:27 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18658/ --- (Updated Feb. 28, 2014, 5:27 p.m.) Review request for Aurora, Suman Karumuri and Bill Farner. Repository: aurora Description --- GZIP HTTP thrift API responses Diffs - src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 12113532eb062308af3c43458661c7b43b23237f src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 94189642a4f35aa0cad8176589cfbd84964c2e14 Diff: https://reviews.apache.org/r/18658/diff/ Testing --- Verified API responses are gzipped. Thanks, Kevin Sweeney
Review Request 18658: GZIP HTTP thrift API responses
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18658/ --- Review request for Aurora, Suman Karumuri and Bill Farner. Repository: aurora Description --- GZIP HTTP thrift API responses Diffs - src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java 12113532eb062308af3c43458661c7b43b23237f src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 94189642a4f35aa0cad8176589cfbd84964c2e14 Diff: https://reviews.apache.org/r/18658/diff/ Testing --- Verified API responses are gzipped. Thanks, Kevin Sweeney
