Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- (Updated March 27, 2014, 7:06 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- (Updated March 27, 2014, 6:57 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

> On March 26, 2014, 11:52 p.m., Bill Farner wrote: > > src/main/python/apache/aurora/client/cli/quota.py, line 70 > > > > > > DRY: > > > > quota_result = resp.result.getQuotaResult > > > > apply libar

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38678 --- Ship it! src/main/python/apache/aurora/client/cli/quota.py

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- (Updated March 26, 2014, 10 p.m.) Review request for Aurora, Mark Chu-Carroll a

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- (Updated March 24, 2014, 8:47 p.m.) Review request for Aurora, Kevin Sweeney, M

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

> On March 21, 2014, 11:53 p.m., Bill Farner wrote: > > src/test/python/apache/aurora/client/cli/test_quota.py, line 47 > > > > > > > Currently, the mocked calls can't detect renamed and missing thrift > > structs. > >

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38235 --- src/test/python/apache/aurora/client/cli/test_quota.py

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- (Updated March 21, 2014, 10:14 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

> On March 21, 2014, 6:27 p.m., Mark Chu-Carroll wrote: > > Just FYI: the client unit tests weren't intended to detect stuff like this. > > The intention of those tests is just to verify that the client logic works > > - meaning that the client sends the API calls that we expect it to. If an

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38205 --- Ship it! Ship It! - Mark Chu-Carroll On March 20, 2014, 10:39 p.

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

> On March 21, 2014, 11:58 a.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/cli/quota.py, line 71 > > > > > > Maybe I just read weird stuff, but this wording is uncomfortable: > > "consumption" is

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38148 --- Please update the end-to-end test - it will cheaply and expressively

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38147 --- Just FYI: the client unit tests weren't intended to detect stuff lik

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/#review38085 --- src/main/python/apache/aurora/client/cli/quota.py

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- (Updated March 21, 2014, 2:39 a.m.) Review request for Aurora, Kevin Sweeney, M

Review Request 19509: Now consuming nonProd consumption from the new getQuota API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509/ --- Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman.