Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-30 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19565/ --- (Updated March 31, 2014, 12:36 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-30 Thread Suman Karumuri
On March 26, 2014, 11:46 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 52 https://reviews.apache.org/r/19565/diff/2-3/?file=535008#file535008line52 Same story as before, why not just use one field if they follow each

Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-27 Thread Suman Karumuri
On March 26, 2014, 11:46 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 65 https://reviews.apache.org/r/19565/diff/2-3/?file=535008#file535008line65 Are there specific browsers we're stretching for compatibility with here?

Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-27 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19565/ --- (Updated March 27, 2014, 9:04 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-27 Thread Bill Farner
On March 26, 2014, 11:46 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 52 https://reviews.apache.org/r/19565/diff/2-3/?file=535008#file535008line52 Same story as before, why not just use one field if they follow each

Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-27 Thread Bill Farner
On March 26, 2014, 5:27 p.m., Bill Farner wrote: I tried this out locally, and the browser back button appears to be broken when i click on a role, then a job. Does this repro for you? Also, the arrangement of the title, breadcrumbs, and [Show/Hide Resource Consumption] was

Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19565/#review38627 --- I tried this out locally, and the browser back button appears to be

Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-26 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19565/ --- (Updated March 26, 2014, 11:01 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19565/#review38677 ---

Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-24 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19565/#review38325 --- src/main/java/org/apache/aurora/scheduler/http/ServletModule.java

Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-24 Thread Suman Karumuri
On March 24, 2014, 6:35 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 225 https://reviews.apache.org/r/19565/diff/1/?file=533620#file533620line225 This method makes for difficult-to-read call-sites. How about silent=true for

Re: Review Request 19565: Role and Role/env pages for Scheduler

2014-03-24 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19565/ --- (Updated March 25, 2014, 2:55 a.m.) Review request for Aurora, Kevin Sweeney

Review Request 19565: Role and Role/env pages for Scheduler

2014-03-22 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19565/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-39