Re: Review Request 19756: Filtering safe domain results by hosts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19756/#review39288 --- src/main/python/apache/aurora/client/api/sla.py https://reviews.apache.org/r/19756/#comment71638 you do nothing to protect that self._host_filter is not None. either do self._host_filter = hosts or [], or guard against it here. for host in None: ... print host ... Traceback (most recent call last): File stdin, line 1, in module TypeError: 'NoneType' object is not iterable - Brian Wickman On March 27, 2014, 10:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19756/ --- (Updated March 27, 2014, 10:58 p.m.) Review request for Aurora and Brian Wickman. Bugs: AURORA-295 https://issues.apache.org/jira/browse/AURORA-295 Repository: aurora Description --- Filtering safe domain results by hosts. Diffs - src/main/python/apache/aurora/client/api/sla.py a61509231ccf3f9b8d35bd35b1ba36a5775f4ad5 src/main/python/apache/aurora/client/commands/admin.py f411b7922c39067ca6d75d6bee361de13e379a89 src/test/python/apache/aurora/client/api/test_sla.py 74c0ac385492ef68b167d7b32d30ff3c7da5df1b src/test/python/apache/aurora/client/commands/test_admin_sla.py 2f09cb1990edd9a66da6d04a4ddba4182aa62cb9 Diff: https://reviews.apache.org/r/19756/diff/ Testing --- ./pants src/test/python:all local run Thanks, Maxim Khutornenko
Re: Review Request 19756: Filtering safe domain results by hosts.
On April 2, 2014, 4:59 p.m., Brian Wickman wrote: src/main/python/apache/aurora/client/api/sla.py, line 213 https://reviews.apache.org/r/19756/diff/1/?file=539116#file539116line213 you do nothing to protect that self._host_filter is not None. either do self._host_filter = hosts or [], or guard against it here. for host in None: ... print host ... Traceback (most recent call last): File stdin, line 1, in module TypeError: 'NoneType' object is not iterable Good point. It's normally protected by the admin command but still possible at the api level. Fixed and added a test. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19756/#review39288 --- On March 27, 2014, 10:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19756/ --- (Updated March 27, 2014, 10:58 p.m.) Review request for Aurora and Brian Wickman. Bugs: AURORA-295 https://issues.apache.org/jira/browse/AURORA-295 Repository: aurora Description --- Filtering safe domain results by hosts. Diffs - src/main/python/apache/aurora/client/api/sla.py a61509231ccf3f9b8d35bd35b1ba36a5775f4ad5 src/main/python/apache/aurora/client/commands/admin.py f411b7922c39067ca6d75d6bee361de13e379a89 src/test/python/apache/aurora/client/api/test_sla.py 74c0ac385492ef68b167d7b32d30ff3c7da5df1b src/test/python/apache/aurora/client/commands/test_admin_sla.py 2f09cb1990edd9a66da6d04a4ddba4182aa62cb9 Diff: https://reviews.apache.org/r/19756/diff/ Testing --- ./pants src/test/python:all local run Thanks, Maxim Khutornenko
Re: Review Request 19756: Filtering safe domain results by hosts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19756/#review39329 --- Ship it! Ship It! - Brian Wickman On April 2, 2014, 5:18 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19756/ --- (Updated April 2, 2014, 5:18 p.m.) Review request for Aurora and Brian Wickman. Bugs: AURORA-295 https://issues.apache.org/jira/browse/AURORA-295 Repository: aurora Description --- Filtering safe domain results by hosts. Diffs - src/main/python/apache/aurora/client/api/sla.py 45153c743deffd514d3adf7417ef24b8d4e3f338 src/main/python/apache/aurora/client/commands/admin.py f411b7922c39067ca6d75d6bee361de13e379a89 src/test/python/apache/aurora/client/api/test_sla.py ff11b1f70ded3fec960acf1ddce82a0fe55611e8 src/test/python/apache/aurora/client/commands/test_admin_sla.py 2f09cb1990edd9a66da6d04a4ddba4182aa62cb9 Diff: https://reviews.apache.org/r/19756/diff/ Testing --- ./pants src/test/python:all local run Thanks, Maxim Khutornenko
Re: Review Request 19756: Filtering safe domain results by hosts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19756/ --- (Updated April 2, 2014, 7:21 p.m.) Review request for Aurora and Brian Wickman. Changes --- Rebased. Bugs: AURORA-295 https://issues.apache.org/jira/browse/AURORA-295 Repository: aurora Description --- Filtering safe domain results by hosts. Diffs (updated) - src/main/python/apache/aurora/client/api/sla.py 45153c743deffd514d3adf7417ef24b8d4e3f338 src/main/python/apache/aurora/client/commands/admin.py f411b7922c39067ca6d75d6bee361de13e379a89 src/test/python/apache/aurora/client/api/test_sla.py ff11b1f70ded3fec960acf1ddce82a0fe55611e8 src/test/python/apache/aurora/client/commands/test_admin_sla.py 2f09cb1990edd9a66da6d04a4ddba4182aa62cb9 Diff: https://reviews.apache.org/r/19756/diff/ Testing --- ./pants src/test/python:all local run Thanks, Maxim Khutornenko
Review Request 19756: Filtering safe domain results by hosts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19756/ --- Review request for Aurora and Brian Wickman. Bugs: AURORA-295 https://issues.apache.org/jira/browse/AURORA-295 Repository: aurora Description --- Filtering safe domain results by hosts. Diffs - src/main/python/apache/aurora/client/api/sla.py a61509231ccf3f9b8d35bd35b1ba36a5775f4ad5 src/main/python/apache/aurora/client/commands/admin.py f411b7922c39067ca6d75d6bee361de13e379a89 src/test/python/apache/aurora/client/api/test_sla.py 74c0ac385492ef68b167d7b32d30ff3c7da5df1b src/test/python/apache/aurora/client/commands/test_admin_sla.py 2f09cb1990edd9a66da6d04a4ddba4182aa62cb9 Diff: https://reviews.apache.org/r/19756/diff/ Testing --- ./pants src/test/python:all local run Thanks, Maxim Khutornenko
