Re: Review Request 20246: AURORA-299: use system thrift if available

2014-04-19 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20246/#review40847
---

Ship it!


Ship It!

- Bill Farner


On April 19, 2014, 3:35 a.m., Jake Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20246/
> ---
> 
> (Updated April 19, 2014, 3:35 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-299
> https://issues.apache.org/jira/browse/AURORA-299
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-299: use system thrift if available
> 
> Updates gradle bootstrapThrift to use a system installed Thrift if available
> and if it is the same version we are currently using.
> 
> 
> Diffs
> -
> 
>   build.gradle ea488414d366ece89ba25e42b98f6ad7ddbf3378 
> 
> Diff: https://reviews.apache.org/r/20246/diff/
> 
> 
> Testing
> ---
> 
> ran build with and without Thrift installed
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>

Re: Review Request 20246: AURORA-299: use system thrift if available

2014-04-18 Thread Jake Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20246/
---

(Updated April 19, 2014, 3:35 a.m.)


Review request for Aurora and Bill Farner.


Changes
---

sorry for the delay, addressed all comments (nice call with 
.execute().text.trim(), hadnt thought of that route)


Bugs: AURORA-299
https://issues.apache.org/jira/browse/AURORA-299


Repository: aurora


Description
---

AURORA-299: use system thrift if available

Updates gradle bootstrapThrift to use a system installed Thrift if available
and if it is the same version we are currently using.


Diffs (updated)
-

  build.gradle ea488414d366ece89ba25e42b98f6ad7ddbf3378 

Diff: https://reviews.apache.org/r/20246/diff/


Testing
---

ran build with and without Thrift installed


Thanks,

Jake Farrell

Re: Review Request 20246: AURORA-299: use system thrift if available

2014-04-18 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20246/#review40811
---


Ping?  Once this is in, i'll update and proceed with 
https://reviews.apache.org/r/20238/

- Bill Farner


On April 11, 2014, 1:29 a.m., Jake Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20246/
> ---
> 
> (Updated April 11, 2014, 1:29 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-299
> https://issues.apache.org/jira/browse/AURORA-299
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-299: use system thrift if available
> 
> Updates gradle bootstrapThrift to use a system installed Thrift if available
> and if it is the same version we are currently using.
> 
> 
> Diffs
> -
> 
>   build.gradle cdcc0158079bc91b5c10fad4e7c80d2f98da227f 
> 
> Diff: https://reviews.apache.org/r/20246/diff/
> 
> 
> Testing
> ---
> 
> ran build with and without Thrift installed
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>

Re: Review Request 20246: AURORA-299: use system thrift if available

2014-04-15 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20246/#review40422
---


Thanks for pushing on this.  I went down this road and backed out since i 
didn't think of catching the exception.


build.gradle


please remove trailing whitespace here and elsewhere



build.gradle


When i ventured down this path, i discovered a more concise way to run a 
command and capture output.  Try this out:

  def output = "thrift --version".execute().text.trim()
  if (output == "Thrift version ${thriftVersion}") {
...
  }



build.gradle


Please add a comment here detailing the error you expect.  It would also be 
nice to be more specific than Exception.  With the suggestion above, at least, 
i think you want IOException.


- Bill Farner


On April 11, 2014, 1:29 a.m., Jake Farrell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20246/
> ---
> 
> (Updated April 11, 2014, 1:29 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-299
> https://issues.apache.org/jira/browse/AURORA-299
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> AURORA-299: use system thrift if available
> 
> Updates gradle bootstrapThrift to use a system installed Thrift if available
> and if it is the same version we are currently using.
> 
> 
> Diffs
> -
> 
>   build.gradle cdcc0158079bc91b5c10fad4e7c80d2f98da227f 
> 
> Diff: https://reviews.apache.org/r/20246/diff/
> 
> 
> Testing
> ---
> 
> ran build with and without Thrift installed
> 
> 
> Thanks,
> 
> Jake Farrell
> 
>

Review Request 20246: AURORA-299: use system thrift if available

2014-04-10 Thread Jake Farrell 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20246/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-299
https://issues.apache.org/jira/browse/AURORA-299


Repository: aurora


Description
---

AURORA-299: use system thrift if available

Updates gradle bootstrapThrift to use a system installed Thrift if available
and if it is the same version we are currently using.


Diffs
-

  build.gradle cdcc0158079bc91b5c10fad4e7c80d2f98da227f 

Diff: https://reviews.apache.org/r/20246/diff/


Testing
---

ran build with and without Thrift installed


Thanks,

Jake Farrell