Re: Review Request 20394: Add return code to task/process pages
On May 6, 2014, 6:50 p.m., Brian Wickman wrote: david -- should i submit this? i just realized that you likely don't have commit privileges, so i think this is up to me to submit. Yup, that would be cool. I'm not a committer yet. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20394/#review42339 --- On April 28, 2014, 10:48 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20394/ --- (Updated April 28, 2014, 10:48 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Add return code to task/process pages Diffs - src/main/python/apache/thermos/observer/http/http_observer.py 118bd2f4889c520683ba04b554d699ecf0bc20ce src/main/python/apache/thermos/observer/http/templates/process.tpl a7fb90d4decec01cb95f9e5d42288eaae9d71edf src/main/python/apache/thermos/observer/http/templates/task.tpl b71c80d11255c111873a46b99478c36d39cc8733 src/main/python/apache/thermos/observer/task_observer.py ea40bfa610e2af90904487c809bc83b8b5f214d9 Diff: https://reviews.apache.org/r/20394/diff/ Testing --- Thanks, David McLaughlin
Re: Review Request 20394: Add return code to task/process pages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20394/#review42339 --- david -- should i submit this? i just realized that you likely don't have commit privileges, so i think this is up to me to submit. - Brian Wickman On April 28, 2014, 10:48 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20394/ --- (Updated April 28, 2014, 10:48 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Add return code to task/process pages Diffs - src/main/python/apache/thermos/observer/http/http_observer.py 118bd2f4889c520683ba04b554d699ecf0bc20ce src/main/python/apache/thermos/observer/http/templates/process.tpl a7fb90d4decec01cb95f9e5d42288eaae9d71edf src/main/python/apache/thermos/observer/http/templates/task.tpl b71c80d11255c111873a46b99478c36d39cc8733 src/main/python/apache/thermos/observer/task_observer.py ea40bfa610e2af90904487c809bc83b8b5f214d9 Diff: https://reviews.apache.org/r/20394/diff/ Testing --- Thanks, David McLaughlin
Re: Review Request 20394: Add return code to task/process pages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20394/ --- (Updated April 28, 2014, 10:48 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Add return code to task/process pages Diffs (updated) - src/main/python/apache/thermos/observer/http/http_observer.py 118bd2f4889c520683ba04b554d699ecf0bc20ce src/main/python/apache/thermos/observer/http/templates/process.tpl a7fb90d4decec01cb95f9e5d42288eaae9d71edf src/main/python/apache/thermos/observer/http/templates/task.tpl b71c80d11255c111873a46b99478c36d39cc8733 src/main/python/apache/thermos/observer/task_observer.py ea40bfa610e2af90904487c809bc83b8b5f214d9 Diff: https://reviews.apache.org/r/20394/diff/ Testing --- Thanks, David McLaughlin
Re: Review Request 20394: Add return code to task/process pages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20394/#review41336 --- Ship it! in the future it's customary to attach screenshots for UI changes. src/main/python/apache/thermos/observer/http/templates/task.tpl https://reviews.apache.org/r/20394/#comment74754 kill trailing ws - Brian Wickman On April 16, 2014, 9:38 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20394/ --- (Updated April 16, 2014, 9:38 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Add return code to task/process pages Diffs - src/main/python/apache/thermos/observer/http/http_observer.py 118bd2f4889c520683ba04b554d699ecf0bc20ce src/main/python/apache/thermos/observer/http/templates/process.tpl a7fb90d4decec01cb95f9e5d42288eaae9d71edf src/main/python/apache/thermos/observer/http/templates/task.tpl b71c80d11255c111873a46b99478c36d39cc8733 src/main/python/apache/thermos/observer/task_observer.py ea40bfa610e2af90904487c809bc83b8b5f214d9 Diff: https://reviews.apache.org/r/20394/diff/ Testing --- Thanks, David McLaughlin
Re: Review Request 20394: Add return code to task/process pages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20394/ --- (Updated April 16, 2014, 9:38 p.m.) Review request for Aurora and Brian Wickman. Repository: aurora Description --- Add return code to task/process pages Diffs - src/main/python/apache/thermos/observer/http/http_observer.py 118bd2f4889c520683ba04b554d699ecf0bc20ce src/main/python/apache/thermos/observer/http/templates/process.tpl a7fb90d4decec01cb95f9e5d42288eaae9d71edf src/main/python/apache/thermos/observer/http/templates/task.tpl b71c80d11255c111873a46b99478c36d39cc8733 src/main/python/apache/thermos/observer/task_observer.py ea40bfa610e2af90904487c809bc83b8b5f214d9 Diff: https://reviews.apache.org/r/20394/diff/ Testing --- Thanks, David McLaughlin
Review Request 20394: Add return code to task/process pages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20394/ --- Review request for Aurora. Repository: aurora Description --- Add return code to task/process pages Diffs - src/main/python/apache/thermos/observer/http/http_observer.py 118bd2f4889c520683ba04b554d699ecf0bc20ce src/main/python/apache/thermos/observer/http/templates/process.tpl a7fb90d4decec01cb95f9e5d42288eaae9d71edf src/main/python/apache/thermos/observer/http/templates/task.tpl b71c80d11255c111873a46b99478c36d39cc8733 src/main/python/apache/thermos/observer/task_observer.py ea40bfa610e2af90904487c809bc83b8b5f214d9 Diff: https://reviews.apache.org/r/20394/diff/ Testing --- Thanks, David McLaughlin
