Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Maxim Khutornenko
On April 22, 2014, 7:57 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java, line 65 https://reviews.apache.org/r/20398/diff/7/?file=562468#file562468line65 I'm still failing to see the upside of this enum. An obvious downside is that

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 23, 2014, 5:42 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Maxim Khutornenko
On April 23, 2014, 10:16 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 67 https://reviews.apache.org/r/20398/diff/8/?file=565882#file565882line67 You can save a good amount of wiring boilerplate if you use Guava's

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/#review41053 --- Ship it!

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 18, 2014, 6:47 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 18, 2014, 8:41 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 18, 2014, 8:43 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-17 Thread Maxim Khutornenko
On April 16, 2014, 11:57 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 71 https://reviews.apache.org/r/20398/diff/1/?file=560703#file560703line71 How about Multimap, ImmutableMultimap.Builder? Great idea. Done. On April 16,

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 17, 2014, 9:15 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-17 Thread Bill Farner
On April 16, 2014, 11:57 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 107 https://reviews.apache.org/r/20398/diff/1/?file=560703#file560703line107 You probably want to initialize stats with a non-default value, to avoid

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-17 Thread Maxim Khutornenko
On April 16, 2014, 11:57 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 107 https://reviews.apache.org/r/20398/diff/1/?file=560703#file560703line107 You probably want to initialize stats with a non-default value, to avoid

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 17, 2014, 11:31 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 17, 2014, 11:39 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-16 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/#review40606 ---

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-16 Thread Maxim Khutornenko
On April 16, 2014, 11:57 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 73 https://reviews.apache.org/r/20398/diff/1/?file=560703#file560703line73 I would find median really useful too. By median you mean JOB_UPTIME_50? On

Review Request 20398: Scheduler SLA metrics.

2014-04-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.