Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/#review44032 --- David, would you mind rebasing this patch? error: patch failed:

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/#review44057 --- The rebased patch does not pass checkstyle: ./gradlew -Pq clean

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-27 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 27, 2014, 10:37 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-27 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 27, 2014, 10:45 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-27 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 27, 2014, 10:45 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
On May 21, 2014, 7:06 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java, line 35 https://reviews.apache.org/r/21132/diff/3/?file=580759#file580759line35 relational Fixed. On May 21, 2014, 7:06 p.m., Kevin Sweeney wrote:

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 22, 2014, 6 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 22, 2014, 6 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/#review43743 --- Could you describe a bit details on what changes submitted with the

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread Kevin Sweeney
On May 22, 2014, 11:06 a.m., Henry Saputra wrote: Could you describe a bit details on what changes submitted with the patch? Maybe it makes sense to internal folks at Twitter but not useful for new/ external people This is the byproduct of a mailing list discussion here:

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread Henry Saputra
On May 22, 2014, 6:06 p.m., Henry Saputra wrote: Could you describe a bit details on what changes submitted with the patch? Maybe it makes sense to internal folks at Twitter but not useful for new/ external people Kevin Sweeney wrote: This is the byproduct of a mailing list

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 22, 2014, 6:26 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
On May 22, 2014, 6:06 p.m., Henry Saputra wrote: Could you describe a bit details on what changes submitted with the patch? Maybe it makes sense to internal folks at Twitter but not useful for new/ external people Kevin Sweeney wrote: This is the byproduct of a mailing list

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/#review43377 --- Ship it!

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-20 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/#review43518 --- Ship it! Ship It! - Maxim Khutornenko On May 13, 2014, 6:27

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-20 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 20, 2014, 8:20 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-20 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 20, 2014, 8:33 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-20 Thread David McLaughlin
On May 16, 2014, 4 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java, line 46 https://reviews.apache.org/r/21132/diff/3/?file=580760#file580760line46 Reword? Done. On May 16, 2014, 4 p.m., Maxim Khutornenko wrote:

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-19 Thread Maxim Khutornenko
On May 16, 2014, 4 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java, line 43 https://reviews.apache.org/r/21132/diff/3/?file=580759#file580759line43 Breaking the abstraction by having a JobKeyMapper here is quite unfortunate.

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/#review43185 ---

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-16 Thread David McLaughlin
On May 16, 2014, 4 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java, line 43 https://reviews.apache.org/r/21132/diff/3/?file=580759#file580759line43 Breaking the abstraction by having a JobKeyMapper here is quite unfortunate.

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-15 Thread David McLaughlin
On May 7, 2014, 9:01 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml, line 8 https://reviews.apache.org/r/21132/diff/1/?file=575755#file575755line8 Re: style, for some reason the lack of indent here doesn't sit well with me,

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 13, 2014, 5:49 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 13, 2014, 5:49 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-13 Thread David McLaughlin
On May 12, 2014, 8:16 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java, line 108 https://reviews.apache.org/r/21132/diff/2/?file=577940#file577940line108 this function would help cut down a bunch of redundancy in this class:

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-13 Thread Bill Farner
On May 12, 2014, 8:16 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java, line 104 https://reviews.apache.org/r/21132/diff/2/?file=577940#file577940line104 s/final //, applies to ~all test cases David McLaughlin wrote: So

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-13 Thread David McLaughlin
On May 12, 2014, 8:16 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java, line 54 https://reviews.apache.org/r/21132/diff/2/?file=577925#file577925line54 Formatting nit: TODO(davmclau) as opposed to:

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 13, 2014, 6:27 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/#review42427 ---

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-12 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 9, 2014, 11:47 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-12 Thread David McLaughlin
On May 7, 2014, 9:01 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java, line 35 https://reviews.apache.org/r/21132/diff/1/?file=575743#file575743line35 please doc done. On May 7, 2014, 9:01 p.m., Bill Farner wrote:

Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-06 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Bill Farner.