Re: Review Request 21352: Fix regression causing scheduling rate limiter to not be honored.

2014-05-13 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21352/#review42858
---

Ship it!


Ship It!

- Kevin Sweeney


On May 13, 2014, 11:13 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21352/
> ---
> 
> (Updated May 13, 2014, 11:13 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-416
> https://issues.apache.org/jira/browse/AURORA-416
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Since this would have been caught by findbugs when introduced, i decided to 
> configure findbugs on our build as added prevention going forward.
> 
> I also addressed a few findbugs warnings which took fewer characters to 
> exclude than to fix.
> 
> 
> Diffs
> -
> 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   config/findbugs/excludeFilter.xml PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
> ada5eafdf484f733c07277754833313d5e7bdc4b 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> ddbb02560bb8fb94dafe26c1a66c767e9a3a863b 
>   src/test/java/org/apache/aurora/scheduler/async/TaskGroupsTest.java 
> e23ab5cd49a52f3004baa4e30462c6b028931371 
>   src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 
> a9b85d0983dcfee89101a5e774ba86ee11708c68 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java 
> de5cdcf7a16f71f1815b0f6de6100eaf42c76cdd 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  47d2fd6d8a34cb14d68894e14c147709373e3572 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> e212174ed089fdcf28fa679318fe216917a40b99 
> 
> Diff: https://reviews.apache.org/r/21352/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 21352: Fix regression causing scheduling rate limiter to not be honored.

2014-05-13 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21352/#review42852
---



config/findbugs/excludeFilter.xml


You should be able to add a java namespace to the .thrift file here (one 
already exists for python)


- Kevin Sweeney


On May 12, 2014, 5:06 p.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21352/
> ---
> 
> (Updated May 12, 2014, 5:06 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-416
> https://issues.apache.org/jira/browse/AURORA-416
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Since this would have been caught by findbugs when introduced, i decided to 
> configure findbugs on our build as added prevention going forward.
> 
> I also addressed a few findbugs warnings which took fewer characters to 
> exclude than to fix.
> 
> 
> Diffs
> -
> 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   config/findbugs/excludeFilter.xml PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
> ada5eafdf484f733c07277754833313d5e7bdc4b 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> ddbb02560bb8fb94dafe26c1a66c767e9a3a863b 
>   src/test/java/org/apache/aurora/scheduler/async/TaskGroupsTest.java 
> e23ab5cd49a52f3004baa4e30462c6b028931371 
>   src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 
> a9b85d0983dcfee89101a5e774ba86ee11708c68 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java 
> de5cdcf7a16f71f1815b0f6de6100eaf42c76cdd 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  47d2fd6d8a34cb14d68894e14c147709373e3572 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> e212174ed089fdcf28fa679318fe216917a40b99 
> 
> Diff: https://reviews.apache.org/r/21352/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 21352: Fix regression causing scheduling rate limiter to not be honored.

2014-05-13 Thread Kevin Sweeney 


> On May 13, 2014, 11:05 a.m., Kevin Sweeney wrote:
> > config/findbugs/excludeFilter.xml, line 9
> > 
> >
> > You should be able to add a java namespace to the .thrift file here 
> > (one already exists for python)
> 
> Bill Farner wrote:
> Punting on this.  I'd rather they just weren't generated for java, tbh.

Mind dropping a TODO to exclude them in build.gradle?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21352/#review42852
---


On May 13, 2014, 11:13 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21352/
> ---
> 
> (Updated May 13, 2014, 11:13 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-416
> https://issues.apache.org/jira/browse/AURORA-416
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Since this would have been caught by findbugs when introduced, i decided to 
> configure findbugs on our build as added prevention going forward.
> 
> I also addressed a few findbugs warnings which took fewer characters to 
> exclude than to fix.
> 
> 
> Diffs
> -
> 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   config/findbugs/excludeFilter.xml PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
> ada5eafdf484f733c07277754833313d5e7bdc4b 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> ddbb02560bb8fb94dafe26c1a66c767e9a3a863b 
>   src/test/java/org/apache/aurora/scheduler/async/TaskGroupsTest.java 
> e23ab5cd49a52f3004baa4e30462c6b028931371 
>   src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 
> a9b85d0983dcfee89101a5e774ba86ee11708c68 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java 
> de5cdcf7a16f71f1815b0f6de6100eaf42c76cdd 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  47d2fd6d8a34cb14d68894e14c147709373e3572 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> e212174ed089fdcf28fa679318fe216917a40b99 
> 
> Diff: https://reviews.apache.org/r/21352/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 21352: Fix regression causing scheduling rate limiter to not be honored.

2014-05-13 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21352/
---

(Updated May 13, 2014, 6:13 p.m.)


Review request for Aurora, David McLaughlin and Maxim Khutornenko.


Bugs: AURORA-416
https://issues.apache.org/jira/browse/AURORA-416


Repository: aurora


Description
---

Since this would have been caught by findbugs when introduced, i decided to 
configure findbugs on our build as added prevention going forward.

I also addressed a few findbugs warnings which took fewer characters to exclude 
than to fix.


Diffs (updated)
-

  build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
  config/findbugs/excludeFilter.xml PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
ada5eafdf484f733c07277754833313d5e7bdc4b 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
ddbb02560bb8fb94dafe26c1a66c767e9a3a863b 
  src/test/java/org/apache/aurora/scheduler/async/TaskGroupsTest.java 
e23ab5cd49a52f3004baa4e30462c6b028931371 
  src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 
a9b85d0983dcfee89101a5e774ba86ee11708c68 
  src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java 
de5cdcf7a16f71f1815b0f6de6100eaf42c76cdd 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 47d2fd6d8a34cb14d68894e14c147709373e3572 
  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
e212174ed089fdcf28fa679318fe216917a40b99 

Diff: https://reviews.apache.org/r/21352/diff/


Testing
---

./gradlew build


Thanks,

Bill Farner

Re: Review Request 21352: Fix regression causing scheduling rate limiter to not be honored.

2014-05-13 Thread Bill Farner 


> On May 13, 2014, 6:05 p.m., Kevin Sweeney wrote:
> > config/findbugs/excludeFilter.xml, line 9
> > 
> >
> > You should be able to add a java namespace to the .thrift file here 
> > (one already exists for python)

Punting on this.  I'd rather they just weren't generated for java, tbh.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21352/#review42852
---


On May 13, 2014, 12:06 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21352/
> ---
> 
> (Updated May 13, 2014, 12:06 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-416
> https://issues.apache.org/jira/browse/AURORA-416
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Since this would have been caught by findbugs when introduced, i decided to 
> configure findbugs on our build as added prevention going forward.
> 
> I also addressed a few findbugs warnings which took fewer characters to 
> exclude than to fix.
> 
> 
> Diffs
> -
> 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   config/findbugs/excludeFilter.xml PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
> ada5eafdf484f733c07277754833313d5e7bdc4b 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> ddbb02560bb8fb94dafe26c1a66c767e9a3a863b 
>   src/test/java/org/apache/aurora/scheduler/async/TaskGroupsTest.java 
> e23ab5cd49a52f3004baa4e30462c6b028931371 
>   src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 
> a9b85d0983dcfee89101a5e774ba86ee11708c68 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java 
> de5cdcf7a16f71f1815b0f6de6100eaf42c76cdd 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  47d2fd6d8a34cb14d68894e14c147709373e3572 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> e212174ed089fdcf28fa679318fe216917a40b99 
> 
> Diff: https://reviews.apache.org/r/21352/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 21352: Fix regression causing scheduling rate limiter to not be honored.

2014-05-13 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21352/#review42834
---

Ship it!


Ship It!

- Maxim Khutornenko


On May 13, 2014, 12:06 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21352/
> ---
> 
> (Updated May 13, 2014, 12:06 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-416
> https://issues.apache.org/jira/browse/AURORA-416
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Since this would have been caught by findbugs when introduced, i decided to 
> configure findbugs on our build as added prevention going forward.
> 
> I also addressed a few findbugs warnings which took fewer characters to 
> exclude than to fix.
> 
> 
> Diffs
> -
> 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   config/findbugs/excludeFilter.xml PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
> ada5eafdf484f733c07277754833313d5e7bdc4b 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> ddbb02560bb8fb94dafe26c1a66c767e9a3a863b 
>   src/test/java/org/apache/aurora/scheduler/async/TaskGroupsTest.java 
> e23ab5cd49a52f3004baa4e30462c6b028931371 
>   src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 
> a9b85d0983dcfee89101a5e774ba86ee11708c68 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java 
> de5cdcf7a16f71f1815b0f6de6100eaf42c76cdd 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  47d2fd6d8a34cb14d68894e14c147709373e3572 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> e212174ed089fdcf28fa679318fe216917a40b99 
> 
> Diff: https://reviews.apache.org/r/21352/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 21352: Fix regression causing scheduling rate limiter to not be honored.

2014-05-12 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21352/#review42792
---

Ship it!


lgtm. 

- David McLaughlin


On May 13, 2014, 12:06 a.m., Bill Farner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21352/
> ---
> 
> (Updated May 13, 2014, 12:06 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-416
> https://issues.apache.org/jira/browse/AURORA-416
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Since this would have been caught by findbugs when introduced, i decided to 
> configure findbugs on our build as added prevention going forward.
> 
> I also addressed a few findbugs warnings which took fewer characters to 
> exclude than to fix.
> 
> 
> Diffs
> -
> 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   config/findbugs/excludeFilter.xml PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
> ada5eafdf484f733c07277754833313d5e7bdc4b 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> ddbb02560bb8fb94dafe26c1a66c767e9a3a863b 
>   src/test/java/org/apache/aurora/scheduler/async/TaskGroupsTest.java 
> e23ab5cd49a52f3004baa4e30462c6b028931371 
>   src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 
> a9b85d0983dcfee89101a5e774ba86ee11708c68 
>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java 
> de5cdcf7a16f71f1815b0f6de6100eaf42c76cdd 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  47d2fd6d8a34cb14d68894e14c147709373e3572 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> e212174ed089fdcf28fa679318fe216917a40b99 
> 
> Diff: https://reviews.apache.org/r/21352/diff/
> 
> 
> Testing
> ---
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Review Request 21352: Fix regression causing scheduling rate limiter to not be honored.

2014-05-12 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21352/
---

Review request for Aurora, David McLaughlin and Maxim Khutornenko.


Bugs: AURORA-416
https://issues.apache.org/jira/browse/AURORA-416


Repository: aurora


Description
---

Since this would have been caught by findbugs when introduced, i decided to 
configure findbugs on our build as added prevention going forward.

I also addressed a few findbugs warnings which took fewer characters to exclude 
than to fix.


Diffs
-

  build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
  config/findbugs/excludeFilter.xml PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
ada5eafdf484f733c07277754833313d5e7bdc4b 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
ddbb02560bb8fb94dafe26c1a66c767e9a3a863b 
  src/test/java/org/apache/aurora/scheduler/async/TaskGroupsTest.java 
e23ab5cd49a52f3004baa4e30462c6b028931371 
  src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 
a9b85d0983dcfee89101a5e774ba86ee11708c68 
  src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java 
de5cdcf7a16f71f1815b0f6de6100eaf42c76cdd 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 47d2fd6d8a34cb14d68894e14c147709373e3572 
  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
e212174ed089fdcf28fa679318fe216917a40b99 

Diff: https://reviews.apache.org/r/21352/diff/


Testing
---

./gradlew build


Thanks,

Bill Farner