Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated July 23, 2014, 5:05 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review48459 --- Ship it! Ship It! - Brian Wickman On July 21, 2014, 9:09 p.m., M

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated July 21, 2014, 9:09 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated June 27, 2014, 7:58 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 21440: Implementing parallel updater

> On June 25, 2014, 10:44 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/api/instance_watcher.py, line 48 > > > > > > this should be terminating_event=None > > > > and self._terminating =

Re: Review Request 21440: Implementing parallel updater

> On June 25, 2014, 10:44 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/api/instance_watcher.py, line 48 > > > > > > this should be terminating_event=None > > > > and self._terminating =

Re: Review Request 21440: Implementing parallel updater

> On June 25, 2014, 10:44 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/api/instance_watcher.py, line 48 > > > > > > this should be terminating_event=None > > > > and self._terminating =

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated June 27, 2014, 6:36 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review46692 --- src/main/python/apache/aurora/client/api/instance_watcher.py

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated June 24, 2014, 11:28 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated June 24, 2014, 11:24 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review44989 --- Ship it! Ship It! - Brian Wickman On June 6, 2014, 5:55 p.m., Ma

Re: Review Request 21440: Implementing parallel updater

> On May 27, 2014, 6:38 p.m., Brian Wickman wrote: > > src/test/python/apache/aurora/client/api/test_instance_watcher.py, line 19 > > > > > > I don't think we can rely upon patching or subclassing _Event (an > > intern

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated June 6, 2014, 5:55 p.m.) Review request for Aurora, Mark Chu-Carroll a

Re: Review Request 21440: Implementing parallel updater

> On May 27, 2014, 6:38 p.m., Brian Wickman wrote: > > src/test/python/apache/aurora/client/api/test_instance_watcher.py, line 19 > > > > > > I don't think we can rely upon patching or subclassing _Event (an > > intern

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated May 30, 2014, 10:08 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 21440: Implementing parallel updater

> On May 27, 2014, 6:38 p.m., Brian Wickman wrote: > > src/test/python/apache/aurora/client/api/test_instance_watcher.py, line 19 > > > > > > I don't think we can rely upon patching or subclassing _Event (an > > intern

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated May 28, 2014, 12:20 a.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review44016 --- src/main/python/apache/aurora/client/api/updater.py

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review43982 --- Ship it! Ship It! - Mark Chu-Carroll On May 22, 2014, 9:19 p.m.,

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review43979 --- Ping Brian, Mark. - Maxim Khutornenko On May 23, 2014, 1:19 a.m.,

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated May 23, 2014, 1:19 a.m.) Review request for Aurora, Mark Chu-Carroll a

Re: Review Request 21440: Implementing parallel updater

> On May 20, 2014, 8:04 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/api/updater.py, line 58 > > > > > > This could be clearer with a bit of rephrasing in the comment: > > > > "A threa

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated May 21, 2014, 4:58 p.m.) Review request for Aurora, Mark Chu-Carroll a

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review43523 --- src/main/python/apache/aurora/client/api/updater.py

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review43522 --- Ping Brian, Mark. - Maxim Khutornenko On May 15, 2014, 10:52 p.m.

Re: Review Request 21440: Implementing parallel updater

> On May 14, 2014, 7:20 p.m., Mark Chu-Carroll wrote: > > src/test/python/apache/aurora/client/api/test_updater.py, line 126 > > > > > > Doesn't this mean that the test will be running with just one thread? > > That w

Re: Review Request 21440: Implementing parallel updater

> On May 14, 2014, 10:57 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/api/updater.py, line 237 > > > > > > it surprises me that this is necessary. will signal.signal() even work > > outside of

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated May 15, 2014, 10:52 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review43046 --- a few high level comments. still need to wade through the semantics

Re: Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review43004 --- src/main/python/apache/aurora/client/api/instance_watcher.py

Review Request 21440: Implementing parallel updater

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-350