Re: Review Request 21739: Add a test to catch regressions in scheduler_client connect_scheduler.

2014-05-21 Thread Joe Smith
> On May 20, 2014, 6:34 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/api/scheduler_client.py, line 87 > > > > > > Not necessary, but you could just use a patch in the test, instead of > > chan

Re: Review Request 21739: Add a test to catch regressions in scheduler_client connect_scheduler.

2014-05-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21739/#review43656 --- Ship it! Ship It! - Kevin Sweeney On May 20, 2014, 4:57 p.m., Jo

Re: Review Request 21739: Add a test to catch regressions in scheduler_client connect_scheduler.

2014-05-21 Thread Kevin Sweeney
> On May 20, 2014, 6:34 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/api/scheduler_client.py, line 87 > > > > > > Not necessary, but you could just use a patch in the test, instead of > > chan

Re: Review Request 21739: Add a test to catch regressions in scheduler_client connect_scheduler.

2014-05-20 Thread Joe Smith
> On May 20, 2014, 6:34 p.m., Mark Chu-Carroll wrote: > > src/main/python/apache/aurora/client/api/scheduler_client.py, line 87 > > > > > > Not necessary, but you could just use a patch in the test, instead of > > chan

Re: Review Request 21739: Add a test to catch regressions in scheduler_client connect_scheduler.

2014-05-20 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21739/#review43567 --- Ship it! Ship It! src/main/python/apache/aurora/client/api/schedu

Re: Review Request 21739: Add a test to catch regressions in scheduler_client connect_scheduler.

2014-05-20 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21739/ --- (Updated May 20, 2014, 4:57 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 21739: Add a test to catch regressions in scheduler_client connect_scheduler.

2014-05-20 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21739/#review43560 --- Thanks! Would you mind adding markcc to this review in my place? -

Review Request 21739: Add a test to catch regressions in scheduler_client connect_scheduler.

2014-05-20 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21739/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-453