Re: Review Request 21951: Enable more PMD rules.

2014-05-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21951/#review44123 --- src/main/java/org/apache/aurora/scheduler/http/Utilization.java

Re: Review Request 21951: Enable more PMD rules.

2014-05-28 Thread Bill Farner
On May 28, 2014, 4:26 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/http/Utilization.java, line 164 https://reviews.apache.org/r/21951/diff/1/?file=595644#file595644line164 Do we really want to start using Locale everywhere when dealing with string

Re: Review Request 21951: Enable more PMD rules.

2014-05-28 Thread Maxim Khutornenko
On May 28, 2014, 4:26 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/http/Utilization.java, line 164 https://reviews.apache.org/r/21951/diff/1/?file=595644#file595644line164 Do we really want to start using Locale everywhere when dealing with string

Re: Review Request 21951: Enable more PMD rules.

2014-05-28 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21951/#review44141 --- Ship it! - David McLaughlin On May 28, 2014, 12:57 a.m., Bill

Review Request 21951: Enable more PMD rules.

2014-05-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21951/ --- Review request for Aurora, David McLaughlin and Maxim Khutornenko. Repository: