Review Request 21994: Fixing incorrect .gitignore rule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21994/ --- Review request for Aurora and David McLaughlin. Bugs: AURORA-485 https://issues.apache.org/jira/browse/AURORA-485 Repository: aurora Description --- Fixing incorrect .gitignore rule. Added the missing dist/ folders in 3rdparty/javascript. Diffs - .gitignore cd7bc6dd122fd3490568fe5b2a68d59cfff7fbff 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js PRE-CREATION 3rdparty/javascript/bower_components/jquery/dist/jquery.js PRE-CREATION 3rdparty/javascript/bower_components/jquery/dist/jquery.min.js PRE-CREATION 3rdparty/javascript/bower_components/jquery/dist/jquery.min.map PRE-CREATION Diff: https://reviews.apache.org/r/21994/diff/ Testing --- ./gradlew run ./gradlew clean build. Thanks, Suman Karumuri
Re: Review Request 21994: Fixing incorrect .gitignore rule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21994/#review44192 --- Ship it! - Kevin Sweeney On May 28, 2014, 3:40 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21994/ --- (Updated May 28, 2014, 3:40 p.m.) Review request for Aurora and David McLaughlin. Bugs: AURORA-485 https://issues.apache.org/jira/browse/AURORA-485 Repository: aurora Description --- Fixing incorrect .gitignore rule. Added the missing dist/ folders in 3rdparty/javascript. Diffs - .gitignore cd7bc6dd122fd3490568fe5b2a68d59cfff7fbff 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js PRE-CREATION 3rdparty/javascript/bower_components/jquery/dist/jquery.js PRE-CREATION 3rdparty/javascript/bower_components/jquery/dist/jquery.min.js PRE-CREATION 3rdparty/javascript/bower_components/jquery/dist/jquery.min.map PRE-CREATION Diff: https://reviews.apache.org/r/21994/diff/ Testing --- ./gradlew run ./gradlew clean build. Thanks, Suman Karumuri
Re: Review Request 21994: Fixing incorrect .gitignore rule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21994/#review44214 --- .gitignore https://reviews.apache.org/r/21994/#comment78557 Please follow up with a comment explaining why this is necessary. Clearly it's important, so it's good form to call out why it's different than the other lines in here. - Bill Farner On May 28, 2014, 10:40 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21994/ --- (Updated May 28, 2014, 10:40 p.m.) Review request for Aurora and David McLaughlin. Bugs: AURORA-485 https://issues.apache.org/jira/browse/AURORA-485 Repository: aurora Description --- Fixing incorrect .gitignore rule. Added the missing dist/ folders in 3rdparty/javascript. Diffs - .gitignore cd7bc6dd122fd3490568fe5b2a68d59cfff7fbff 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.css.map PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap-theme.min.css PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.css.map PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/css/bootstrap.min.css PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.eot PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.svg PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/fonts/glyphicons-halflings-regular.woff PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.js PRE-CREATION 3rdparty/javascript/bower_components/bootstrap/dist/js/bootstrap.min.js PRE-CREATION 3rdparty/javascript/bower_components/jquery/dist/jquery.js PRE-CREATION 3rdparty/javascript/bower_components/jquery/dist/jquery.min.js PRE-CREATION 3rdparty/javascript/bower_components/jquery/dist/jquery.min.map PRE-CREATION Diff: https://reviews.apache.org/r/21994/diff/ Testing --- ./gradlew run ./gradlew clean build. Thanks, Suman Karumuri
