Re: Review Request 22023: Modify clientv2 to always log messages from the server

2014-06-06 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22023/
---

(Updated June 6, 2014, 2:35 p.m.)


Review request for Aurora, David McLaughlin and Maxim Khutornenko.


Changes
---

rebase.


Bugs: aurora-477
https://issues.apache.org/jira/browse/aurora-477


Repository: aurora


Description
---

- Always show messages returned by the server.
- Update message handling in the client for api changes.
- Fix some test problems that were uncovered by the API change.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/context.py 
669add74d79174519634abab3dd161038db9f097 
  src/main/python/apache/aurora/client/cli/cron.py 
cefeca48b62f071fa257d3462b9228538b21db4e 
  src/main/python/apache/aurora/client/cli/jobs.py 
cd5070ed7486f7306703b9128f5de74e422d75fd 
  src/main/python/apache/aurora/client/cli/quota.py 
5811825fd62430ea9249b31874fd90276c5e256c 
  src/main/python/apache/aurora/client/cli/task.py 
7fb3f55e08df22c5e18691f12730d4935f480ebe 
  src/test/python/apache/aurora/client/cli/test_cron.py 
6066a3be2eaa2c7d09aad2128e2c334ead293372 
  src/test/python/apache/aurora/client/cli/test_status.py 
dc1c730b94a1ac49dfcef62339b559be8989f7c7 
  src/test/python/apache/aurora/client/cli/test_update.py 
08be49e81f190822dca80f3728845138d341574b 
  src/test/python/apache/aurora/client/cli/util.py 
070718caaf912374f00fa89fdb9266ab95b3c483 

Diff: https://reviews.apache.org/r/22023/diff/


Testing
---

Ran all client unit tests, plus v2 version of e2e.


Thanks,

Mark Chu-Carroll

Re: Review Request 22023: Modify clientv2 to always log messages from the server

2014-06-06 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22023/
---

(Updated June 6, 2014, 2:15 p.m.)


Review request for Aurora, David McLaughlin and Maxim Khutornenko.


Changes
---

last review.


Bugs: aurora-477
https://issues.apache.org/jira/browse/aurora-477


Repository: aurora


Description
---

- Always show messages returned by the server.
- Update message handling in the client for api changes.
- Fix some test problems that were uncovered by the API change.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/context.py 
d1f1f3f308fb3453e79a3f725a3316d25fa4b0f8 
  src/main/python/apache/aurora/client/cli/cron.py 
c30a0a605412229f3e4cddbe8c5ae746f256e30c 
  src/main/python/apache/aurora/client/cli/jobs.py 
8020c356aba9321ded20f06707ff3678aef61937 
  src/main/python/apache/aurora/client/cli/quota.py 
af07d8386e687e3926fd879320245c1eb1c6c263 
  src/main/python/apache/aurora/client/cli/task.py 
fe11f38b902ae54a4048ba114055ba30e8abe6c5 
  src/test/python/apache/aurora/client/cli/test_cron.py 
049405a4323fc73102d6ac1dae2230be4325c530 
  src/test/python/apache/aurora/client/cli/test_status.py 
4cc3f9d66d8f7d8ad66e09d2bfb0dc1a9f9aaa41 
  src/test/python/apache/aurora/client/cli/test_update.py 
a2abc5eb0f11f9bc563f4504c93fcf5b7520d141 
  src/test/python/apache/aurora/client/cli/util.py 
dac4928111200136a9987c9622087e8cdca7f2d2 

Diff: https://reviews.apache.org/r/22023/diff/


Testing
---

Ran all client unit tests, plus v2 version of e2e.


Thanks,

Mark Chu-Carroll

Re: Review Request 22023: Modify clientv2 to always log messages from the server

2014-06-06 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22023/#review44926
---

Ship it!



src/main/python/apache/aurora/client/cli/cron.py


extra space



src/main/python/apache/aurora/client/cli/jobs.py


revert to previous tabbing?



src/main/python/apache/aurora/client/cli/task.py


extra space


- Maxim Khutornenko


On June 6, 2014, 3:38 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22023/
> ---
> 
> (Updated June 6, 2014, 3:38 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-477
> https://issues.apache.org/jira/browse/aurora-477
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Always show messages returned by the server.
> - Update message handling in the client for api changes.
> - Fix some test problems that were uncovered by the API change.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> d1f1f3f308fb3453e79a3f725a3316d25fa4b0f8 
>   src/main/python/apache/aurora/client/cli/cron.py 
> c30a0a605412229f3e4cddbe8c5ae746f256e30c 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8020c356aba9321ded20f06707ff3678aef61937 
>   src/main/python/apache/aurora/client/cli/quota.py 
> af07d8386e687e3926fd879320245c1eb1c6c263 
>   src/main/python/apache/aurora/client/cli/task.py 
> fe11f38b902ae54a4048ba114055ba30e8abe6c5 
>   src/test/python/apache/aurora/client/cli/test_cron.py 
> 049405a4323fc73102d6ac1dae2230be4325c530 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 4cc3f9d66d8f7d8ad66e09d2bfb0dc1a9f9aaa41 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> a2abc5eb0f11f9bc563f4504c93fcf5b7520d141 
>   src/test/python/apache/aurora/client/cli/util.py 
> dac4928111200136a9987c9622087e8cdca7f2d2 
> 
> Diff: https://reviews.apache.org/r/22023/diff/
> 
> 
> Testing
> ---
> 
> Ran all client unit tests, plus v2 version of e2e.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22023: Modify clientv2 to always log messages from the server

2014-06-06 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22023/
---

(Updated June 6, 2014, 11:38 a.m.)


Review request for Aurora, David McLaughlin and Maxim Khutornenko.


Changes
---

Address Maxim's review.


Bugs: aurora-477
https://issues.apache.org/jira/browse/aurora-477


Repository: aurora


Description
---

- Always show messages returned by the server.
- Update message handling in the client for api changes.
- Fix some test problems that were uncovered by the API change.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/context.py 
d1f1f3f308fb3453e79a3f725a3316d25fa4b0f8 
  src/main/python/apache/aurora/client/cli/cron.py 
c30a0a605412229f3e4cddbe8c5ae746f256e30c 
  src/main/python/apache/aurora/client/cli/jobs.py 
8020c356aba9321ded20f06707ff3678aef61937 
  src/main/python/apache/aurora/client/cli/quota.py 
af07d8386e687e3926fd879320245c1eb1c6c263 
  src/main/python/apache/aurora/client/cli/task.py 
fe11f38b902ae54a4048ba114055ba30e8abe6c5 
  src/test/python/apache/aurora/client/cli/test_cron.py 
049405a4323fc73102d6ac1dae2230be4325c530 
  src/test/python/apache/aurora/client/cli/test_status.py 
4cc3f9d66d8f7d8ad66e09d2bfb0dc1a9f9aaa41 
  src/test/python/apache/aurora/client/cli/test_update.py 
a2abc5eb0f11f9bc563f4504c93fcf5b7520d141 
  src/test/python/apache/aurora/client/cli/util.py 
dac4928111200136a9987c9622087e8cdca7f2d2 

Diff: https://reviews.apache.org/r/22023/diff/


Testing
---

Ran all client unit tests, plus v2 version of e2e.


Thanks,

Mark Chu-Carroll

Re: Review Request 22023: Modify clientv2 to always log messages from the server

2014-06-04 Thread Maxim Khutornenko 


> On June 4, 2014, 7:15 p.m., Mark Chu-Carroll wrote:
> > src/main/python/apache/aurora/client/cli/context.py, line 127
> > 
> >
> > I've got a strong preference to not do that.
> > 
> > When I'm reading code, I find that things like that are a distraction: 
> > I can't see the control flow of the method; to understand how it works, I 
> > need to jump around the code.
> > 
> > I also don't see much benefit in this case: in order to generate the 
> > error messages, you need to create the error anyway, and to do that, you 
> > need the message anyway.
> >

I doubt copy/pasting this pattern as it stands now is a better alternative 
though. Given that this is a standard log/check/raise sequence I don't see much 
loss in readability either.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22023/#review44744
---


On June 4, 2014, 1:08 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22023/
> ---
> 
> (Updated June 4, 2014, 1:08 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-477
> https://issues.apache.org/jira/browse/aurora-477
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Always show messages returned by the server.
> - Update message handling in the client for api changes.
> - Fix some test problems that were uncovered by the API change.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> d1f1f3f308fb3453e79a3f725a3316d25fa4b0f8 
>   src/main/python/apache/aurora/client/cli/cron.py 
> c30a0a605412229f3e4cddbe8c5ae746f256e30c 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8020c356aba9321ded20f06707ff3678aef61937 
>   src/main/python/apache/aurora/client/cli/quota.py 
> af07d8386e687e3926fd879320245c1eb1c6c263 
>   src/main/python/apache/aurora/client/cli/task.py 
> 2b8ea26e0362690cef38a1b907642d07aa1df37f 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 4cc3f9d66d8f7d8ad66e09d2bfb0dc1a9f9aaa41 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> a2abc5eb0f11f9bc563f4504c93fcf5b7520d141 
>   src/test/python/apache/aurora/client/cli/util.py 
> dac4928111200136a9987c9622087e8cdca7f2d2 
> 
> Diff: https://reviews.apache.org/r/22023/diff/
> 
> 
> Testing
> ---
> 
> Ran all client unit tests, plus v2 version of e2e.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22023: Modify clientv2 to always log messages from the server

2014-06-04 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22023/#review44744
---



src/main/python/apache/aurora/client/cli/context.py


I've got a strong preference to not do that.

When I'm reading code, I find that things like that are a distraction: I 
can't see the control flow of the method; to understand how it works, I need to 
jump around the code.

I also don't see much benefit in this case: in order to generate the error 
messages, you need to create the error anyway, and to do that, you need the 
message anyway.




src/main/python/apache/aurora/client/cli/cron.py


Here it's even harder to refactor as you suggest - this does a conditional 
return. To abstract this out, we'd need to switch to an exception throw, which 
would be more complex and less clear.



- Mark Chu-Carroll


On June 4, 2014, 9:08 a.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22023/
> ---
> 
> (Updated June 4, 2014, 9:08 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-477
> https://issues.apache.org/jira/browse/aurora-477
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Always show messages returned by the server.
> - Update message handling in the client for api changes.
> - Fix some test problems that were uncovered by the API change.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> d1f1f3f308fb3453e79a3f725a3316d25fa4b0f8 
>   src/main/python/apache/aurora/client/cli/cron.py 
> c30a0a605412229f3e4cddbe8c5ae746f256e30c 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8020c356aba9321ded20f06707ff3678aef61937 
>   src/main/python/apache/aurora/client/cli/quota.py 
> af07d8386e687e3926fd879320245c1eb1c6c263 
>   src/main/python/apache/aurora/client/cli/task.py 
> 2b8ea26e0362690cef38a1b907642d07aa1df37f 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 4cc3f9d66d8f7d8ad66e09d2bfb0dc1a9f9aaa41 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> a2abc5eb0f11f9bc563f4504c93fcf5b7520d141 
>   src/test/python/apache/aurora/client/cli/util.py 
> dac4928111200136a9987c9622087e8cdca7f2d2 
> 
> Diff: https://reviews.apache.org/r/22023/diff/
> 
> 
> Testing
> ---
> 
> Ran all client unit tests, plus v2 version of e2e.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22023: Modify clientv2 to always log messages from the server

2014-06-04 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22023/#review44740
---



src/main/python/apache/aurora/client/cli/context.py


This pattern repeats making messageDEPRECATION removal harder. How about 
having something like: check_log_and_raise(self, resp, error) method that would 
do what check_and_log_response does but raise a custom error?



src/main/python/apache/aurora/client/cli/cron.py


A similar pattern but without raising an error. Perhaps something like 
check_and_log_custom_error(self, resp, context)?


- Maxim Khutornenko


On June 4, 2014, 1:08 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22023/
> ---
> 
> (Updated June 4, 2014, 1:08 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-477
> https://issues.apache.org/jira/browse/aurora-477
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Always show messages returned by the server.
> - Update message handling in the client for api changes.
> - Fix some test problems that were uncovered by the API change.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> d1f1f3f308fb3453e79a3f725a3316d25fa4b0f8 
>   src/main/python/apache/aurora/client/cli/cron.py 
> c30a0a605412229f3e4cddbe8c5ae746f256e30c 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8020c356aba9321ded20f06707ff3678aef61937 
>   src/main/python/apache/aurora/client/cli/quota.py 
> af07d8386e687e3926fd879320245c1eb1c6c263 
>   src/main/python/apache/aurora/client/cli/task.py 
> 2b8ea26e0362690cef38a1b907642d07aa1df37f 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 4cc3f9d66d8f7d8ad66e09d2bfb0dc1a9f9aaa41 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> a2abc5eb0f11f9bc563f4504c93fcf5b7520d141 
>   src/test/python/apache/aurora/client/cli/util.py 
> dac4928111200136a9987c9622087e8cdca7f2d2 
> 
> Diff: https://reviews.apache.org/r/22023/diff/
> 
> 
> Testing
> ---
> 
> Ran all client unit tests, plus v2 version of e2e.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Re: Review Request 22023: Modify clientv2 to always log messages from the server

2014-06-04 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22023/
---

(Updated June 4, 2014, 9:08 a.m.)


Review request for Aurora, David McLaughlin and Maxim Khutornenko.


Changes
---

Removed Bill from the reviewers list, since he's out getting married!


Bugs: aurora-477
https://issues.apache.org/jira/browse/aurora-477


Repository: aurora


Description
---

- Always show messages returned by the server.
- Update message handling in the client for api changes.
- Fix some test problems that were uncovered by the API change.


Diffs
-

  src/main/python/apache/aurora/client/cli/context.py 
d1f1f3f308fb3453e79a3f725a3316d25fa4b0f8 
  src/main/python/apache/aurora/client/cli/cron.py 
c30a0a605412229f3e4cddbe8c5ae746f256e30c 
  src/main/python/apache/aurora/client/cli/jobs.py 
8020c356aba9321ded20f06707ff3678aef61937 
  src/main/python/apache/aurora/client/cli/quota.py 
af07d8386e687e3926fd879320245c1eb1c6c263 
  src/main/python/apache/aurora/client/cli/task.py 
2b8ea26e0362690cef38a1b907642d07aa1df37f 
  src/test/python/apache/aurora/client/cli/test_status.py 
4cc3f9d66d8f7d8ad66e09d2bfb0dc1a9f9aaa41 
  src/test/python/apache/aurora/client/cli/test_update.py 
a2abc5eb0f11f9bc563f4504c93fcf5b7520d141 
  src/test/python/apache/aurora/client/cli/util.py 
dac4928111200136a9987c9622087e8cdca7f2d2 

Diff: https://reviews.apache.org/r/22023/diff/


Testing
---

Ran all client unit tests, plus v2 version of e2e.


Thanks,

Mark Chu-Carroll

Re: Review Request 22023: Modify clientv2 to always log messages from the server

2014-05-29 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22023/
---

(Updated May 29, 2014, 4:45 p.m.)


Review request for Aurora, David McLaughlin and Bill Farner.


Changes
---

Dave's review.


Bugs: aurora-477
https://issues.apache.org/jira/browse/aurora-477


Repository: aurora


Description
---

- Always show messages returned by the server.
- Update message handling in the client for api changes.
- Fix some test problems that were uncovered by the API change.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/context.py 
d1f1f3f308fb3453e79a3f725a3316d25fa4b0f8 
  src/main/python/apache/aurora/client/cli/cron.py 
c30a0a605412229f3e4cddbe8c5ae746f256e30c 
  src/main/python/apache/aurora/client/cli/jobs.py 
8020c356aba9321ded20f06707ff3678aef61937 
  src/main/python/apache/aurora/client/cli/quota.py 
af07d8386e687e3926fd879320245c1eb1c6c263 
  src/main/python/apache/aurora/client/cli/task.py 
2b8ea26e0362690cef38a1b907642d07aa1df37f 
  src/test/python/apache/aurora/client/cli/test_status.py 
4cc3f9d66d8f7d8ad66e09d2bfb0dc1a9f9aaa41 
  src/test/python/apache/aurora/client/cli/test_update.py 
a2abc5eb0f11f9bc563f4504c93fcf5b7520d141 
  src/test/python/apache/aurora/client/cli/util.py 
dac4928111200136a9987c9622087e8cdca7f2d2 

Diff: https://reviews.apache.org/r/22023/diff/


Testing
---

Ran all client unit tests, plus v2 version of e2e.


Thanks,

Mark Chu-Carroll

Re: Review Request 22023: Modify clientv2 to always log messages from the server

2014-05-29 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22023/#review44283
---

Ship it!



src/main/python/apache/aurora/client/cli/context.py


Not a Thrift expert, but won't this be None if the server doesn't send any 
messages?



src/main/python/apache/aurora/client/cli/jobs.py


Trailing ws



src/main/python/apache/aurora/client/cli/jobs.py


Trailing ws.


- David McLaughlin


On May 29, 2014, 4:14 p.m., Mark Chu-Carroll wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22023/
> ---
> 
> (Updated May 29, 2014, 4:14 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: aurora-477
> https://issues.apache.org/jira/browse/aurora-477
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> - Always show messages returned by the server.
> - Update message handling in the client for api changes.
> - Fix some test problems that were uncovered by the API change.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> d1f1f3f308fb3453e79a3f725a3316d25fa4b0f8 
>   src/main/python/apache/aurora/client/cli/cron.py 
> c30a0a605412229f3e4cddbe8c5ae746f256e30c 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> 8020c356aba9321ded20f06707ff3678aef61937 
>   src/main/python/apache/aurora/client/cli/quota.py 
> af07d8386e687e3926fd879320245c1eb1c6c263 
>   src/main/python/apache/aurora/client/cli/task.py 
> 2b8ea26e0362690cef38a1b907642d07aa1df37f 
>   src/test/python/apache/aurora/client/cli/test_status.py 
> 4cc3f9d66d8f7d8ad66e09d2bfb0dc1a9f9aaa41 
>   src/test/python/apache/aurora/client/cli/test_update.py 
> a2abc5eb0f11f9bc563f4504c93fcf5b7520d141 
>   src/test/python/apache/aurora/client/cli/util.py 
> dac4928111200136a9987c9622087e8cdca7f2d2 
> 
> Diff: https://reviews.apache.org/r/22023/diff/
> 
> 
> Testing
> ---
> 
> Ran all client unit tests, plus v2 version of e2e.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Review Request 22023: Modify clientv2 to always log messages from the server

2014-05-29 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22023/
---

Review request for Aurora, David McLaughlin and Bill Farner.


Bugs: aurora-477
https://issues.apache.org/jira/browse/aurora-477


Repository: aurora


Description
---

- Always show messages returned by the server.
- Update message handling in the client for api changes.
- Fix some test problems that were uncovered by the API change.


Diffs
-

  src/main/python/apache/aurora/client/cli/context.py 
d1f1f3f308fb3453e79a3f725a3316d25fa4b0f8 
  src/main/python/apache/aurora/client/cli/cron.py 
c30a0a605412229f3e4cddbe8c5ae746f256e30c 
  src/main/python/apache/aurora/client/cli/jobs.py 
8020c356aba9321ded20f06707ff3678aef61937 
  src/main/python/apache/aurora/client/cli/quota.py 
af07d8386e687e3926fd879320245c1eb1c6c263 
  src/main/python/apache/aurora/client/cli/task.py 
2b8ea26e0362690cef38a1b907642d07aa1df37f 
  src/test/python/apache/aurora/client/cli/test_status.py 
4cc3f9d66d8f7d8ad66e09d2bfb0dc1a9f9aaa41 
  src/test/python/apache/aurora/client/cli/test_update.py 
a2abc5eb0f11f9bc563f4504c93fcf5b7520d141 
  src/test/python/apache/aurora/client/cli/util.py 
dac4928111200136a9987c9622087e8cdca7f2d2 

Diff: https://reviews.apache.org/r/22023/diff/


Testing
---

Ran all client unit tests, plus v2 version of e2e.


Thanks,

Mark Chu-Carroll