Re: Review Request 22065: Fix /cron endpoint.

2014-05-30 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22065/#review44341 --- Ship it! Ship It! - Suman Karumuri On May 30, 2014, 1:32 a.m.,

Re: Review Request 22065: Fix /cron endpoint.

2014-05-30 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22065/#review44396 --- Ship it! Ship It! - David McLaughlin On May 30, 2014, 1:32

Review Request 22065: Fix /cron endpoint.

2014-05-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22065/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-478

Re: Review Request 22065: Fix /cron endpoint.

2014-05-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22065/ --- (Updated May 29, 2014, 6:09 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22065: Fix /cron endpoint.

2014-05-29 Thread Kevin Sweeney
On May 29, 2014, 4:21 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/http/Cron.java, line 52 https://reviews.apache.org/r/22065/diff/1/?file=599475#file599475line52 While you're in the neighborhood...how about some test coverage in here? Ideally the test

Re: Review Request 22065: Fix /cron endpoint.

2014-05-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22065/ --- (Updated May 29, 2014, 6:32 p.m.) Review request for Aurora, David McLaughlin