Re: Review Request 22274: Make errors in the thrift API interface handle-able by the aurora client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22274/#review44880 --- Ship it! Ship It! - David McLaughlin On June 5, 2014, 6:06 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22274/ > --- > > (Updated June 5, 2014, 6:06 p.m.) > > > Review request for Aurora, David McLaughlin and Brian Wickman. > > > Repository: aurora > > > Description > --- > > Make errors in the thrift API interface handle-able by the aurora client. > > - Add a general exception catch around the code that calls thrift RPCs, > so that any error that occurs in the thrift code will be turned > into a ThriftInternalException. > - Modify the client so that it catches internal errors without dumping > stack, and cleanly exits with EXIT_API_ERROR. > - Add a file for tests of API functionality, instead of co-opting > existing tests. > > > Diffs > - > > src/main/python/apache/aurora/client/api/__init__.py > 1af0f8fa77e15444027c553404495d1ebeb5e540 > src/main/python/apache/aurora/client/api/scheduler_client.py > 7be974eb91089f776656ce65b64ee6d8c5b46394 > src/main/python/apache/aurora/client/cli/__init__.py > fd6f96ebe4acd358409f145178ebf8ad5ea27d05 > src/test/python/apache/aurora/client/cli/BUILD > c91ae422e6bf462d4494919bf385c86f0636cdd1 > src/test/python/apache/aurora/client/cli/test_api_from_cli.py PRE-CREATION > > Diff: https://reviews.apache.org/r/22274/diff/ > > > Testing > --- > > Added new unit tests, ran all tests successfully. > > > Thanks, > > Mark Chu-Carroll > >
Re: Review Request 22274: Make errors in the thrift API interface handle-able by the aurora client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22274/#review44858 --- Ship it! Ship It! - Brian Wickman On June 5, 2014, 6:06 p.m., Mark Chu-Carroll wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22274/ > --- > > (Updated June 5, 2014, 6:06 p.m.) > > > Review request for Aurora, David McLaughlin and Brian Wickman. > > > Repository: aurora > > > Description > --- > > Make errors in the thrift API interface handle-able by the aurora client. > > - Add a general exception catch around the code that calls thrift RPCs, > so that any error that occurs in the thrift code will be turned > into a ThriftInternalException. > - Modify the client so that it catches internal errors without dumping > stack, and cleanly exits with EXIT_API_ERROR. > - Add a file for tests of API functionality, instead of co-opting > existing tests. > > > Diffs > - > > src/main/python/apache/aurora/client/api/__init__.py > 1af0f8fa77e15444027c553404495d1ebeb5e540 > src/main/python/apache/aurora/client/api/scheduler_client.py > 7be974eb91089f776656ce65b64ee6d8c5b46394 > src/main/python/apache/aurora/client/cli/__init__.py > fd6f96ebe4acd358409f145178ebf8ad5ea27d05 > src/test/python/apache/aurora/client/cli/BUILD > c91ae422e6bf462d4494919bf385c86f0636cdd1 > src/test/python/apache/aurora/client/cli/test_api_from_cli.py PRE-CREATION > > Diff: https://reviews.apache.org/r/22274/diff/ > > > Testing > --- > > Added new unit tests, ran all tests successfully. > > > Thanks, > > Mark Chu-Carroll > >
Review Request 22274: Make errors in the thrift API interface handle-able by the aurora client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22274/ --- Review request for Aurora, David McLaughlin and Brian Wickman. Repository: aurora Description --- Make errors in the thrift API interface handle-able by the aurora client. - Add a general exception catch around the code that calls thrift RPCs, so that any error that occurs in the thrift code will be turned into a ThriftInternalException. - Modify the client so that it catches internal errors without dumping stack, and cleanly exits with EXIT_API_ERROR. - Add a file for tests of API functionality, instead of co-opting existing tests. Diffs - src/main/python/apache/aurora/client/api/__init__.py 1af0f8fa77e15444027c553404495d1ebeb5e540 src/main/python/apache/aurora/client/api/scheduler_client.py 7be974eb91089f776656ce65b64ee6d8c5b46394 src/main/python/apache/aurora/client/cli/__init__.py fd6f96ebe4acd358409f145178ebf8ad5ea27d05 src/test/python/apache/aurora/client/cli/BUILD c91ae422e6bf462d4494919bf385c86f0636cdd1 src/test/python/apache/aurora/client/cli/test_api_from_cli.py PRE-CREATION Diff: https://reviews.apache.org/r/22274/diff/ Testing --- Added new unit tests, ran all tests successfully. Thanks, Mark Chu-Carroll
