Re: Review Request 22701: Adding admin command to get locks.

2014-06-20 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22701/
---

(Updated June 20, 2014, 9:55 p.m.)


Review request for Aurora, David McLaughlin and Mark Chu-Carroll.


Changes
---

CR comments.


Bugs: AURORA-347
https://issues.apache.org/jira/browse/AURORA-347


Repository: aurora


Description
---

Adding get_locks command to take advantage of the new getLocks RPC.


Diffs (updated)
-

  src/main/python/apache/aurora/client/api/__init__.py 
19fc6782763544ada79e806b841853910fd628de 
  src/main/python/apache/aurora/client/commands/admin.py 
02d055f58e6a9bf906bc65a8cc4899e653c1679f 
  src/test/python/apache/aurora/client/commands/test_admin.py 
1e54ae068b88428dbc058c79d37a184eb409ab30 

Diff: https://reviews.apache.org/r/22701/diff/


Testing
---

./pants src/test/python/apache/aurora/client/commands:admin


Thanks,

Maxim Khutornenko

Re: Review Request 22701: Adding admin command to get locks.

2014-06-20 Thread Maxim Khutornenko 


> On June 20, 2014, 5:20 p.m., Bill Farner wrote:
> > src/test/python/apache/aurora/client/commands/test_admin.py, line 210
> > 
> >
> > How about a constant instead?

Done.


> On June 20, 2014, 5:20 p.m., Bill Farner wrote:
> > src/test/python/apache/aurora/client/commands/test_admin.py, line 235
> > 
> >
> > Consider using the constant fields directly here.

Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22701/#review46291
---


On June 17, 2014, 11:25 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22701/
> ---
> 
> (Updated June 17, 2014, 11:25 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-347
> https://issues.apache.org/jira/browse/AURORA-347
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding get_locks command to take advantage of the new getLocks RPC.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 19fc6782763544ada79e806b841853910fd628de 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 02d055f58e6a9bf906bc65a8cc4899e653c1679f 
>   src/test/python/apache/aurora/client/commands/test_admin.py 
> 1e54ae068b88428dbc058c79d37a184eb409ab30 
> 
> Diff: https://reviews.apache.org/r/22701/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client/commands:admin
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 22701: Adding admin command to get locks.

2014-06-20 Thread Mark Chu-Carroll 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22701/#review46311
---

Ship it!


Ship It!

- Mark Chu-Carroll


On June 17, 2014, 7:25 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22701/
> ---
> 
> (Updated June 17, 2014, 7:25 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-347
> https://issues.apache.org/jira/browse/AURORA-347
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding get_locks command to take advantage of the new getLocks RPC.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 19fc6782763544ada79e806b841853910fd628de 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 02d055f58e6a9bf906bc65a8cc4899e653c1679f 
>   src/test/python/apache/aurora/client/commands/test_admin.py 
> 1e54ae068b88428dbc058c79d37a184eb409ab30 
> 
> Diff: https://reviews.apache.org/r/22701/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client/commands:admin
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 22701: Adding admin command to get locks.

2014-06-20 Thread David McLaughlin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22701/#review46299
---

Ship it!


Ship It!

- David McLaughlin


On June 17, 2014, 11:25 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22701/
> ---
> 
> (Updated June 17, 2014, 11:25 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-347
> https://issues.apache.org/jira/browse/AURORA-347
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding get_locks command to take advantage of the new getLocks RPC.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 19fc6782763544ada79e806b841853910fd628de 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 02d055f58e6a9bf906bc65a8cc4899e653c1679f 
>   src/test/python/apache/aurora/client/commands/test_admin.py 
> 1e54ae068b88428dbc058c79d37a184eb409ab30 
> 
> Diff: https://reviews.apache.org/r/22701/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client/commands:admin
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 22701: Adding admin command to get locks.

2014-06-20 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22701/#review46291
---

Ship it!



src/test/python/apache/aurora/client/commands/test_admin.py


How about a constant instead?



src/test/python/apache/aurora/client/commands/test_admin.py


Consider using the constant fields directly here.


- Bill Farner


On June 17, 2014, 11:25 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22701/
> ---
> 
> (Updated June 17, 2014, 11:25 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-347
> https://issues.apache.org/jira/browse/AURORA-347
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding get_locks command to take advantage of the new getLocks RPC.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 19fc6782763544ada79e806b841853910fd628de 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 02d055f58e6a9bf906bc65a8cc4899e653c1679f 
>   src/test/python/apache/aurora/client/commands/test_admin.py 
> 1e54ae068b88428dbc058c79d37a184eb409ab30 
> 
> Diff: https://reviews.apache.org/r/22701/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client/commands:admin
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 22701: Adding admin command to get locks.

2014-06-20 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22701/#review46274
---


Ping.

- Maxim Khutornenko


On June 17, 2014, 11:25 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22701/
> ---
> 
> (Updated June 17, 2014, 11:25 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-347
> https://issues.apache.org/jira/browse/AURORA-347
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Adding get_locks command to take advantage of the new getLocks RPC.
> 
> 
> Diffs
> -
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 19fc6782763544ada79e806b841853910fd628de 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 02d055f58e6a9bf906bc65a8cc4899e653c1679f 
>   src/test/python/apache/aurora/client/commands/test_admin.py 
> 1e54ae068b88428dbc058c79d37a184eb409ab30 
> 
> Diff: https://reviews.apache.org/r/22701/diff/
> 
> 
> Testing
> ---
> 
> ./pants src/test/python/apache/aurora/client/commands:admin
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 22701: Adding admin command to get locks.

2014-06-17 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22701/
---

Review request for Aurora, David McLaughlin and Mark Chu-Carroll.


Bugs: AURORA-347
https://issues.apache.org/jira/browse/AURORA-347


Repository: aurora


Description
---

Adding get_locks command to take advantage of the new getLocks RPC.


Diffs
-

  src/main/python/apache/aurora/client/api/__init__.py 
19fc6782763544ada79e806b841853910fd628de 
  src/main/python/apache/aurora/client/commands/admin.py 
02d055f58e6a9bf906bc65a8cc4899e653c1679f 
  src/test/python/apache/aurora/client/commands/test_admin.py 
1e54ae068b88428dbc058c79d37a184eb409ab30 

Diff: https://reviews.apache.org/r/22701/diff/


Testing
---

./pants src/test/python/apache/aurora/client/commands:admin


Thanks,

Maxim Khutornenko