Re: Review Request 22788: Dropping the "Tasks killed" message.

2014-06-19 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22788/
---

(Updated June 19, 2014, 10:25 p.m.)


Review request for Aurora and Bill Farner.


Bugs: AURORA-533
https://issues.apache.org/jira/browse/AURORA-533


Repository: aurora


Description
---

Dropping the "Tasks killed" message.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
3616b3e93010c9482dc96d94bdeb42eddae41fb0 

Diff: https://reviews.apache.org/r/22788/diff/


Testing
---

gradle build


Thanks,

Maxim Khutornenko

Re: Review Request 22788: Dropping the "Tasks killed" message.

2014-06-19 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22788/
---

(Updated June 19, 2014, 10:24 p.m.)


Review request for Aurora and Bill Farner.


Changes
---

CR comments.


Bugs: AURORA-533
https://issues.apache.org/jira/browse/AURORA-533


Repository: aurora


Description
---

Dropping the "Tasks killed" message.


Diffs (updated)
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
3616b3e93010c9482dc96d94bdeb42eddae41fb0 

Diff: https://reviews.apache.org/r/22788/diff/


Testing
---

gradle build


Thanks,

Maxim Khutornenko

Re: Review Request 22788: Dropping the "Tasks killed" message.

2014-06-19 Thread Maxim Khutornenko 


> On June 19, 2014, 8:49 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
> >  line 624
> > 
> >
> > Consider okEmptyResponse().

Done.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22788/#review46225
---


On June 19, 2014, 8:45 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22788/
> ---
> 
> (Updated June 19, 2014, 8:45 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-533
> https://issues.apache.org/jira/browse/AURORA-533
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Dropping the "Tasks killed" message.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  3616b3e93010c9482dc96d94bdeb42eddae41fb0 
> 
> Diff: https://reviews.apache.org/r/22788/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 22788: Dropping the "Tasks killed" message.

2014-06-19 Thread Bill Farner 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22788/#review46225
---

Ship it!



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java


Consider okEmptyResponse().


- Bill Farner


On June 19, 2014, 8:45 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22788/
> ---
> 
> (Updated June 19, 2014, 8:45 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-533
> https://issues.apache.org/jira/browse/AURORA-533
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Dropping the "Tasks killed" message.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  3616b3e93010c9482dc96d94bdeb42eddae41fb0 
> 
> Diff: https://reviews.apache.org/r/22788/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 22788: Dropping the "Tasks killed" message.

2014-06-19 Thread Kevin Sweeney 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22788/#review46224
---

Ship it!


Ship It!

- Kevin Sweeney


On June 19, 2014, 1:45 p.m., Maxim Khutornenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22788/
> ---
> 
> (Updated June 19, 2014, 1:45 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-533
> https://issues.apache.org/jira/browse/AURORA-533
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> Dropping the "Tasks killed" message.
> 
> 
> Diffs
> -
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  3616b3e93010c9482dc96d94bdeb42eddae41fb0 
> 
> Diff: https://reviews.apache.org/r/22788/diff/
> 
> 
> Testing
> ---
> 
> gradle build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Review Request 22788: Dropping the "Tasks killed" message.

2014-06-19 Thread Maxim Khutornenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22788/
---

Review request for Aurora and Bill Farner.


Bugs: AURORA-533
https://issues.apache.org/jira/browse/AURORA-533


Repository: aurora


Description
---

Dropping the "Tasks killed" message.


Diffs
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
3616b3e93010c9482dc96d94bdeb42eddae41fb0 

Diff: https://reviews.apache.org/r/22788/diff/


Testing
---

gradle build


Thanks,

Maxim Khutornenko