Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated July 1, 2014, 8:33 p.m.) Review request for Aurora and Maxim Khutornen

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46865 --- Ship it! Ship It! - Maxim Khutornenko On June 26, 2014, 8:33 p.m

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated June 26, 2014, 8:33 p.m.) Review request for Aurora and Maxim Khutorne

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46796 --- Latest diff is bad, i managed to pick up some python code with my fi

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated June 26, 2014, 7:52 p.m.) Review request for Aurora and Maxim Khutorne

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

> On June 26, 2014, 6:21 p.m., Kevin Sweeney wrote: > > replace Preconditions.checkNotNull with Objects.requireNonNull as well? Great suggestion, i'll update the diff to add that. - Bill --- This is an automatically generated e-mail. To

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

> On June 26, 2014, 4:59 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, > > line 96 > > > > > > This seems like a repeating pattern to avoid naming collision.

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46770 --- replace Preconditions.checkNotNull with Objects.requireNonNull as we

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46758 --- src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.j

Review Request 22982: Use java.util.Objects replacements for guava helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti